GeoCachesEntity::isActiveAndFindable() - Code Metrics - Inspection of "Rework for occ 78 occ 79 occ 80" - OpencachingDeutschland/oc-server3 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — development (#813)

unknown

created 2021-02-03 21:45 UTC

GeoCachesEntity::isActiveAndFindable() A

↳ Parent: GeoCachesEntity

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	0
dl	0
loc	9
rs	9.9666
c	0
b	0
f	0

<?php

namespace Oc\Entity;

use DateTime;
use Oc\Repository\AbstractEntity;

/**
 * Class GeoCachesEntity
 *
 * @package Oc\Entity
 */
class GeoCachesEntity extends AbstractEntity
{
    /** @var int */
    public $cacheId;

    /** @var string */
    public $uuid;

    /** @var int */
    public $node;

    /** @var DateTime */
    public $dateCreated;

    /** @var int */
    public $isPublishdate;

    /** @var DateTime */
    public $lastModified;

    /** @var string */
    public $okapiSyncbase;

    /** @var DateTime */
    public $listingLastModified;

    /** @var DateTime */
    public $metaLastModified;

    /** @var int */
    public $userId;

    /** @var string */
    public $name;

    /** @var float */
    public $longitude;

    /** @var float */
    public $latitude;

    /** @var int */
    public $type;

    /** @var int */
    public $status;

    /** @var string */
    public $country;

    /** @var DateTime */
    public $dateHidden;

    /** @var int */
    public $size;

    /** @var int */
    public $difficulty;

    /** @var int */
    public $terrain;

    /** @var string */
    public $logpw;

    /** @var float */
    public $searchTime;

    /** @var float */
    public $wayLength;

    /** @var string */
    public $wpGc;

    /** @var string */
    public $wpGcMaintained;

    /** @var string */
    public $wpNc;

    /** @var string */
    public $wpOc;

    /** @var string */
    public $descLanguages;

    /** @var string */
    public $defaultDesclang;

    /** @var DateTime */
    public $dateActivate;

    /** @var int */
    public $needNpaRecalc;

    /** @var int */
    public $showCachelists;

    /** @var int */
    public $protectOldCoords;

    /** @var int */
    public $needsMaintenance;

    /** @var int */
    public $listingOutdated;

    /** @var DateTime */
    public $flagsLastModified;

    /** @var UserEntity */
    public $user;

    /** @var GeoCacheSizeEntity */
    public $cacheSize;

    /** @var GeoCacheStatusEntity */
    public $cacheStatus;

    /** @var GeoCacheTypeEntity */
    public $cacheType;

    /**
     * @return bool
     */
    public function isNew()
    : bool
    {
        return $this->cacheId === null;
    }

    /**
     * @return bool
     */
    public function isActiveAndFindable()
    : bool
    {
        if ($this->status == 1) {
            return true;
        } else {
            return false;
        }
    }
}


1			<?php
2
3			namespace Oc\Entity;
4
5			use DateTime;
6			use Oc\Repository\AbstractEntity;
7
8			/**
9			* Class GeoCachesEntity
10			*
11			* @package Oc\Entity
12			*/
13			class GeoCachesEntity extends AbstractEntity
14			{
15			/** @var int */
16			public $cacheId;
17
18			/** @var string */
19			public $uuid;
20
21			/** @var int */
22			public $node;
23
24			/** @var DateTime */
25			public $dateCreated;
26
27			/** @var int */
28			public $isPublishdate;
29
30			/** @var DateTime */
31			public $lastModified;
32
33			/** @var string */
34			public $okapiSyncbase;
35
36			/** @var DateTime */
37			public $listingLastModified;
38
39			/** @var DateTime */
40			public $metaLastModified;
41
42			/** @var int */
43			public $userId;
44
45			/** @var string */
46			public $name;
47
48			/** @var float */
49			public $longitude;
50
51			/** @var float */
52			public $latitude;
53
54			/** @var int */
55			public $type;
56
57			/** @var int */
58			public $status;
59
60			/** @var string */
61			public $country;
62
63			/** @var DateTime */
64			public $dateHidden;
65
66			/** @var int */
67			public $size;
68
69			/** @var int */
70			public $difficulty;
71
72			/** @var int */
73			public $terrain;
74
75			/** @var string */
76			public $logpw;
77
78			/** @var float */
79			public $searchTime;
80
81			/** @var float */
82			public $wayLength;
83
84			/** @var string */
85			public $wpGc;
86
87			/** @var string */
88			public $wpGcMaintained;
89
90			/** @var string */
91			public $wpNc;
92
93			/** @var string */
94			public $wpOc;
95
96			/** @var string */
97			public $descLanguages;
98
99			/** @var string */
100			public $defaultDesclang;
101
102			/** @var DateTime */
103			public $dateActivate;
104
105			/** @var int */
106			public $needNpaRecalc;
107
108			/** @var int */
109			public $showCachelists;
110
111			/** @var int */
112			public $protectOldCoords;
113
114			/** @var int */
115			public $needsMaintenance;
116
117			/** @var int */
118			public $listingOutdated;
119
120			/** @var DateTime */
121			public $flagsLastModified;
122
123			/** @var UserEntity */
124			public $user;
125
126			/** @var GeoCacheSizeEntity */
127			public $cacheSize;
128
129			/** @var GeoCacheStatusEntity */
130			public $cacheStatus;
131
132			/** @var GeoCacheTypeEntity */
133			public $cacheType;
134
135			/**
136			* @return bool
137			*/
138			public function isNew()
139			: bool
140			{
141			return $this->cacheId === null;
142			}
143
144			/**
145			* @return bool
146			*/
147			public function isActiveAndFindable()
148			: bool
149			{
150			if ($this->status == 1) {
151			return true;
152			} else {
153			return false;
154			}
155			}
156			}
157

OpencachingDeutschland / oc-server3

Pull Request — development (#813)

GeoCachesEntity::isActiveAndFindable() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like