Completed
Pull Request — master (#313)
by Thomas
18:52 queued 11:36
created
htdocs/mydetails.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -5,8 +5,8 @@  discard block
 block discarded – undo
5 5
  *  Unicode Reminder メモ
6 6
  ***************************************************************************/
7 7
 
8
-require __DIR__ . '/lib2/web.inc.php';
9
-require_once __DIR__ . '/lib2/edithelper.inc.php';
8
+require __DIR__.'/lib2/web.inc.php';
9
+require_once __DIR__.'/lib2/edithelper.inc.php';
10 10
 
11 11
 $tpl->name = 'mydetails';
12 12
 $tpl->menuitem = MNU_MYPROFILE_DETAILS;
@@ -51,8 +51,8 @@  discard block
 block discarded – undo
51 51
 
52 52
         while ($record = sql_fetch_array($rs)) {
53 53
             $id = $record['id'];
54
-            $vis = isset($_REQUEST['chk' . $id]) ? $_REQUEST['chk' . $id] + 0 : 0;
55
-            $value = isset($_REQUEST['inp' . $id]) ? $_REQUEST['inp' . $id] : '';
54
+            $vis = isset($_REQUEST['chk'.$id]) ? $_REQUEST['chk'.$id] + 0 : 0;
55
+            $value = isset($_REQUEST['inp'.$id]) ? $_REQUEST['inp'.$id] : '';
56 56
             if ($vis != 1) {
57 57
                 $vis = 0;
58 58
             }
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
                 $bErrorlen = true;
64 64
             } else {
65 65
                 if (!$useroptions->setOptValue($id, $value)) {
66
-                    $error .= $useroptions->getOptName($id) . ', ';
66
+                    $error .= $useroptions->getOptName($id).', ';
67 67
                     $bError = true;
68 68
                 }
69 69
             }
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
         }
173 173
         if ($descMode == 3) {
174 174
             $tpl->add_header_javascript('resource2/tinymce/tiny_mce_gzip.js');
175
-            $tpl->add_header_javascript('resource2/tinymce/config/user.js.php?lang=' . strtolower($opt['template']['locale']));
175
+            $tpl->add_header_javascript('resource2/tinymce/config/user.js.php?lang='.strtolower($opt['template']['locale']));
176 176
         }
177 177
         $tpl->add_header_javascript(editorJsPath());
178 178
         $tpl->assign('descMode', $descMode);
Please login to merge, or discard this patch.
htdocs/doc/sql/stored-proc/old/distance.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -9,13 +9,13 @@
 block discarded – undo
9 9
  ***************************************************************************/
10 10
 
11 11
 $opt['rootpath'] = '../../../';
12
-require_once $opt['rootpath'] . 'lib/clicompatbase.inc.php';
12
+require_once $opt['rootpath'].'lib/clicompatbase.inc.php';
13 13
 
14
-if (!file_exists($opt['rootpath'] . 'util/mysql_root/sql_root.inc.php')) {
15
-    die("\n" . 'install util/mysql_root/sql_root.inc.php' . "\n\n");
14
+if (!file_exists($opt['rootpath'].'util/mysql_root/sql_root.inc.php')) {
15
+    die("\n".'install util/mysql_root/sql_root.inc.php'."\n\n");
16 16
 }
17 17
 
18
-require_once $opt['rootpath'] . 'util/mysql_root/sql_root.inc.php';
18
+require_once $opt['rootpath'].'util/mysql_root/sql_root.inc.php';
19 19
 
20 20
 /* begin db connect */
21 21
 db_root_connect();
Please login to merge, or discard this patch.
htdocs/doc/sql/stored-proc/maintain-113.inc.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -448,7 +448,7 @@  discard block
 block discarded – undo
448 448
 
449 449
    SELECT GROUP_CONCAT(DISTINCT `language` ORDER BY `language` SEPARATOR ',') INTO dl FROM `cache_desc` WHERE `cache_id`=nCacheId GROUP BY `cache_id` ;
450 450
    UPDATE `caches` SET `desc_languages`=dl, default_desclang=PREFERED_LANG(dl, '&1') WHERE `cache_id`=nCacheId LIMIT 1;
451
- END;", strtoupper($lang . ',EN'));
451
+ END;", strtoupper($lang.',EN'));
452 452
 
453 453
 // set caches.desc_languages of all caches, fill cache_desc_prefered and return number of modified rows
454 454
 sql_dropProcedure('sp_updateall_caches_descLanguages');
@@ -456,7 +456,7 @@  discard block
 block discarded – undo
456 456
  BEGIN
457 457
    UPDATE `caches`, (SELECT `cache_id`, GROUP_CONCAT(DISTINCT `language` ORDER BY `language` SEPARATOR ',') AS `dl` FROM `cache_desc` GROUP BY `cache_id`) AS `tbl` SET `caches`.`desc_languages`=`tbl`.`dl`, `caches`.`default_desclang`=PREFERED_LANG(`tbl`.`dl`, '&1') WHERE `caches`.`cache_id`=`tbl`.`cache_id`;
458 458
    SET nModified = ROW_COUNT() ;
459
- END;", strtoupper($lang . ',EN'));
459
+ END;", strtoupper($lang.',EN'));
460 460
 
461 461
 // update found, last_found, notfound and note of stat_cache_logs, stat_caches and stat_user
462 462
 sql_dropProcedure('sp_update_logstat');
@@ -808,7 +808,7 @@  discard block
 block discarded – undo
808 808
                     SET @dont_update_listingdate=0;
809 809
                 END;",
810 810
                 $opt['logic']['waypoint_pool']['prefix'],
811
-                '^' . $opt['logic']['waypoint_pool']['prefix'] . '[' . $opt['logic']['waypoint_pool']['valid_chars'] . ']{1,}$');
811
+                '^'.$opt['logic']['waypoint_pool']['prefix'].'['.$opt['logic']['waypoint_pool']['valid_chars'].']{1,}$');
812 812
 
813 813
 sql_dropTrigger('cachesAfterInsert');
814 814
 sql("CREATE TRIGGER `cachesAfterInsert` AFTER INSERT ON `caches`
Please login to merge, or discard this patch.
htdocs/doc/sql/stored-proc/maintain-153.inc.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
             LIMIT 1;
205 205
         END IF;
206 206
      END;",
207
-    strtoupper($lang . ',EN')
207
+    strtoupper($lang.',EN')
208 208
 );
209 209
 
210 210
 // set caches.desc_languages of all caches, fill cache_desc_prefered and return number of modified rows
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
         
226 226
         SET nModified = ROW_COUNT();
227 227
      END;",
228
-    strtoupper($lang . ',EN')
228
+    strtoupper($lang.',EN')
229 229
 );
230 230
 
231 231
 // update found, last_found, notfound and note of stat_cache_logs, stat_caches and stat_user,
@@ -909,7 +909,7 @@  discard block
 block discarded – undo
909 909
         SET @dont_update_listingdate=0;
910 910
      END;",
911 911
     $opt['logic']['waypoint_pool']['prefix'],
912
-    '^' . $opt['logic']['waypoint_pool']['prefix'] . '[' . $opt['logic']['waypoint_pool']['valid_chars'] . ']{1,}$'
912
+    '^'.$opt['logic']['waypoint_pool']['prefix'].'['.$opt['logic']['waypoint_pool']['valid_chars'].']{1,}$'
913 913
 );
914 914
 
915 915
 sql_dropTrigger('cachesAfterInsert');
Please login to merge, or discard this patch.
htdocs/doc/sql/stored-proc/maintain.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -8,8 +8,8 @@  discard block
 block discarded – undo
8 8
  *  Load current stored procs and triggers into database.
9 9
  ***************************************************************************/
10 10
 
11
-$opt['rootpath'] = __DIR__ . '/../../../';
12
-require $opt['rootpath'] . 'lib2/cli.inc.php';
11
+$opt['rootpath'] = __DIR__.'/../../../';
12
+require $opt['rootpath'].'lib2/cli.inc.php';
13 13
 
14 14
 if ($opt['db']['maintenance_user'] == '') {
15 15
     die("ERROR: \$opt['db']['maintenance_user'] is not set in config2/settings.inc.php\n");
@@ -18,10 +18,10 @@  discard block
 block discarded – undo
18 18
 // retrieve DB password
19 19
 if ($opt['db']['maintenance_password'] == '') {
20 20
     if (in_array('--flush', $argv)) {
21
-        echo "\nenter DB " . $opt['db']['maintenance_user'] . " password:\n";
21
+        echo "\nenter DB ".$opt['db']['maintenance_user']." password:\n";
22 22
         flush();
23 23
     } else {
24
-        echo 'enter DB ' . $opt['db']['maintenance_user'] . ' password: ';
24
+        echo 'enter DB '.$opt['db']['maintenance_user'].' password: ';
25 25
     }
26 26
 
27 27
     $fh = fopen('php://stdin', 'r');
@@ -44,13 +44,13 @@  discard block
 block discarded – undo
44 44
 // include the requested maintain version file
45 45
 $dbsv = in_array('--dbsv', $argv);
46 46
 if ($dbsv) {
47
-    $versionfile = 'maintain-' . $argv[$dbsv + 1] . '.inc.php';
48
-    if (!file_exists(__DIR__ . '/' . $versionfile)) {
49
-        die($versionfile . " not found\n");
47
+    $versionfile = 'maintain-'.$argv[$dbsv + 1].'.inc.php';
48
+    if (!file_exists(__DIR__.'/'.$versionfile)) {
49
+        die($versionfile." not found\n");
50 50
     } else {
51 51
         require $versionfile;
52 52
     }
53
-    @unlink($opt['rootpath'] . 'cache2/dbsv-running');
53
+    @unlink($opt['rootpath'].'cache2/dbsv-running');
54 54
 } else {
55 55
     require 'maintain-current.inc.php';
56 56
 }
Please login to merge, or discard this patch.
htdocs/articles.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@  discard block
 block discarded – undo
5 5
  *  Unicode Reminder メモ
6 6
  ***************************************************************************/
7 7
 
8
-require __DIR__ . '/lib2/web.inc.php';
8
+require __DIR__.'/lib2/web.inc.php';
9 9
 
10 10
 //get the article name to display
11 11
 $article = '';
@@ -23,20 +23,20 @@  discard block
 block discarded – undo
23 23
     $tpl->redirect('index.php');
24 24
 } elseif (isset($_REQUEST['wiki'])) {
25 25
     $tpl->redirect(helppageurl($article));
26
-} elseif (!file_exists($opt['stylepath'] . '/articles/' . $language . '/' . $article . '.tpl')) {
26
+} elseif (!file_exists($opt['stylepath'].'/articles/'.$language.'/'.$article.'.tpl')) {
27 27
     // does article exist in default-language?
28
-    $file = $opt['stylepath'] . '/articles/' . $opt['template']['default']['article_locale'] . '/' . $article . '.tpl';
28
+    $file = $opt['stylepath'].'/articles/'.$opt['template']['default']['article_locale'].'/'.$article.'.tpl';
29 29
     if (file_exists($file)) {
30 30
         $language = $opt['template']['default']['article_locale'];
31
-    } elseif (file_exists($opt['stylepath'] . '/articles/EN/' . $article . '.tpl')) {
31
+    } elseif (file_exists($opt['stylepath'].'/articles/EN/'.$article.'.tpl')) {
32 32
         $language = 'EN';
33 33
     } else {
34 34
         // use any
35 35
         $language = false;
36
-        if ($hDir = opendir($opt['stylepath'] . '/articles/')) {
36
+        if ($hDir = opendir($opt['stylepath'].'/articles/')) {
37 37
             while ((($sFile = readdir($hDir)) !== false) && ($language === false)) {
38
-                if (($sFile != '.') && ($sFile != '..') && (is_dir($opt['stylepath'] . '/articles/' . $sFile))) {
39
-                    if (file_exists($opt['stylepath'] . '/articles/' . $sFile . '/' . $article . '.tpl')) {
38
+                if (($sFile != '.') && ($sFile != '..') && (is_dir($opt['stylepath'].'/articles/'.$sFile))) {
39
+                    if (file_exists($opt['stylepath'].'/articles/'.$sFile.'/'.$article.'.tpl')) {
40 40
                         $language = $sFile;
41 41
                     }
42 42
                 }
@@ -54,13 +54,13 @@  discard block
 block discarded – undo
54 54
 $tpl->name = 'articles';
55 55
 
56 56
 $tpl->caching = true;
57
-$tpl->cache_id = 'articles|' . $language . '|' . $article;
57
+$tpl->cache_id = 'articles|'.$language.'|'.$article;
58 58
 $tpl->cache_lifetime = 43200;
59 59
 
60 60
 $tpl->menuitem = sql_value(
61 61
     "SELECT `id` FROM `sys_menu` WHERE `href`='&1' LIMIT 1",
62 62
     0,
63
-    'articles.php?page=' . urlencode($article)
63
+    'articles.php?page='.urlencode($article)
64 64
 );
65 65
 if ($tpl->menuitem == 0) {
66 66
     $tpl->redirect('index.php');
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
     /* prepare smarty vars for special pages ...
75 75
      */
76 76
     if ($article == 'cacheinfo') {
77
-        require_once $opt['rootpath'] . 'lib2/logic/attribute.class.php';
77
+        require_once $opt['rootpath'].'lib2/logic/attribute.class.php';
78 78
         $attributes = attribute::getSelectableAttrbutesListArray(true);
79 79
         $tpl->assign('attributes', $attributes);
80 80
     }
Please login to merge, or discard this patch.
htdocs/activation.php 1 patch
Spacing   +3 added lines, -5 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@  discard block
 block discarded – undo
6 6
  ***************************************************************************/
7 7
 
8 8
 $disable_verifyemail = true;
9
-require __DIR__ . '/lib2/web.inc.php';
9
+require __DIR__.'/lib2/web.inc.php';
10 10
 
11 11
 $tpl->name = 'activation';
12 12
 $tpl->menuitem = MNU_START_REGISTER_ACTIVATION;
@@ -14,10 +14,8 @@  discard block
 block discarded – undo
14 14
 // We use short param codes 'u' and 'c' to generate short-enough activation
15 15
 // url that will not be wrapped in plain-text emails.
16 16
 
17
-$code = isset($_REQUEST['code']) ? trim($_REQUEST['code']) :
18
-    (isset($_REQUEST['c']) ? trim($_REQUEST['c']) : '');
19
-$email = isset($_REQUEST['email']) ? trim($_REQUEST['email']) :
20
-    (isset($_REQUEST['e']) ? trim($_REQUEST['e']) : '');
17
+$code = isset($_REQUEST['code']) ? trim($_REQUEST['code']) : (isset($_REQUEST['c']) ? trim($_REQUEST['c']) : '');
18
+$email = isset($_REQUEST['email']) ? trim($_REQUEST['email']) : (isset($_REQUEST['e']) ? trim($_REQUEST['e']) : '');
21 19
 
22 20
 $tpl->assign('errorEMail', false);
23 21
 $tpl->assign('errorCode', false);
Please login to merge, or discard this patch.
htdocs/addtolist.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@  discard block
 block discarded – undo
5 5
  *  Unicode Reminder メモ
6 6
  ***************************************************************************/
7 7
 
8
-require __DIR__ . '/lib2/web.inc.php';
8
+require __DIR__.'/lib2/web.inc.php';
9 9
 
10 10
 $tpl->name = 'addtolist';
11 11
 $tpl->menuitem = MNU_CACHES_ADDTOLIST;
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 $tpl->assign('cacheid', $cacheid);
23 23
 
24 24
 if (isset($_REQUEST['cancel'])) {
25
-    $tpl->redirect('viewcache.php?cacheid=' . $cacheid);
25
+    $tpl->redirect('viewcache.php?cacheid='.$cacheid);
26 26
 }
27 27
 
28 28
 $newlist_name = isset($_REQUEST['newlist_name']) ? trim($_REQUEST['newlist_name']) : false;
@@ -44,14 +44,14 @@  discard block
 block discarded – undo
44 44
                     $cachelist->watch(true);
45 45
                 }
46 46
             }
47
-            $tpl->redirect('viewcache.php?cacheid=' . $cacheid);
47
+            $tpl->redirect('viewcache.php?cacheid='.$cacheid);
48 48
         }
49 49
     } else {
50 50
         $cachelist = new cachelist($listid);
51 51
         if ($cachelist->exist()) {
52 52
             $cachelist->addCacheByID($cacheid);
53 53
         }
54
-        $tpl->redirect('viewcache.php?cacheid=' . $cacheid);
54
+        $tpl->redirect('viewcache.php?cacheid='.$cacheid);
55 55
     }
56 56
 }
57 57
 
Please login to merge, or discard this patch.
htdocs/newlogs.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@  discard block
 block discarded – undo
5 5
  *  Unicode Reminder メモ
6 6
  ***************************************************************************/
7 7
 
8
-require __DIR__ . '/lib2/web.inc.php';
8
+require __DIR__.'/lib2/web.inc.php';
9 9
 
10 10
 $add_where = '';
11 11
 $newLogsPerCountry = $opt['logic']['new_logs_per_country'];
@@ -30,9 +30,9 @@  discard block
 block discarded – undo
30 30
     $country = false;
31 31
     $exclude_country = '*';
32 32
     $include_country = '%';
33
-    $add_where = "AND `caches`.`user_id`='" . sql_escape($ownerid) . "' ";
33
+    $add_where = "AND `caches`.`user_id`='".sql_escape($ownerid)."' ";
34 34
     if (!$show_own_logs) {
35
-        $add_where .= "AND `cache_logs`.`user_id`<>'" . sql_escape($login->userid) . "' ";
35
+        $add_where .= "AND `cache_logs`.`user_id`<>'".sql_escape($login->userid)."' ";
36 36
     }
37 37
     $tpl->caching = false;
38 38
     $logcount = 100;
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
     $country = false;
50 50
     $exclude_country = '*';
51 51
     $include_country = '%';
52
-    $add_where = "AND `cache_logs`.`user_id`='" . sql_escape($userid) . "' ";
52
+    $add_where = "AND `cache_logs`.`user_id`='".sql_escape($userid)."' ";
53 53
     $tpl->caching = false;
54 54
     $logcount = 100;
55 55
     $paging = true;
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
     $tpl->cache_lifetime = 900;
70 70
     $tpl->cache_id = $exclude_country;
71 71
     $logcount = 250;
72
-    $paging = false;  // paging would have poor performance for all logs
72
+    $paging = false; // paging would have poor performance for all logs
73 73
     $orderByDate = $logselection == 3 ? "{fromtable}.`order_date` DESC, " : "";
74 74
 } else {
75 75
     // latest logs for all countries or for one country
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     $tpl->cache_lifetime = 300;
89 89
     $tpl->cache_id = $country;
90 90
     $logcount = 250;
91
-    $paging = false;  // paging would have poor performance for all logs
91
+    $paging = false; // paging would have poor performance for all logs
92 92
     $orderByDate = $logselection == 3 ? "{fromtable}.`order_date` DESC, " : "";
93 93
     $optimize_for_latest_logs = ($country == '' || $country == $opt['page']['main_country']);
94 94
 }
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 if ($logselection == 1) {
102 102
     $add_where .= "AND DATEDIFF(NOW(), {fromtable}.`date`) < 30 ";
103 103
 }
104
-$tpl->cache_id .= "|" . $logselection;
104
+$tpl->cache_id .= "|".$logselection;
105 105
 
106 106
 $tpl->change_country_inpage = true;
107 107
 
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
                 `needs_maintenance`, `listing_outdated`, `order_date`
122 122
              FROM `cache_logs`
123 123
              ORDER BY `date_created` DESC
124
-             LIMIT " . (4 * $logcount) . ")"
124
+             LIMIT " . (4 * $logcount).")"
125 125
         );
126 126
         $fromtable = '`&loglist0`';
127 127
     } else {
@@ -132,16 +132,16 @@  discard block
 block discarded – undo
132 132
     sql_temp_table_slave('loglist');
133 133
     sql_slave(
134 134
         "CREATE TEMPORARY TABLE &loglist (`id` INT(11) PRIMARY KEY)
135
-        SELECT " . ($paging ? "SQL_CALC_FOUND_ROWS" : "") . " " . $fromtable . ".`id`
136
-        FROM " . $fromtable . "
137
-        INNER JOIN `caches` ON " . $fromtable . ".`cache_id`=`caches`.`cache_id`
135
+        SELECT " . ($paging ? "SQL_CALC_FOUND_ROWS" : "")." ".$fromtable.".`id`
136
+        FROM " . $fromtable."
137
+        INNER JOIN `caches` ON " . $fromtable.".`cache_id`=`caches`.`cache_id`
138 138
         INNER JOIN `cache_status` ON `caches`.`status`=`cache_status`.`id`
139
-        INNER JOIN `user` ON " . $fromtable . ".`user_id`=`user`.`user_id`
139
+        INNER JOIN `user` ON " . $fromtable.".`user_id`=`user`.`user_id`
140 140
         WHERE `cache_status`.`allow_user_view`=1
141 141
         AND `caches`.`country` LIKE '&1'
142 142
         AND `caches`.`country`<>'&2'
143
-        " . $add_where . "
144
-        ORDER BY " . str_replace("{fromtable}", $fromtable, $orderByDate) . $fromtable . ".`date_created` DESC
143
+        " . $add_where."
144
+        ORDER BY " . str_replace("{fromtable}", $fromtable, $orderByDate).$fromtable.".`date_created` DESC
145 145
         LIMIT &3, &4",
146 146
         $include_country,
147 147
         $exclude_country,
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
             ON `caches_attributes`.`cache_id`=`caches`.`cache_id`
203 203
             AND `caches_attributes`.`attrib_id`=6
204 204
         WHERE IFNULL(`cache_logs_restored`.`restored_by`,0)=0
205
-        ORDER BY " . $orderByCountry . str_replace("{fromtable}", "`cache_logs`", $orderByDate) . "`cache_logs`.`date_created` DESC",
205
+        ORDER BY " . $orderByCountry.str_replace("{fromtable}", "`cache_logs`", $orderByDate)."`cache_logs`.`date_created` DESC",
206 206
         $opt['template']['locale']
207 207
     );
208 208
 
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
             }
248 248
             sql_free_result($rsPic);
249 249
         }
250
-        $pics --;
250
+        $pics--;
251 251
 
252 252
         $rLog['first'] = false;
253 253
         if (isset($caches_logged)) {
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
 
302 302
     $tpl->assign('paging', $paging);
303 303
     if ($paging) {
304
-        $pager = new pager($_SERVER["SCRIPT_NAME"] . '?startat={offset}' . $urlparams);
304
+        $pager = new pager($_SERVER["SCRIPT_NAME"].'?startat={offset}'.$urlparams);
305 305
         $pager->make_from_offset($startat, $total_logs, $logcount);
306 306
     }
307 307
 }
Please login to merge, or discard this patch.