Completed
Pull Request — master (#313)
by Thomas
18:52 queued 11:36
created
htdocs/util2/cron/fill_search_index.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,10 +12,10 @@
 block discarded – undo
12 12
  ****************************************************************************/
13 13
 
14 14
 // needs absolute rootpath because called as cronjob
15
-$opt['rootpath'] = __DIR__ . '/../../';
15
+$opt['rootpath'] = __DIR__.'/../../';
16 16
 
17
-require __DIR__ . '/../../lib2/cli.inc.php';
18
-require __DIR__ . '/../../lib2/search/ftsearch.inc.php';
17
+require __DIR__.'/../../lib2/cli.inc.php';
18
+require __DIR__.'/../../lib2/search/ftsearch.inc.php';
19 19
 
20 20
 if (!cronjobs_enabled()) {
21 21
     exit;
Please login to merge, or discard this patch.
htdocs/util2/cron/modules/gcwp_update.class.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@  discard block
 block discarded – undo
13 13
 class gcwp_update
14 14
 {
15 15
     public $name = 'gcwp_update';
16
-    public $interval = 3600;  // every hour
16
+    public $interval = 3600; // every hour
17 17
 
18 18
 
19 19
     public function run()
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
         foreach ($opt['cron']['gcwp']['sources'] as $source) {
27 27
             $wpdata = @file($source);
28 28
             if ($wpdata === false) {
29
-                echo 'gcwp_update: error reading ' . $source . "\n";
29
+                echo 'gcwp_update: error reading '.$source."\n";
30 30
                 $errors = true;
31 31
             } else {
32 32
                 foreach ($wpdata as $line) {
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
                 "
49 49
                     UPDATE caches
50 50
                     SET wp_gc_maintained = UCASE(TRIM(wp_gc))
51
-                    WHERE wp_oc NOT IN ('" . implode("','", $ocwp_imported) . "')"
51
+                    WHERE wp_oc NOT IN ('" . implode("','", $ocwp_imported)."')"
52 52
             );
53 53
         }
54 54
     }
Please login to merge, or discard this patch.
htdocs/util2/cron/modules/autoarchive_caches.class.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
 class autoarchive
13 13
 {
14 14
     public $name = 'autoarchive';
15
-    public $interval = 43200;  // twice per day
15
+    public $interval = 43200; // twice per day
16 16
 
17 17
 
18 18
     public function run()
@@ -21,12 +21,12 @@  discard block
 block discarded – undo
21 21
 
22 22
         if ($opt['cron']['autoarchive']['run']) {
23 23
             if (!$login->logged_in()) {
24
-                echo $this->name . ": not logged in / no system user configured\n";
24
+                echo $this->name.": not logged in / no system user configured\n";
25 25
             } elseif ($login->hasAdminPriv(ADMIN_USER)) {
26 26
                 $this->archive_disabled_caches();
27 27
                 $this->archive_events();
28 28
             } else {
29
-                echo $this->name . ": user '" . $opt['logic']['systemuser']['user'] . "' cannot maintain caches\n";
29
+                echo $this->name.": user '".$opt['logic']['systemuser']['user']."' cannot maintain caches\n";
30 30
             }
31 31
         }
32 32
     }
@@ -80,12 +80,12 @@  discard block
 block discarded – undo
80 80
                 $months = ($rCache['listing_age'] > 366 ? 12 : 6);
81 81
                 $this->archive_cache(
82 82
                     $rCache['cache_id'],
83
-                    'This cache has been "temporarily unavailable" for more than %1 months now; ' .
84
-                    'therefore it is being archived automatically. The owner may decide to ' .
83
+                    'This cache has been "temporarily unavailable" for more than %1 months now; '.
84
+                    'therefore it is being archived automatically. The owner may decide to '.
85 85
                     'maintain the cache and re-enable the listing.',
86 86
                     $months
87 87
                 );
88
-                ++ $archived;
88
+                ++$archived;
89 89
 
90 90
                 // This limit throttles archiving. If something goes wrong, it won't
91 91
                 // produce too much trouble.
@@ -113,8 +113,8 @@  discard block
 block discarded – undo
113 113
         while ($rCache = sql_fetch_assoc($rs)) {
114 114
             $this->archive_cache(
115 115
                 $rCache['cache_id'],
116
-                'This event took place more than five weeks ago; therefore it is ' .
117
-                'being archived automatically. The owner may re-enable the listing ' .
116
+                'This event took place more than five weeks ago; therefore it is '.
117
+                'being archived automatically. The owner may re-enable the listing '.
118 118
                 'if it should stay active for some exceptional reason.'
119 119
             );
120 120
         }
@@ -127,11 +127,11 @@  discard block
 block discarded – undo
127 127
 
128 128
         $log = cachelog::createNew($cache_id, $login->userid);
129 129
         if ($log === false) {
130
-            echo $this->name . ": cannot create log for cache $cache_id\n";
130
+            echo $this->name.": cannot create log for cache $cache_id\n";
131 131
         } else {
132 132
             $cache = new cache($cache_id);
133 133
             if (!$cache->setStatus(3) || !$cache->save()) {
134
-                echo $this->name . ": cannot change status of cache $cache_id\n";
134
+                echo $this->name.": cannot change status of cache $cache_id\n";
135 135
             } else {
136 136
                 // create log
137 137
                 $log->setType(cachelog::LOGTYPE_ARCHIVED, true);
@@ -143,11 +143,11 @@  discard block
 block discarded – undo
143 143
                 // create log text in appropriate language
144 144
                 $translated_comment = $translate->t($comment, '', '', 0, '', 1, $cache->getDefaultDescLanguage());
145 145
                 $translated_comment = str_replace('%1', $months, $translated_comment);
146
-                $log->setText('<p>' . $translated_comment . '</p>');
146
+                $log->setText('<p>'.$translated_comment.'</p>');
147 147
                 $log->setTextHtml(1);
148 148
 
149 149
                 if (!$log->save()) {
150
-                    echo $this->name . ": could not save archive log for cache $cache_id\n";
150
+                    echo $this->name.": could not save archive log for cache $cache_id\n";
151 151
                 }
152 152
             }
153 153
         }
Please login to merge, or discard this patch.
htdocs/util2/cron/modules/okapi_cleanup.class.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
     {
19 19
         global $opt;
20 20
 
21
-        $files = glob($opt['okapi']['var_dir'] . '/garmin*.zip');
21
+        $files = glob($opt['okapi']['var_dir'].'/garmin*.zip');
22 22
         foreach ($files as $file) {
23 23
             // delete old download files after 24 hours; this large interval filters out any
24 24
             // timezone mismatches in file sysytems (e.g. on unconventional development
Please login to merge, or discard this patch.
htdocs/util2/cron/modules/cache_npa_areas.class.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,12 +26,12 @@  discard block
 block discarded – undo
26 26
             $rsLayers = sql(
27 27
                 "SELECT `id`, `type_id`, AsText(`shape`) AS `geometry`
28 28
                 FROM `npa_areas` WHERE `exclude`=0 AND MBRWITHIN(GeomFromText('&1'), `shape`)",
29
-                'POINT(' . $rCache['longitude'] . ' ' . $rCache['latitude'] . ')'
29
+                'POINT('.$rCache['longitude'].' '.$rCache['latitude'].')'
30 30
             );
31 31
             while ($rLayers = sql_fetch_assoc($rsLayers)) {
32 32
                 if (gis::ptInLineRing(
33 33
                     $rLayers['geometry'],
34
-                    'POINT(' . $rCache['longitude'] . ' ' . $rCache['latitude'] . ')'
34
+                    'POINT('.$rCache['longitude'].' '.$rCache['latitude'].')'
35 35
                 )
36 36
                 ) {
37 37
                     $bExclude = false;
@@ -44,12 +44,12 @@  discard block
 block discarded – undo
44 44
                         AND `type_id`='&1'
45 45
                         AND MBRWITHIN(GeomFromText('&2'), `shape`)",
46 46
                         $rLayers['type_id'],
47
-                        'POINT(' . $rCache['longitude'] . ' ' . $rCache['latitude'] . ')'
47
+                        'POINT('.$rCache['longitude'].' '.$rCache['latitude'].')'
48 48
                     );
49 49
                     while (($rExclude = sql_fetch_assoc($rsExclude)) && ($bExclude == false)) {
50 50
                         if (gis::ptInLineRing(
51 51
                             $rExclude['geometry'],
52
-                            'POINT(' . $rCache['longitude'] . ' ' . $rCache['latitude'] . ')'
52
+                            'POINT('.$rCache['longitude'].' '.$rCache['latitude'].')'
53 53
                         )
54 54
                         ) {
55 55
                             $bExclude = true;
Please login to merge, or discard this patch.
htdocs/util2/cron/modules/orphan_cleanup.class.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@  discard block
 block discarded – undo
13 13
 class orphan_cleanup
14 14
 {
15 15
     public $name = 'orphan_cleanup';
16
-    public $interval = 86400;   // once per day
16
+    public $interval = 86400; // once per day
17 17
 
18 18
     public function run()
19 19
     {
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
                 "DELETE FROM `xmlsession_data`
36 36
                  WHERE `session_id` IN (SELECT `session_id` FROM &tmpsessiondata)"
37 37
             );
38
-            echo 'orphan_cleanup: dropped ' . $count . " record(s) from xmlsession_data\n";
38
+            echo 'orphan_cleanup: dropped '.$count." record(s) from xmlsession_data\n";
39 39
         }
40 40
         sql_drop_temp_table('tmpsessiondata');
41 41
 
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
                 "DELETE FROM `map2_data`
58 58
                  WHERE `result_id` IN (SELECT `result_id` FROM &tmpsessiondata)"
59 59
             );
60
-            echo 'orphan_cleanup: dropped ' . $count . " record(s) from map2_data\n";
60
+            echo 'orphan_cleanup: dropped '.$count." record(s) from map2_data\n";
61 61
         }
62 62
         sql_drop_temp_table('tmpsessiondata');
63 63
     }
Please login to merge, or discard this patch.
htdocs/util2/cron/modules/picture_cleanup.class.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -49,10 +49,10 @@
 block discarded – undo
49 49
                                 == file_get_contents($instances[$n]['pic']->getFilename())
50 50
                             ) {
51 51
                                 $picture = $instances[$n]['pic'];
52
-                                echo 'deleting duplicate picture ' . $picture->getPictureId(
53
-                                    ) . ' ("' . $picture->getTitle() . '")' .
54
-                                    ' from log ' . $rDuplicatePic['object_id'] .
55
-                                    ' of cache ' . $instances[$n]['cache_id'] . "\n";
52
+                                echo 'deleting duplicate picture '.$picture->getPictureId(
53
+                                    ).' ("'.$picture->getTitle().'")'.
54
+                                    ' from log '.$rDuplicatePic['object_id'].
55
+                                    ' of cache '.$instances[$n]['cache_id']."\n";
56 56
                                 $picture->delete(false);
57 57
                                 $instances[$n]['filesize'] = false;
58 58
                                 break;
Please login to merge, or discard this patch.
htdocs/util2/cron/modules/push_waypoint_reports.class.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -27,15 +27,15 @@
 block discarded – undo
27 27
                     $result = 'ok';
28 28
                 } else {
29 29
                     $result = @file_get_contents(
30
-                        $opt['cron']['gcwp']['report'] .
31
-                        '?ocwp=' . urlencode($r['wp_oc']) .
32
-                        '&gcwp=' . urlencode($r['wp_external']) .
33
-                        '&source=' . urlencode($r['source'])
30
+                        $opt['cron']['gcwp']['report'].
31
+                        '?ocwp='.urlencode($r['wp_oc']).
32
+                        '&gcwp='.urlencode($r['wp_external']).
33
+                        '&source='.urlencode($r['source'])
34 34
                     );
35 35
                     $result = trim($result);
36 36
                 }
37 37
                 if ($result != 'ok') {
38
-                    echo "could not push GC waypoint report (id " . $r['report_id'] . "): " . $result . "\n";
38
+                    echo "could not push GC waypoint report (id ".$r['report_id']."): ".$result."\n";
39 39
                     break;
40 40
                 } else {
41 41
                     sql(
Please login to merge, or discard this patch.
htdocs/util2/cron/modules/geokrety.class.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -42,17 +42,17 @@  discard block
 block discarded – undo
42 42
     {
43 43
         global $opt;
44 44
 
45
-        if (!@mkdir(__DIR__ . '/../../../cache2/geokrety')) {
45
+        if (!@mkdir(__DIR__.'/../../../cache2/geokrety')) {
46 46
             // die('can\'t create geogrety cache dir');
47 47
         }
48
-        $path = __DIR__ . '/../../../cache2/geokrety/import-' . date('Ymd-His') . '.xml';
48
+        $path = __DIR__.'/../../../cache2/geokrety/import-'.date('Ymd-His').'.xml';
49 49
 
50 50
         // Changed default-value for getSysConfig() from '2005-01-01 00:00:00' to 'NOW - 9d 12h'
51 51
         // to safely stay in api-limit, even when client and server are in different time zones.
52 52
         $modifiedsince = strtotime(
53 53
             getSysConfig('geokrety_lastupdate', date($opt['db']['dateformat'], time() - 60 * 60 * 24 * 9.5))
54 54
         );
55
-        if (!@copy('http://geokrety.org/export.php?modifiedsince=' . date('YmdHis', $modifiedsince - 1), $path)) {
55
+        if (!@copy('http://geokrety.org/export.php?modifiedsince='.date('YmdHis', $modifiedsince - 1), $path)) {
56 56
             return false;
57 57
         }
58 58
 
@@ -81,19 +81,19 @@  discard block
 block discarded – undo
81 81
 
82 82
         $xr->read();
83 83
         if ($xr->nodeType != XMLReader::ELEMENT) {
84
-            echo 'error: First element expected, aborted' . "\n";
84
+            echo 'error: First element expected, aborted'."\n";
85 85
 
86 86
             return;
87 87
         }
88 88
         if ($xr->name != 'gkxml') {
89
-            echo 'error: First element not valid, aborted' . "\n";
89
+            echo 'error: First element not valid, aborted'."\n";
90 90
 
91 91
             return;
92 92
         }
93 93
 
94 94
         $startupdate = $xr->getAttribute('date');
95 95
         if ($startupdate == '') {
96
-            echo 'error: Date attribute not valid, aborted' . "\n";
96
+            echo 'error: Date attribute not valid, aborted'."\n";
97 97
 
98 98
             return;
99 99
         }
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
                         break;
116 116
                 }
117 117
 
118
-                $nRecordsCount ++;
118
+                $nRecordsCount++;
119 119
             }
120 120
         } while ($xr->next());
121 121
 
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
         $waypoints = $element->getElementsByTagName('waypoints');
254 254
         if ($waypoints->length > 0) {
255 255
             $wpItems = $waypoints->item(0)->getElementsByTagName('waypoint');
256
-            for ($i = 0; $i < $wpItems->length; $i ++) {
256
+            for ($i = 0; $i < $wpItems->length; $i++) {
257 257
                 $wp = mb_trim($wpItems->item($i)->nodeValue);
258 258
                 if ($wp != '') {
259 259
                     sql("INSERT INTO `gk_move_waypoint` (`id`, `wp`) VALUES ('&1', '&2')", $id, $wp);
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
                 WHERE `id`='&2' AND `wp`!=''",
286 286
                 $gkid,
287 287
                 $r['id']
288
-            );  // "late log" bugfix: replaced $id paramter by $r['id']
288
+            ); // "late log" bugfix: replaced $id paramter by $r['id']
289 289
         } else {
290 290
             // do nothing
291 291
         }
Please login to merge, or discard this patch.