function.coordinput.php ➔ smarty_function_coordinput()

Complexity

Conditions	9
Paths	64

Size

Total Lines	102
Code Lines	84

Duplication

Lines	6
Ratio	5.88 %

Importance

Changes

0

<?php
function smarty_function_coordinput($params, &$smarty)

The parameter $smarty is not used and could be removed.

{
    $prefix = $params['prefix'];
    $lat = $params['lat'] + 0;
    $lon = $params['lon'] + 0;

    if ($lat < 0) {
        $bLatNeg = true;
        $lat = -$lat;
    } else {
        $bLatNeg = false;
    }
    $latMin = $lat - floor($lat);
    $lat -= $latMin;

    if ($lon < 0) {
        $bLonNeg = true;
        $lon = -$lon;
    } else {
        $bLonNeg = false;
    }
    $lonMin = $lon - floor($lon);
    $lon -= $lonMin;

    $returnValue = '<select name="' . htmlspecialchars($prefix, ENT_QUOTES, 'UTF-8') . 'NS">';
    if ($bLatNeg) {
        $returnValue .= '<option value="N">N</option>';
        $returnValue .= '<option value="S" selected="selected">S</option>';
    } else {
        $returnValue .= '<option value="N" selected="selected">N</option>';
        $returnValue .= '<option value="S">S</option>';
    }
    $returnValue .= '</select>&nbsp;';

    $returnValue .= '<input type="text" name="' .
        htmlspecialchars(
            $prefix,
            ENT_QUOTES,
            'UTF-8'
        ) . 'Lat" value="' .
        htmlspecialchars(
            sprintf('%02d', $lat),
            ENT_QUOTES,
            'UTF-8'
        ) . '" size="1" maxlength="2" />&deg; ';
    $returnValue .= '<input type="text" name="' .
        htmlspecialchars(
            $prefix,
            ENT_QUOTES,
            'UTF-8'
        ) . 'LatMin" value="' .
        htmlspecialchars(
            sprintf('%06.3f', $latMin * 60),
            ENT_QUOTES,
            'UTF-8'
        ) . '" size="5" maxlength="6" /> \'';

    if (isset($params['laterror']) && $params['laterror'] == true) {

It seems like you are loosely comparing $params['laterror'] of type integer to the boolean true. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

        $returnValue .= ' &nbsp; <span class="errormsg">' . gettext('Invalid coordinate') . '</span>';
    }

    $returnValue .= '<br />';

    $returnValue .= '<select name="' . htmlspecialchars($prefix, ENT_QUOTES, 'UTF-8') . 'EW">';
    if ($bLonNeg) {
        $returnValue .= '<option value="E">E</option>';
        $returnValue .= '<option value="W" selected="selected">W</option>';
    } else {
        $returnValue .= '<option value="E" selected="selected">E</option>';
        $returnValue .= '<option value="W">W</option>';
    }
    $returnValue .= '</select>&nbsp;';

    $returnValue .= '<input type="text" name="' .
        htmlspecialchars(
            $prefix,
            ENT_QUOTES,
            'UTF-8'
        ) . 'Lon" value="' .
        htmlspecialchars(
            sprintf('%03d', $lon),
            ENT_QUOTES,
            'UTF-8'
        ) . '" size="2" maxlength="3" />&deg; ';
    $returnValue .= '<input type="text" name="' .
        htmlspecialchars(
            $prefix,
            ENT_QUOTES,
            'UTF-8'
        ) . 'LonMin" value="' .
        htmlspecialchars(
            sprintf('%06.3f', $lonMin * 60),
            ENT_QUOTES,
            'UTF-8'
        ) . '" size="5" maxlength="6" /> \'';

    if (isset($params['lonerror']) && $params['lonerror'] == true) {

It seems like you are loosely comparing $params['lonerror'] of type integer to the boolean true. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

        $returnValue .= ' &nbsp; <span class="errormsg">' . gettext('Invalid coordinate') . '</span>';
    }

    return $returnValue;
}