Completed
Push — development ( 1fb9de...ffe605 )
by Thomas
57s queued 13s
created
htdocs/src/OcLegacy/Admin/Gdpr/GdprHandler.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
                 WHERE cache_id = :cacheId;
226 226
 SQL
227 227
             , [
228
-                'cacheId' => (int) $cache['cache_id'],
228
+                'cacheId' => (int)$cache['cache_id'],
229 229
             ]);
230 230
 
231 231
             $this->connection->executeQuery(<<<'SQL'
@@ -237,19 +237,19 @@  discard block
 block discarded – undo
237 237
                 WHERE cache_id = :cacheId
238 238
 SQL
239 239
             , [
240
-                'cacheId' => (int) $cache['cache_id'],
240
+                'cacheId' => (int)$cache['cache_id'],
241 241
             ]);
242 242
 
243 243
             $this->connection->executeQuery('DELETE FROM cache_desc_modified WHERE cache_id = :cacheId', [
244
-                'cacheId' => (int) $cache['cache_id'],
244
+                'cacheId' => (int)$cache['cache_id'],
245 245
             ]);
246 246
 
247 247
             $this->connection->executeQuery('DELETE FROM cache_ignore WHERE cache_id = :cacheId', [
248
-                'cacheId' => (int) $cache['cache_id'],
248
+                'cacheId' => (int)$cache['cache_id'],
249 249
             ]);
250 250
 
251 251
             $this->connection->executeQuery('DELETE FROM caches_modified WHERE cache_id = :cacheId', [
252
-                'cacheId' => (int) $cache['cache_id'],
252
+                'cacheId' => (int)$cache['cache_id'],
253 253
             ]);
254 254
         }
255 255
     }
@@ -260,8 +260,8 @@  discard block
 block discarded – undo
260 260
             return [];
261 261
         }
262 262
 
263
-        $ids = array_map(static function (array $cache) use ($idField) {
264
-            return (int) $cache[$idField];
263
+        $ids = array_map(static function(array $cache) use ($idField) {
264
+            return (int)$cache[$idField];
265 265
         }, $data);
266 266
 
267 267
         $pictures = $this->connection->fetchAll('SELECT * FROM pictures WHERE object_id IN (' . implode(',', $ids) . ') AND object_type = :objectType', [
@@ -281,8 +281,8 @@  discard block
 block discarded – undo
281 281
             return [];
282 282
         }
283 283
 
284
-        $ids = array_map(static function (array $cache) use ($idField) {
285
-            return (int) $cache[$idField];
284
+        $ids = array_map(static function(array $cache) use ($idField) {
285
+            return (int)$cache[$idField];
286 286
         }, $data);
287 287
 
288 288
         return $this->connection->fetchAll('SELECT * FROM pictures_modified WHERE object_id IN (' . implode(',', $ids) . ') AND object_type = :objectType', [
Please login to merge, or discard this patch.
htdocs/okapi/meta.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@
 block discarded – undo
1 1
 <?php return array (
2
-  'version_number' => 1926,
3
-  'git_revision' => 'dbed1d0d908dcc00a4aa7387de2e08b727dccee8',
2
+    'version_number' => 1926,
3
+    'git_revision' => 'dbed1d0d908dcc00a4aa7387de2e08b727dccee8',
4 4
 );
5 5
\ No newline at end of file
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@
 block discarded – undo
1
-<?php return array (
1
+<?php return array(
2 2
   'version_number' => 1926,
3 3
   'git_revision' => 'dbed1d0d908dcc00a4aa7387de2e08b727dccee8',
4 4
 );
5 5
\ No newline at end of file
Please login to merge, or discard this patch.
local/devel/generator.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -359,13 +359,13 @@  discard block
 block discarded – undo
359 359
 
360 360
     file_put_contents(
361 361
         __DIR__ . '/Entities/' . $classNameEntity . '.php',
362
-        "<?php \n\n" . (string) $classEntity,
362
+        "<?php \n\n" . (string)$classEntity,
363 363
         LOCK_EX
364 364
     );
365 365
 
366 366
     file_put_contents(
367 367
         __DIR__ . '/Entities/' . $classNameEntity . 'Test.php',
368
-        "<?php \n\n use OcTest\Modules\AbstractModuleTest; \n\n" . (string) $classEntityTest,
368
+        "<?php \n\n use OcTest\Modules\AbstractModuleTest; \n\n" . (string)$classEntityTest,
369 369
         LOCK_EX
370 370
     );
371 371
 
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
 use Oc\Repository\Exception\RecordNotFoundException;
379 379
 use Oc\Repository\Exception\RecordNotPersistedException;
380 380
 use Oc\Repository\Exception\RecordsNotFoundException; \n\n" .
381
-        (string) $classRepository,
381
+        (string)$classRepository,
382 382
         LOCK_EX
383 383
     );
384 384
 }
Please login to merge, or discard this patch.
htdocs/config2/settings-dist.inc.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 // database placeholder
108 108
 
109 109
 // productive database with opencaching-tables
110
-$opt['db']['placeholder']['db'] = '';    // selected by default
110
+$opt['db']['placeholder']['db'] = ''; // selected by default
111 111
 
112 112
 // empty database for temporary table creation
113 113
 $opt['db']['placeholder']['tmpdb'] = '';
@@ -121,14 +121,14 @@  discard block
 block discarded – undo
121 121
 $opt['system']['maillog']['syslog_db_user'] = '';
122 122
 $opt['system']['maillog']['syslog_db_password'] = '';
123 123
 $opt['system']['maillog']['syslog_db_table'] = '';
124
-$opt['system']['maillog']['syslog_oc_host'] = '';  // 'host_name' column in syslog DB
125
-$opt['system']['maillog']['syslog_mta'] = 'postfix/smtp%';  // 'program' column in syslog DB
126
-$opt['system']['maillog']['column']['id'] = 'id';               // 'ID'
127
-$opt['system']['maillog']['column']['created'] = 'created';     // 'ReceivedAt'
124
+$opt['system']['maillog']['syslog_oc_host'] = ''; // 'host_name' column in syslog DB
125
+$opt['system']['maillog']['syslog_mta'] = 'postfix/smtp%'; // 'program' column in syslog DB
126
+$opt['system']['maillog']['column']['id'] = 'id'; // 'ID'
127
+$opt['system']['maillog']['column']['created'] = 'created'; // 'ReceivedAt'
128 128
 $opt['system']['maillog']['column']['host_name'] = 'host_name'; // 'FromHost'
129
-$opt['system']['maillog']['column']['message'] = 'message';     // 'Message'
130
-$opt['system']['maillog']['column']['program'] = 'program';     // 'SysLogTag'
131
-$opt['system']['maillog']['inactivity_warning'] = 30;   // warn after N days without new entries
129
+$opt['system']['maillog']['column']['message'] = 'message'; // 'Message'
130
+$opt['system']['maillog']['column']['program'] = 'program'; // 'SysLogTag'
131
+$opt['system']['maillog']['inactivity_warning'] = 30; // warn after N days without new entries
132 132
 
133 133
 /* cookie or session
134 134
  *
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
  */
153 153
 $opt['session']['cookiename'] = 'ocdevelopment'; // only with SAVE_COOKIE
154 154
 $opt['session']['path'] = '/';
155
-$opt['session']['domain'] = '';    // may be overwritten by $opt['domain'][...]['cookiedomain']
155
+$opt['session']['domain'] = ''; // may be overwritten by $opt['domain'][...]['cookiedomain']
156 156
 
157 157
 /* Debug level (combine with OR | )
158 158
  *  DEBUG_NO              = productive use
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 /* other template options
171 171
  *
172 172
  */
173
-$opt['page']['origin_url'] = 'https://www.opencaching.de/';  // production installation for this OC site
173
+$opt['page']['origin_url'] = 'https://www.opencaching.de/'; // production installation for this OC site
174 174
 $opt['page']['develsystem'] = false;
175 175
 $opt['page']['teampic_url'] = 'https://www.opencaching.de/images/team/';
176 176
 $opt['page']['teammember_url'] = 'https://www.opencaching.de/';
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
     'newcaches' => [
205 205
         'show' => true,
206 206
         'url' => 'https://www.opencaching.de',
207
-        'urlname' => '',  // optional: show other name than the url-domain
207
+        'urlname' => '', // optional: show other name than the url-domain
208 208
     ],
209 209
 ];
210 210
 
@@ -364,7 +364,7 @@  discard block
 block discarded – undo
364 364
 
365 365
 /* license-related functions
366 366
  */
367
-$opt['logic']['license']['newusers'] = 2;  // see license constants in lib2/logic/const.inc.php
367
+$opt['logic']['license']['newusers'] = 2; // see license constants in lib2/logic/const.inc.php
368 368
 $opt['logic']['license']['admin'] = true;
369 369
 $opt['logic']['license']['disclaimer'] = false;
370 370
 $opt['logic']['license']['terms'] = 'articles.php?page=impressum#datalicense';
@@ -372,18 +372,18 @@  discard block
 block discarded – undo
372 372
 
373 373
 /* optional APIs
374 374
  */
375
-$opt['logic']['api']['email_problems']['key'] = '';   // must be set to enable
376
-$opt['logic']['api']['user_inactivity']['key'] = '';  // must be set to enable
375
+$opt['logic']['api']['email_problems']['key'] = ''; // must be set to enable
376
+$opt['logic']['api']['user_inactivity']['key'] = ''; // must be set to enable
377 377
 
378 378
 /* cache report info settings
379 379
  */
380 380
 $opt['logic']['cache_reports']['delaydays'] = 2;
381
-$opt['logic']['cache_reports']['min_processperday'] = 5;   // set to 0 to disable
382
-$opt['logic']['cache_reports']['max_processperday'] = 20;  // set to 0 to disable
381
+$opt['logic']['cache_reports']['min_processperday'] = 5; // set to 0 to disable
382
+$opt['logic']['cache_reports']['max_processperday'] = 20; // set to 0 to disable
383 383
 
384 384
 /* cronjob
385 385
  */
386
-$opt['cron']['username'] = 'apache';   // system username for cronjobs
386
+$opt['cron']['username'] = 'apache'; // system username for cronjobs
387 387
 
388 388
 /* generate sitemap.xml and upload to search engines
389 389
  *
Please login to merge, or discard this patch.
htdocs/mylists.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,13 +25,13 @@
 block discarded – undo
25 25
 
26 26
 if (isset($_REQUEST['list_caches'])) {
27 27
     $list_caches = strtoupper(trim($_REQUEST['list_caches']));
28
-} elseif (isset($_REQUEST['addCache']) &&  $_REQUEST['addCache'] >= 1) {
28
+} elseif (isset($_REQUEST['addCache']) && $_REQUEST['addCache'] >= 1) {
29 29
     $list_caches = $_REQUEST['addCache'];
30 30
 } else {
31 31
     $list_caches = '';
32 32
 }
33 33
 
34
-if (isset($_REQUEST['addCache'])){
34
+if (isset($_REQUEST['addCache'])) {
35 35
     foreach ($list_caches as $nCacheId) {
36 36
         $cache = new cache($nCacheId);
37 37
         $oc_codes[] = $cache->getWPOC();
Please login to merge, or discard this patch.
htdocs/search.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 $load_query = false;
89 89
 $show_lastsearchbutton = true;
90 90
 
91
-$list_caches = isset($_REQUEST['addCache']) &&  $_REQUEST['addCache'] >= 1 ? $_REQUEST['addCache'] : '';
91
+$list_caches = isset($_REQUEST['addCache']) && $_REQUEST['addCache'] >= 1 ? $_REQUEST['addCache'] : '';
92 92
 $added_waypoints = 0;
93 93
 
94 94
 if (isset($_REQUEST['queryid']) || isset($_REQUEST['showresult'])) {  // Ocprop: showresult, queryid
@@ -1297,11 +1297,11 @@  discard block
 block discarded – undo
1297 1297
 
1298 1298
         //add selected caches to selected cachelist
1299 1299
         if (isset($_REQUEST['addToList']) && isset($_REQUEST['addCache']) && isset($_REQUEST['selectCachelist'])) {
1300
-            $list_caches_= $_REQUEST['addToList'];
1300
+            $list_caches_ = $_REQUEST['addToList'];
1301 1301
             $added_waypoints = addToList($list_caches);
1302
-            $addCachelist= cachelist::getListById((int) $_REQUEST['selectCachelist']); // null for invalid ID
1302
+            $addCachelist = cachelist::getListById((int)$_REQUEST['selectCachelist']); // null for invalid ID
1303 1303
         } elseif (isset($_REQUEST['addToList'])) {
1304
-            $addCachelist= cachelist::getListById((int) $_REQUEST['selectCachelist']); // null for invalid ID
1304
+            $addCachelist = cachelist::getListById((int)$_REQUEST['selectCachelist']); // null for invalid ID
1305 1305
             $error_addCaches = true;
1306 1306
         }
1307 1307
 
Please login to merge, or discard this patch.
htdocs/lib2/edithelper.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@
 block discarded – undo
96 96
         // REDMINE-1249: Missing log text in mail notification
97 97
         // simpler solution that converts html to text as the previous class html2text emptied the text completely
98 98
         // implementation for line wrap, url's and probably more is missing
99
-        $text = preg_replace( "/\n\s+/", "\n", rtrim(html_entity_decode(strip_tags($text))));
99
+        $text = preg_replace("/\n\s+/", "\n", rtrim(html_entity_decode(strip_tags($text))));
100 100
 
101 101
         $text = str_replace(
102 102
             [
Please login to merge, or discard this patch.
htdocs/log.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -50,8 +50,8 @@  discard block
 block discarded – undo
50 50
     $fieldNoteService = AppKernel::Container()->get(FieldNoteService::class);
51 51
 
52 52
     $fieldNote = $fieldNoteService->fetchOneBy([
53
-        'id' => (int) $_GET['fieldnoteid'],
54
-        'user_id' => (int) $user->getUserId()
53
+        'id' => (int)$_GET['fieldnoteid'],
54
+        'user_id' => (int)$user->getUserId()
55 55
     ]);
56 56
 
57 57
     if ($fieldNote !== null) {
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
     // check if masslog warning is accepted (in cookie)
98 98
     $masslogCookieSet = isset($_COOKIE['ocsuppressmasslogwarn']);
99 99
     if ($masslogCookieSet) {
100
-        $masslogCookieContent = (int) $_COOKIE['ocsuppressmasslogwarn'];
100
+        $masslogCookieContent = (int)$_COOKIE['ocsuppressmasslogwarn'];
101 101
     } else {
102 102
         // save masslog acception in cookie that expires on midnight if clicked
103 103
         if (isset($_REQUEST['suppressMasslogWarning']) && $_REQUEST['suppressMasslogWarning'] == 1) {
@@ -109,17 +109,17 @@  discard block
 block discarded – undo
109 109
     //   logtext, logtype, logday, logmonth, logyear
110 110
 
111 111
     $logText = isset($_POST['logtext']) ? trim($_POST['logtext']) : '';
112
-    $logType = isset($_REQUEST['logtype']) ? (int) $_REQUEST['logtype'] : null;
112
+    $logType = isset($_REQUEST['logtype']) ? (int)$_REQUEST['logtype'] : null;
113 113
     $logDateDay = isset($_POST['logday']) ? trim($_POST['logday']) : ($datesaved ? $defaultLogDay : date('d'));
114 114
     $logDateMonth = isset($_POST['logmonth']) ? trim($_POST['logmonth']) : ($datesaved ? $defaultLogMonth : date('m'));
115 115
     $logDateYear = isset($_POST['logyear']) ? trim($_POST['logyear']) : ($datesaved ? $defaultLogYear : date('Y'));
116 116
     $logTimeHour = isset($_POST['loghour']) ? trim($_POST['loghour']) : '';
117 117
     $logTimeMinute = isset($_POST['logminute']) ? trim($_POST['logminute']) : '';
118
-    $needsMaintenance = isset($_POST['needs_maintenance2']) ? (int) $_POST['needs_maintenance2'] : (isset($_POST['needs_maintenance']) ? (int) $_POST['needs_maintenance'] : 0);
119
-    $listingOutdated = isset($_POST['listing_outdated2']) ? (int) $_POST['listing_outdated2'] : (isset($_POST['listing_outdated']) ? (int) $_POST['listing_outdated'] : 0);
120
-    $confirmListingOk = isset($_POST['confirm_listing_ok']) ? (int) $_POST['confirm_listing_ok'] : 0;
121
-    $rateOption = isset($_POST['ratingoption']) ? (int) $_POST['ratingoption'] : 0;
122
-    $rateCache = isset($_POST['rating']) ? (int) $_POST['rating'] : 0;
118
+    $needsMaintenance = isset($_POST['needs_maintenance2']) ? (int)$_POST['needs_maintenance2'] : (isset($_POST['needs_maintenance']) ? (int)$_POST['needs_maintenance'] : 0);
119
+    $listingOutdated = isset($_POST['listing_outdated2']) ? (int)$_POST['listing_outdated2'] : (isset($_POST['listing_outdated']) ? (int)$_POST['listing_outdated'] : 0);
120
+    $confirmListingOk = isset($_POST['confirm_listing_ok']) ? (int)$_POST['confirm_listing_ok'] : 0;
121
+    $rateOption = isset($_POST['ratingoption']) ? (int)$_POST['ratingoption'] : 0;
122
+    $rateCache = isset($_POST['rating']) ? (int)$_POST['rating'] : 0;
123 123
     $ocTeamComment = isset($_REQUEST['teamcomment']) ? $_REQUEST['teamcomment'] != 0 : 0;
124 124
     $suppressMasslogWarning = isset($_REQUEST['suppressMasslogWarning']) ? $_REQUEST['suppressMasslogWarning'] : ($masslogCookieSet ? $masslogCookieContent : 0);
125 125
 
@@ -165,12 +165,12 @@  discard block
 block discarded – undo
165 165
     }
166 166
 
167 167
     // if not a found log, ignore the rating
168
-    $rateOption = (int) ($logType == 1 || $logType == 7);
168
+    $rateOption = (int)($logType == 1 || $logType == 7);
169 169
 
170 170
     // get log text editor mode (from form or from userprofile)
171 171
     // 1 = text; 2 = HTML; 3 = tinyMCE
172 172
     if (isset($_POST['descMode'])) {
173
-        $descMode = (int) $_POST['descMode'];  // Ocprop: 2
173
+        $descMode = (int)$_POST['descMode']; // Ocprop: 2
174 174
         if (($descMode < EditorConstants::HTML_MODE) || ($descMode > EditorConstants::EDITOR_MODE)) {
175 175
             $descMode = EditorConstants::EDITOR_MODE;
176 176
         }
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
          * set seconds 00:00:01, means "00:00 was logged"
249 249
          * set seconds 00:00:00, means "no time was logged"
250 250
          */
251
-        $logTimeSecond = (int) ($logTimeHour . $logTimeMinute != ''
251
+        $logTimeSecond = (int)($logTimeHour . $logTimeMinute != ''
252 252
                 && $logTimeHour == 0
253 253
                 && $logTimeMinute == 0);
254 254
 
@@ -256,8 +256,8 @@  discard block
 block discarded – undo
256 256
         $logDate = date(
257 257
             $opt['db']['dateformat'],
258 258
             mktime(
259
-                (int) $logTimeHour,
260
-                (int) $logTimeMinute,
259
+                (int)$logTimeHour,
260
+                (int)$logTimeMinute,
261 261
                 $logTimeSecond,
262 262
                 $logDateMonth,
263 263
                 $logDateDay,
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
             if (isset($_REQUEST['fieldnoteid']) && $_REQUEST['fieldnoteid']) {
309 309
                 sql(
310 310
                     'DELETE FROM field_note WHERE `id` = &1 AND `user_id` = &2',
311
-                    (int) $_REQUEST['fieldnoteid'],
311
+                    (int)$_REQUEST['fieldnoteid'],
312 312
                     $user->getUserId()
313 313
                 );
314 314
 
@@ -395,8 +395,8 @@  discard block
 block discarded – undo
395 395
 
396 396
 // prepare template and display
397 397
 $tpl->assign('logtype_allows_nm', implode(',', $logtype_allows_nm));
398
-$tpl->assign('scrollposx', isset($_REQUEST['scrollposx']) ? (int) $_REQUEST['scrollposx']: 0);
399
-$tpl->assign('scrollposy', isset($_REQUEST['scrollposy']) ? (int) $_REQUEST['scrollposy']: 0);
398
+$tpl->assign('scrollposx', isset($_REQUEST['scrollposx']) ? (int)$_REQUEST['scrollposx'] : 0);
399
+$tpl->assign('scrollposy', isset($_REQUEST['scrollposy']) ? (int)$_REQUEST['scrollposy'] : 0);
400 400
 $tpl->assign('validate', $validate);
401 401
 $tpl->assign('editlog', false);
402 402
 
Please login to merge, or discard this patch.
htdocs/editlog.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
 
144 144
 // editor mode switching
145 145
 if (isset($_POST['descMode'])) {
146
-    $descMode = (int) $_POST['descMode']; // Ocprop: 2
146
+    $descMode = (int)$_POST['descMode']; // Ocprop: 2
147 147
     if (($descMode < EditorConstants::HTML_MODE) || ($descMode > EditorConstants::EDITOR_MODE)) {
148 148
         $descMode = EditorConstants::EDITOR_MODE;
149 149
     }
Please login to merge, or discard this patch.