MenuSubscriber::onSetupMenu() - Code Metrics - Inspection of "Occ 80 cache search details button" - OpencachingDeutschland/oc-server3 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — development (#809)

unknown

created 2020-12-10 18:27 UTC

MenuSubscriber::onSetupMenu() B

↳ Parent: MenuSubscriber

Complexity

Conditions	5
Paths	16

Size

Total Lines

Duplication

Lines	28
Ratio	68.29 %

Importance

Changes

Metric	Value
cc	5
nc	16
nop	1
dl	28
loc	41
rs	8.9528
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Oc\Components\Subscriber;

use KevinPapst\AdminLTEBundle\Event\KnpMenuEvent;
use Oc\Entity\UserEntity;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\Security\Core\Security;

class MenuSubscriber implements EventSubscriberInterface
{
    /**
     * @var Security
     */
    private $security;

    public function __construct(Security $security)
    {
        $this->security = $security;
    }

    public static function getSubscribedEvents(): array
    {
        return [
            KnpMenuEvent::class => ['onSetupMenu', 100],
        ];
    }

    public function onSetupMenu(KnpMenuEvent $event)
    {
        $menu = $event->getMenu();

        $menu->addChild('MainNavigationMenuItem', [
            'label' => 'MAIN NAVIGATION',
            'childOptions' => $event->getChildOptions()
        ])->setAttribute('class', 'header');

        if ($this->security->isGranted("CAN_VIEW", UserEntity::class)) {
            $userMenu = $menu->addChild('cache', [
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                'label' => 'Caches',
                'route' => 'backend_caches_index',
                'childOptions' => $event->getChildOptions(),
            ])->setLabelAttribute('icon', 'fas fa-map-marker-alt');
        }

        if ($this->security->isGranted("CAN_VIEW", UserEntity::class)) {
            $userMenu = $menu->addChild('user', [
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                'label' => 'Users',
                'route' => 'backend_user_index',
                'childOptions' => $event->getChildOptions(),
            ])->setLabelAttribute('icon', 'fas fa-users');
        }

        if ($this->security->isGranted("CAN_VIEW", UserEntity::class)) { // ??
            $userMenu = $menu->addChild('settings', [
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                'label' => 'Settings',
                'route' => 'backend_settings_index',
                'childOptions' => $event->getChildOptions(),
            ])->setLabelAttribute('icon', 'fas fa-cogs');
        }

        if ($this->security->isGranted("CAN_VIEW", UserEntity::class)) {
            $userMenu = $menu->addChild('kitchensink', [
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                'label' => 'Kitchensink',
                'route' => 'app_kitchensink_index',
                'childOptions' => $event->getChildOptions(),
            ])->setLabelAttribute('icon', 'fab fa-css3');
        }
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Oc\Components\Subscriber;
6
7		use KevinPapst\AdminLTEBundle\Event\KnpMenuEvent;
8		use Oc\Entity\UserEntity;
9		use Symfony\Component\EventDispatcher\EventSubscriberInterface;
10		use Symfony\Component\Security\Core\Security;
11
12		class MenuSubscriber implements EventSubscriberInterface
13		{
14		/**
15		* @var Security
16		*/
17		private $security;
18
19		public function __construct(Security $security)
20		{
21		$this->security = $security;
22		}
23
24		public static function getSubscribedEvents(): array
25		{
26		return [
27		KnpMenuEvent::class => ['onSetupMenu', 100],
28		];
29		}
30
31		public function onSetupMenu(KnpMenuEvent $event)
32		{
33		$menu = $event->getMenu();
34
35		$menu->addChild('MainNavigationMenuItem', [
36		'label' => 'MAIN NAVIGATION',
37		'childOptions' => $event->getChildOptions()
38		])->setAttribute('class', 'header');
39
40	View Code Duplication	if ($this->security->isGranted("CAN_VIEW", UserEntity::class)) {
41		$userMenu = $menu->addChild('cache', [
		0 ignored issues – show Unused Code introduced 2020-11-10 19:18 UTC by Report Bug Copy Issue Report `$userMenu` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
42		'label' => 'Caches',
43		'route' => 'backend_caches_index',
44		'childOptions' => $event->getChildOptions(),
45		])->setLabelAttribute('icon', 'fas fa-map-marker-alt');
46		}
47
48	View Code Duplication	if ($this->security->isGranted("CAN_VIEW", UserEntity::class)) {
49		$userMenu = $menu->addChild('user', [
		0 ignored issues – show Unused Code introduced 2020-12-09 18:25 UTC by Report Bug Copy Issue Report `$userMenu` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
50		'label' => 'Users',
51		'route' => 'backend_user_index',
52		'childOptions' => $event->getChildOptions(),
53		])->setLabelAttribute('icon', 'fas fa-users');
54		}
55
56	View Code Duplication	if ($this->security->isGranted("CAN_VIEW", UserEntity::class)) { // ??
57		$userMenu = $menu->addChild('settings', [
		0 ignored issues – show Unused Code introduced 2020-11-15 10:31 UTC by Report Bug Copy Issue Report `$userMenu` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
58		'label' => 'Settings',
59		'route' => 'backend_settings_index',
60		'childOptions' => $event->getChildOptions(),
61		])->setLabelAttribute('icon', 'fas fa-cogs');
62		}
63
64	View Code Duplication	if ($this->security->isGranted("CAN_VIEW", UserEntity::class)) {
65		$userMenu = $menu->addChild('kitchensink', [
		0 ignored issues – show Unused Code introduced 2020-11-24 15:02 UTC by Report Bug Copy Issue Report `$userMenu` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
66		'label' => 'Kitchensink',
67		'route' => 'app_kitchensink_index',
68		'childOptions' => $event->getChildOptions(),
69		])->setLabelAttribute('icon', 'fab fa-css3');
70		}
71		}
72		}
73

OpencachingDeutschland / oc-server3

Pull Request — development (#809)

MenuSubscriber::onSetupMenu() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like