Passed
Pull Request — development (#400)
by Thomas
33:16 queued 25:54
created
htdocs/lib2/translationHandler.class.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -236,8 +236,8 @@  discard block
 block discarded – undo
236 236
      * import variables for substition from config2/nodetext/
237 237
      *
238 238
      * @param $variables
239
-     * @param $file
240
-     * @param $language
239
+     * @param string $file
240
+     * @param string $language
241 241
      *
242 242
      * @return bool
243 243
      */
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
 
270 270
     /**
271 271
      * @param $variables
272
-     * @param $lang
272
+     * @param string $lang
273 273
      * @param $str
274 274
      *
275 275
      * @return string
Please login to merge, or discard this patch.
htdocs/src/Oc/Session/SessionDataCookie.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
     }
64 64
 
65 65
     /**
66
-     * @param $name
66
+     * @param string $name
67 67
      * @param null $default
68 68
      *
69 69
      * @return mixed|null
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
     }
75 75
 
76 76
     /**
77
-     * @param $name
77
+     * @param string $name
78 78
      *
79 79
      * @return bool
80 80
      */
Please login to merge, or discard this patch.
htdocs/src/Oc/Session/SessionDataNative.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
                     // TODO fix the following if statement, seems corrupted
51 51
                     if (strtolower(
52 52
                             substr(
53
-                                'http' + strstr($_SERVER['REFERER'], '://'),
53
+                                'http' +strstr($_SERVER['REFERER'], '://'),
54 54
                                 0,
55 55
                                 strlen($opt['page']['absolute_http_url'])
56 56
                             )
Please login to merge, or discard this patch.
htdocs/src/Oc/Cache/WebCache.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -44,8 +44,8 @@  discard block
 block discarded – undo
44 44
     }
45 45
 
46 46
     /**
47
-     * @param $relBaseDir
48
-     * @param $ext
47
+     * @param string $relBaseDir
48
+     * @param string $ext
49 49
      */
50 50
     private function unlinkFiles($relBaseDir, $ext)
51 51
     {
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
     }
145 145
 
146 146
     /**
147
-     * @param $sTemplate
147
+     * @param string $sTemplate
148 148
      */
149 149
     private function preCompileTemplate($sTemplate)
150 150
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
                 \set_php_locale();
81 81
 
82 82
                 if ($this->translate->t('INTERNAL_LANG', 'all', 'OcSmarty.class.php', '') !== $sLanguage) {
83
-                    echo 'setlocale() failed to set language to ' . $sLanguage ."\n";
83
+                    echo 'setlocale() failed to set language to ' . $sLanguage . "\n";
84 84
                     die("Is the translation of INTERNAL_LANG correct?\n");
85 85
                 }
86 86
 
Please login to merge, or discard this patch.
htdocs/config2/settings-sample-vagrant.inc.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
 $opt['session']['mode'] = SAVE_COOKIE;
64 64
 $opt['session']['cookiename'] = 'ocvagrant'; // only with SAVE_COOKIE
65 65
 $opt['session']['path'] = '/';
66
-$opt['session']['domain'] = 'local.team-opencaching.de';    // may be overwritten by $opt['domain'][...]['cookiedomain']
66
+$opt['session']['domain'] = 'local.team-opencaching.de'; // may be overwritten by $opt['domain'][...]['cookiedomain']
67 67
 
68 68
 /* If the Referer was sent by the client and the substring was not found,
69 69
  * the embedded session id will be marked as invalid.
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
  * Take caution on caching issues (!)
222 222
  */
223 223
 
224
-$opt['map']['towns']['enable'] = true;  // for releasing v14
224
+$opt['map']['towns']['enable'] = true; // for releasing v14
225 225
 
226 226
 define('MNU_INFO', 1015);
227 227
 define('MNU_TEAMBLOG', 1016);
Please login to merge, or discard this patch.
htdocs/lib2/util.inc.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
  * @param $filename
285 285
  * @param $maxLength
286 286
  *
287
- * @return bool|string
287
+ * @return false|string
288 288
  */
289 289
 function read_file($filename, $maxLength = 4096)
290 290
 {
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
453 453
  *
454 454
  * @param $n
455 455
  *
456
- * @return mixed|string
456
+ * @return string
457 457
  */
458 458
 function number1000($n)
459 459
 {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -241,7 +241,7 @@
 block discarded – undo
241 241
     while ($nCurPos < mb_strlen($str)) {
242 242
         $nNextSep = mb_strlen($str);
243 243
         $sepLength = mb_strlen($sep);
244
-        for ($nSepPos = 0; $nSepPos < $sepLength; $nSepPos ++) {
244
+        for ($nSepPos = 0; $nSepPos < $sepLength; $nSepPos++) {
245 245
             $nThisPos = mb_strpos($str, mb_substr($sep, $nSepPos, 1), $nCurPos);
246 246
             if ($nThisPos !== false && $nNextSep > $nThisPos) {
247 247
                 $nNextSep = $nThisPos;
Please login to merge, or discard this patch.
htdocs/util2/geodb/make_searchindex.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
 function nonalpha($str)
57 57
 {
58 58
     $strLength = mb_strlen($str);
59
-    for ($i = 0; $i < $strLength; $i ++) {
59
+    for ($i = 0; $i < $strLength; $i++) {
60 60
         if (!((ord(mb_substr($str, $i, 1)) >= ord('a')) && (ord(mb_substr($str, $i, 1)) <= ord('z')))) {
61 61
             return true;
62 62
         }
Please login to merge, or discard this patch.
htdocs/util2/gns/mksearchindex.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -10,8 +10,8 @@  discard block
 block discarded – undo
10 10
  ***************************************************************************/
11 11
 
12 12
 $opt['rootpath'] = '../../';
13
-require_once __DIR__.'/../../lib2/cli.inc.php';
14
-require_once __DIR__.'/../../lib2/search/search.inc.php';
13
+require_once __DIR__ . '/../../lib2/cli.inc.php';
14
+require_once __DIR__ . '/../../lib2/search/search.inc.php';
15 15
 
16 16
 
17 17
 $doubleindex['sankt'] = 'st';
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
     foreach ($simpleTextsArray as $text) {
28 28
         if ($text !== '') {
29 29
             if (nonAlpha($text)) {
30
-                die($r['uni'] . ' ' . $text . "\n");// obsolete for the same reason as above
30
+                die($r['uni'] . ' ' . $text . "\n"); // obsolete for the same reason as above
31 31
             }
32 32
 
33 33
             $simpleText = search_text2simple($text);
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 function nonAlpha($str)
61 61
 {
62 62
     $strLength = mb_strlen($str);
63
-    for ($i = 0; $i < $strLength; $i ++) {
63
+    for ($i = 0; $i < $strLength; $i++) {
64 64
         if (!((ord(mb_substr($str, $i, 1)) >= ord('a')) && (ord(mb_substr($str, $i, 1)) <= ord('z')))) {
65 65
             return true;
66 66
         }
Please login to merge, or discard this patch.
htdocs/util2/gns/mkadmtxt.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -10,8 +10,8 @@
 block discarded – undo
10 10
  ***************************************************************************/
11 11
 
12 12
 $opt['rootpath'] = '../../';
13
-require_once __DIR__.'/../../lib2/cli.inc.php';
14
-require_once __DIR__.'/../../lib2/search/search.inc.php';
13
+require_once __DIR__ . '/../../lib2/cli.inc.php';
14
+require_once __DIR__ . '/../../lib2/search/search.inc.php';
15 15
 
16 16
 
17 17
 $rsLocations = sql("SELECT `uni`, `lat`, `lon`, `rc`, `cc1`, `adm1` FROM `gns_locations` WHERE `dsg` LIKE 'PPL%'");
Please login to merge, or discard this patch.