Completed
Pull Request — development (#482)
by Mirco
06:34
created
htdocs/lib2/ss_zip.class.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -143,9 +143,9 @@  discard block
 block discarded – undo
143 143
         }
144 144
 
145 145
         $fnl = strlen($filename);
146
-        $fh = "\x14\x00";    // ver needed to extract
147
-        $fh .= "\x00\x00";    // gen purpose bit flag
148
-        $fh .= "\x08\x00";    // compression method
146
+        $fh = "\x14\x00"; // ver needed to extract
147
+        $fh .= "\x00\x00"; // gen purpose bit flag
148
+        $fh .= "\x08\x00"; // compression method
149 149
         $fh .= "\x00\x00\x00\x00"; // last mod time and date
150 150
         $fh .=
151 151
             pack(
@@ -172,16 +172,16 @@  discard block
 block discarded – undo
172 172
                 "va*v3V2",
173 173
                 0,
174 174
                 $fh,
175
-                0,        // file comment length
176
-                0,        // disk number start
177
-                0,        // internal file attributes
178
-                $attr,    // external file attributes - 'archive/directory' bit set
175
+                0, // file comment length
176
+                0, // disk number start
177
+                0, // internal file attributes
178
+                $attr, // external file attributes - 'archive/directory' bit set
179 179
                 $this->offset
180 180
             ) . $filename;
181 181
 
182 182
         $this->offset += 42 + $fnl + $gzsize;
183 183
         $this->cdir[] = $cdir;
184
-        $this->cnt ++;
184
+        $this->cnt++;
185 185
         $this->idx = $this->cnt - 1;
186 186
     }
187 187
 
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
                 $cdsl, // size of central dir
231 231
                 $zdsl, // offset to start of central dir
232 232
                 0
233
-            );              // .zip file comment length
233
+            ); // .zip file comment length
234 234
         return $this->zipfile;
235 235
     }
236 236
 
Please login to merge, or discard this patch.
htdocs/lib2/OcSmarty.class.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
     public $main_template = 'sys_main';
20 20
     public $bench = null;
21 21
     public $compile_id = null;
22
-    public $cache_id = null;    // This is a smarty caching ID, not a caches.cache_id.
22
+    public $cache_id = null; // This is a smarty caching ID, not a caches.cache_id.
23 23
     public $title = '';
24 24
     public $menuitem = null;
25 25
     public $nowpsearch = false;
Please login to merge, or discard this patch.
htdocs/lib2/errorhandler.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@
 block discarded – undo
134 134
     $errorlog_dir = __DIR__ . '/../var/errorlog';
135 135
     $errorlog_path = $errorlog_dir . '/errorlog-' . date('Y-m-d');
136 136
 
137
-    $error_mail_limit = 32768;    // send max 32 KB = ca. 5-20 errors per day/logfile
137
+    $error_mail_limit = 32768; // send max 32 KB = ca. 5-20 errors per day/logfile
138 138
 
139 139
     // All errors which may happen here are ignored, to avoid error recursions.
140 140
 
Please login to merge, or discard this patch.
htdocs/config2/settings-dist.inc.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -7,8 +7,8 @@  discard block
 block discarded – undo
7 7
  *  Do not modify this file - use settings.inc.php!
8 8
  ***************************************************************************/
9 9
 
10
-require_once __DIR__. '/locale.inc.php';
11
-require_once __DIR__. '/settings-dist-common.inc.php';
10
+require_once __DIR__ . '/locale.inc.php';
11
+require_once __DIR__ . '/settings-dist-common.inc.php';
12 12
 
13 13
 /* PHP settings
14 14
  *
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 // database placeholder
108 108
 
109 109
 // productive database with opencaching-tables
110
-$opt['db']['placeholder']['db'] = '';    // selected by default
110
+$opt['db']['placeholder']['db'] = ''; // selected by default
111 111
 
112 112
 // empty database for temporary table creation
113 113
 $opt['db']['placeholder']['tmpdb'] = '';
@@ -121,14 +121,14 @@  discard block
 block discarded – undo
121 121
 $opt['system']['maillog']['syslog_db_user'] = '';
122 122
 $opt['system']['maillog']['syslog_db_password'] = '';
123 123
 $opt['system']['maillog']['syslog_db_table'] = '';
124
-$opt['system']['maillog']['syslog_oc_host'] = '';  // 'host_name' column in syslog DB
125
-$opt['system']['maillog']['syslog_mta'] = 'postfix/smtp%';  // 'program' column in syslog DB
126
-$opt['system']['maillog']['column']['id'] = 'id';               // 'ID'
127
-$opt['system']['maillog']['column']['created'] = 'created';     // 'ReceivedAt'
124
+$opt['system']['maillog']['syslog_oc_host'] = ''; // 'host_name' column in syslog DB
125
+$opt['system']['maillog']['syslog_mta'] = 'postfix/smtp%'; // 'program' column in syslog DB
126
+$opt['system']['maillog']['column']['id'] = 'id'; // 'ID'
127
+$opt['system']['maillog']['column']['created'] = 'created'; // 'ReceivedAt'
128 128
 $opt['system']['maillog']['column']['host_name'] = 'host_name'; // 'FromHost'
129
-$opt['system']['maillog']['column']['message'] = 'message';     // 'Message'
130
-$opt['system']['maillog']['column']['program'] = 'program';     // 'SysLogTag'
131
-$opt['system']['maillog']['inactivity_warning'] = 30;   // warn after N days without new entries
129
+$opt['system']['maillog']['column']['message'] = 'message'; // 'Message'
130
+$opt['system']['maillog']['column']['program'] = 'program'; // 'SysLogTag'
131
+$opt['system']['maillog']['inactivity_warning'] = 30; // warn after N days without new entries
132 132
 
133 133
 /* cookie or session
134 134
  *
@@ -150,15 +150,15 @@  discard block
 block discarded – undo
150 150
  *
151 151
  * other parameters may be customized
152 152
  */
153
-$opt['session']['mode'] = SAVE_COOKIE;     // don't change - other option "SAVE_SESSION" is not implemented properly
153
+$opt['session']['mode'] = SAVE_COOKIE; // don't change - other option "SAVE_SESSION" is not implemented properly
154 154
 $opt['session']['cookiename'] = 'ocvagrant'; // only with SAVE_COOKIE
155 155
 $opt['session']['path'] = '/';
156
-$opt['session']['domain'] = '';    // may be overwritten by $opt['domain'][...]['cookiedomain']
156
+$opt['session']['domain'] = ''; // may be overwritten by $opt['domain'][...]['cookiedomain']
157 157
 
158 158
 /* maximum session lifetime
159 159
  */
160 160
 $opt['session']['expire']['cookie'] = 31536000; // when cookies used (default 1 year)
161
-$opt['session']['expire']['url'] = 1800;        // when no cookies used (default 30 min since last call), attention to session.js
161
+$opt['session']['expire']['url'] = 1800; // when no cookies used (default 30 min since last call), attention to session.js
162 162
 
163 163
 /* If the Referer was sent by the client and the substring was not found,
164 164
  * the embedded session id will be marked as invalid.
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
 /* other template options
185 185
  *
186 186
  */
187
-$opt['page']['origin_url'] = 'http://www.opencaching.de/';  // production installation for this OC site
187
+$opt['page']['origin_url'] = 'http://www.opencaching.de/'; // production installation for this OC site
188 188
 $opt['page']['develsystem'] = false;
189 189
 $opt['page']['teampic_url'] = 'http://www.opencaching.de/images/team/';
190 190
 $opt['page']['teammember_url'] = 'http://www.opencaching.de/';
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
     'newcaches' => [
219 219
         'show' => true,
220 220
         'url' => 'http://www.opencaching.de',
221
-        'urlname' => '',  // optional: show other name than the url-domain
221
+        'urlname' => '', // optional: show other name than the url-domain
222 222
     ],
223 223
 ];
224 224
 
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
377 377
 
378 378
 /* license-related functions
379 379
  */
380
-$opt['logic']['license']['newusers'] = 2;  // see license constants in lib2/logic/const.inc.php
380
+$opt['logic']['license']['newusers'] = 2; // see license constants in lib2/logic/const.inc.php
381 381
 $opt['logic']['license']['admin'] = true;
382 382
 $opt['logic']['license']['disclaimer'] = false;
383 383
 $opt['logic']['license']['terms'] = 'articles.php?page=impressum#datalicense';
@@ -385,18 +385,18 @@  discard block
 block discarded – undo
385 385
 
386 386
 /* optional APIs
387 387
  */
388
-$opt['logic']['api']['email_problems']['key'] = '';   // must be set to enable
389
-$opt['logic']['api']['user_inactivity']['key'] = '';  // must be set to enable
388
+$opt['logic']['api']['email_problems']['key'] = ''; // must be set to enable
389
+$opt['logic']['api']['user_inactivity']['key'] = ''; // must be set to enable
390 390
 
391 391
 /* cache report info settings
392 392
  */
393 393
 $opt['logic']['cache_reports']['delaydays'] = 2;
394
-$opt['logic']['cache_reports']['min_processperday'] = 5;   // set to 0 to disable
395
-$opt['logic']['cache_reports']['max_processperday'] = 20;  // set to 0 to disable
394
+$opt['logic']['cache_reports']['min_processperday'] = 5; // set to 0 to disable
395
+$opt['logic']['cache_reports']['max_processperday'] = 20; // set to 0 to disable
396 396
 
397 397
 /* cronjob
398 398
  */
399
-$opt['cron']['username'] = 'apache';   // system username for cronjobs
399
+$opt['cron']['username'] = 'apache'; // system username for cronjobs
400 400
 
401 401
 /* phpbb news integration (index.php, outdated)
402 402
  *
Please login to merge, or discard this patch.
htdocs/util/watchlist/runwatch.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -608,7 +608,7 @@
 block discarded – undo
608 608
         $pid_daemon = fgets($pidfile, 20);
609 609
         fclose($pidfile);
610 610
 
611
-        $pid_daemon = (int) $pid_daemon;
611
+        $pid_daemon = (int)$pid_daemon;
612 612
 
613 613
         // process running?
614 614
         if (posix_kill($pid_daemon, 0)) {
Please login to merge, or discard this patch.
htdocs/lib2/search/search.html.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@
 block discarded – undo
86 86
         // decide if the cache is new
87 87
         $dDiff = dateDiff('d', $rCache['date_created'], date('Y-m-d'));
88 88
 
89
-        $rCache['isnew'] = ($dDiff <= NEWCACHES_DAYS && (int) $rCache['type'] !== 6);
89
+        $rCache['isnew'] = ($dDiff <= NEWCACHES_DAYS && (int)$rCache['type'] !== 6);
90 90
 
91 91
         // get last logs
92 92
         if ($options['sort'] != 'bymylastlog' || !$login->logged_in()) {
Please login to merge, or discard this patch.
htdocs/lib2/login.class.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -15,13 +15,13 @@
 block discarded – undo
15 15
 
16 16
 use OcLegacy\Util\PasswordCrypt;
17 17
 
18
-define('LOGIN_UNKNOWN_ERROR', -1);     // unkown error occured
19
-define('LOGIN_OK', 0);                 // login succeeded
20
-define('LOGIN_BADUSERPW', 1);          // bad username or password
21
-define('LOGIN_TOOMUCHLOGINS', 2);      // too many logins in short time
22
-define('LOGIN_USERNOTACTIVE', 3);      // the useraccount locked
18
+define('LOGIN_UNKNOWN_ERROR', -1); // unkown error occured
19
+define('LOGIN_OK', 0); // login succeeded
20
+define('LOGIN_BADUSERPW', 1); // bad username or password
21
+define('LOGIN_TOOMUCHLOGINS', 2); // too many logins in short time
22
+define('LOGIN_USERNOTACTIVE', 3); // the useraccount locked
23 23
 define('LOGIN_EMPTY_USERPASSWORD', 4); // given username/password was empty
24
-define('LOGIN_LOGOUT_OK', 5);          // logout was successfull
24
+define('LOGIN_LOGOUT_OK', 5); // logout was successfull
25 25
 
26 26
 // login times in seconds
27 27
 define('LOGIN_TIME', 60 * 60);
Please login to merge, or discard this patch.
htdocs/viewprofile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -371,7 +371,7 @@
 block discarded – undo
371 371
 $tpl->assign('hidden', $record['hidden'] <= 0 ? '0' : $record['hidden']);
372 372
 $tpl->assign('active', $active);
373 373
 $tpl->assign('recommended', sql_value("SELECT COUNT(*) FROM `cache_rating` WHERE `user_id`='&1'", 0, $userid));
374
-$tpl->assign('maxrecommended', (int) floor($record['found'] * $opt['logic']['rating']['percentageOfFounds'] / 100));
374
+$tpl->assign('maxrecommended', (int)floor($record['found'] * $opt['logic']['rating']['percentageOfFounds'] / 100));
375 375
 $tpl->assign('show_statistics', $show_statistics);
376 376
 $tpl->assign('show_oconly81', $show_oconly81);
377 377
 
Please login to merge, or discard this patch.
htdocs/editlog.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -163,7 +163,7 @@
 block discarded – undo
163 163
                     $rating_msg = mb_ereg_replace('{max}', floor($user_founds * $rating_percentage / 100), $rating_msg);
164 164
                     $rating_msg = mb_ereg_replace('{curr}', $user_tops, $rating_msg);
165 165
                 } else {
166
-                    $anzahl = (int) (($user_tops + 1 - ($user_founds * $rating_percentage / 100)) / ($rating_percentage / 100));
166
+                    $anzahl = (int)(($user_tops + 1 - ($user_founds * $rating_percentage / 100)) / ($rating_percentage / 100));
167 167
                     if ($anzahl > 1) {
168 168
                         $rating_msg = mb_ereg_replace('{anzahl}', $anzahl, $rating_too_few_founds);
169 169
                     } else {
Please login to merge, or discard this patch.