View GitHub Repository oc-server3

Schedule Inspection
Subscribe
Completed
Push — development ( 1cc14b...5a65d0 )
by Thomas
18:18 queued 34s
created
Status
Category
Toggle Patches
htdocs/lib2/logic/cache.class.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -505,8 +505,8 @@
 
 block discarded – undo
505 505 
         }
506 506
507 507 
         $coords = [];
508 
-        if ($this->getType() != 7 && $this->getType() != 8 &&  // quiz cache
509 
-            $this->hasAttribute(61) != true &&                 // safari cache
508 
+        if ($this->getType() != 7 && $this->getType() != 8 && // quiz cache
509 
+            $this->hasAttribute(61) != true && // safari cache
510 510 
             $this->getStatus() != 5                            // unpublished cache
511 511 
         ) {
512 512 
             $rsCoords = sql(
Please login to merge, or discard this patch.
htdocs/okapi_settings.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -52,7 +52,7 @@
 
 block discarded – undo
52 52 
         'OC_COOKIE_NAME'   => $opt['session']['cookiename'] . 'data',
53 53 
         'VERSION_FILE'     => __DIR__ . '/okapi/meta.php',
54 54 
         'OCDE_HTML_PURIFIER_SETTINGS'
55 
-                           => $opt['html_purifier'],
55 
+                            => $opt['html_purifier'],
56 56 
         'GITHUB_ACCESS_TOKEN' => $opt['okapi']['github_access_token'],
57 57 
     ];
58 58 
 }
Please login to merge, or discard this patch.
htdocs/okapi/index.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,7 +1,7 @@
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-$GLOBALS['rootpath'] = __DIR__.'/../';
3 
+$GLOBALS['rootpath'] = __DIR__ . '/../';
4 4
5 5 
 require_once __DIR__ . '/../vendor/autoload.php';
6 6
7 
-require_once __DIR__ .'/../vendor/opencaching/okapi/okapi/index.php';
7 
+require_once __DIR__ . '/../vendor/opencaching/okapi/okapi/index.php';
Please login to merge, or discard this patch.
htdocs/lib2/OcHTMLPurifier.class.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -63,7 +63,7 @@  discard block
 
 block discarded – undo
63 63 
         $config->set(
64 64 
             'HTML.ForbiddenElements',
65 65 
             [
66 
-                'basefont',   // workaround for HTMLPurifier bug, which allows this in the <body>
66 
+                'basefont', // workaround for HTMLPurifier bug, which allows this in the <body>
67 67 
             ]
68 68 
         );
69 69 
 
@@ -98,7 +98,7 @@  discard block
 
 block discarded – undo
98 98 
         // add attributes
99 99 
         $def->addAttribute('a', 'rel', 'CDATA');
100 100 
         $def->addAttribute('img', 'usemap', 'CDATA');
101 
-        $def->addAttribute('map', 'name', 'CDATA');   // workaround for HTMLPurifer bug
101 
+        $def->addAttribute('map', 'name', 'CDATA'); // workaround for HTMLPurifer bug
102 102
103 103 
         // create parent object with config
104 104 
         parent::__construct($config);
Please login to merge, or discard this patch.
htdocs/src/Oc/Command/CodeSnifferCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -43,7 +43,7 @@
 
 block discarded – undo
43 43 
         }
44 44
45 45 
         $process = new Process($cmd, $this->rootPath, null, null, 9600);
46 
-        $process->run(function ($type, $buffer) {
46 
+        $process->run(function($type, $buffer) {
47 47 
             echo $buffer;
48 48 
         });
49 49
Please login to merge, or discard this patch.
htdocs/usertops.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -13,10 +13,10 @@
 
 block discarded – undo
13 13 
 $tpl->name = 'usertops';
14 14 
 $tpl->menuitem = MNU_CACHES_USERTOPS;
15 15
16 
-$userId = (int) isset($_REQUEST['userid']) ? $_REQUEST['userid']: 0;
16 
+$userId = (int)isset($_REQUEST['userid']) ? $_REQUEST['userid'] : 0;
17 17 
 $ocOnly = isset($_REQUEST['oconly']) && $_REQUEST['oconly'];
18 18
19 
-$sUsername = $connection->fetchColumn('SELECT `username` FROM `user` WHERE `user_id` = :userId',['userId' => $userId]);
19 
+$sUsername = $connection->fetchColumn('SELECT `username` FROM `user` WHERE `user_id` = :userId', ['userId' => $userId]);
20 20 
 if ($sUsername == null) {
21 21 
     $tpl->error(ERROR_USER_NOT_EXISTS);
22 22 
 }
Please login to merge, or discard this patch.
htdocs/ocstats.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -11,7 +11,7 @@  discard block
 
 block discarded – undo
11 11 
 $jpegQuality = 80;
12 12 
 $fontFile = __DIR__ . '/resource2/' . $opt['template']['style'] . '/fonts/dejavu/ttf/DejaVuSans.ttf';
13 13
14 
-$userId = isset($_REQUEST['userid']) ? (int) $_REQUEST['userid'] : 0;
14 
+$userId = isset($_REQUEST['userid']) ? (int)$_REQUEST['userid'] : 0;
15 15 
 $lang = isset($_REQUEST['lang']) ? mb_strtoupper($_REQUEST['lang']) : $opt['template']['locale'];
16 16
17 17 
 if (!isset($opt['locale'][$lang])) {
 
@@ -22,7 +22,7 @@  discard block
 
 block discarded – undo
22 22 
 $connection = AppKernel::Container()->get(Connection::class);
23 23
24 24 
 $fileName = __DIR__ . '/images/statpics/statpic' . $userId . $lang . '.jpg';
25 
-$userStatisticPicture = (int) $connection->createQueryBuilder()
25 
+$userStatisticPicture = (int)$connection->createQueryBuilder()
26 26 
     ->select('COUNT(*)')
27 27 
     ->from('user_statpic')
28 28 
     ->where('user_id = :userId')
 
@@ -48,9 +48,9 @@  discard block
 
 block discarded – undo
48 48
49 49 
     if (is_array($userData)) {
50 50 
         $username = $userData['username'];
51 
-        $found = (int) $userData['found'];
52 
-        $hidden = (int) $userData['hidden'];
53 
-        $logo = (int) $userData['statpic_logo'];
51 
+        $found = (int)$userData['found'];
52 
+        $hidden = (int)$userData['hidden'];
53 
+        $logo = (int)$userData['statpic_logo'];
54 54 
         $logoText = $userData['statpic_text'];
55 55
56 56 
         $textCounterStatistic = $translate->t('Finds: %1  Hidden: %2', '', '', 0, '', 0, $lang);
Please login to merge, or discard this patch.
htdocs/lib/clicompatbase.inc.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -422,7 +422,7 @@  discard block
 
 block discarded – undo
422 422 
 /**
423 423 
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
424 424 
  * @param $value
425 
- * @return false|string
425 
+ * @return string
426 426 
  */
427 427 
 function sql_escape($value)
428 428 
 {
 
@@ -436,7 +436,7 @@  discard block
 
 block discarded – undo
436 436 
 /**
437 437 
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
438 438 
  * @param $value
439 
- * @return false|mixed|string
439 
+ * @return string
440 440 
  */
441 441 
 function sql_escape_backtick($value)
442 442 
 {
 
@@ -547,7 +547,7 @@  discard block
 
 block discarded – undo
547 547
548 548 
 /**
549 549 
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
550 
- * @param $rs
550 
+ * @param resource $rs
551 551 
  * @return array
552 552 
  */
553 553 
 function sql_fetch_row($rs)
Please login to merge, or discard this patch.
htdocs/lib2/db.inc.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -1279,7 +1279,7 @@
 
 block discarded – undo
1279 1279
1280 1280 
 /**
1281 1281 
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
1282 
- * @param $f
1282 
+ * @param resource $f
1283 1283 
  * @param resource $rs
1284 1284 
  * @param $table
1285 1285 
  * @param bool $truncate
Please login to merge, or discard this patch.