AppBundle\Util\ArrayUtil

Complexity

Total Complexity

5

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	trimExplode()	0	13	3
A	humanLangImplode()	0	9	2

<?php

namespace AppBundle\Util;

class ArrayUtil
{
    /**
     * @param string $delimiter
     * @param string $string
     *
     * @return array
     */
    public static function trimExplode($delimiter, $string)
    {
        $result = [];
        $temp = explode($delimiter, $string);
        foreach ($temp as $value) {
            $value = trim($value);
            if ($value !== '') {
                $result[] = $value;
            }
        }

        return $result;
    }

    /**
     * @param array $pieces
     * @param string $conjunction
     * @param string $glue
     *
     * @return mixed|string
     */
    public static function humanLangImplode(array $pieces, $conjunction = 'and', $glue = ',')
    {
        $lastElement = array_pop($pieces);
        if ($pieces) {

The expression $pieces of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return implode($glue . ' ', $pieces) . ' ' . $conjunction . ' ' . $lastElement;
        }

        return $lastElement;
    }
}