OpencachingDeutschland / oc-server3

htdocs/okapi/views/devel/cronreport.php

Spacing +9 added lines, -9 removed lines

@@ -26,13 +26,13 @@ 
         $response->content_type = "text/plain; charset=utf-8";
         ob_start();
 
-        require_once($GLOBALS['rootpath']."okapi/cronjobs.php");
+        require_once($GLOBALS['rootpath'] . "okapi/cronjobs.php");
         $schedule = Cache::get("cron_schedule");
         if ($schedule == null)
             $schedule = array();
         print "Nearest event: ";
         if (Okapi::get_var('cron_nearest_event'))
-            print "in ".(Okapi::get_var('cron_nearest_event') - time())." seconds.\n\n";
+            print "in " . (Okapi::get_var('cron_nearest_event') - time()) . " seconds.\n\n";
         else
             print "NOT SET\n\n";
         $cronjobs = CronJobController::get_enabled_cronjobs();
@@ -43,27 +43,27 @@ 
                 return $by_type;
             return $cmp($a->get_name(), $b->get_name());
         });
-        print str_pad("TYPE", 11)."  ".str_pad("NAME", 40)."  SCHEDULE\n";
-        print str_pad("----", 11)."  ".str_pad("----", 40)."  --------\n";
+        print str_pad("TYPE", 11) . "  " . str_pad("NAME", 40) . "  SCHEDULE\n";
+        print str_pad("----", 11) . "  " . str_pad("----", 40) . "  --------\n";
         foreach ($cronjobs as $cronjob)
         {
             $type = $cronjob->get_type();
             $name = $cronjob->get_name();
-            print str_pad($type, 11)."  ".str_pad($name, 40)."  ";
+            print str_pad($type, 11) . "  " . str_pad($name, 40) . "  ";
             if (!isset($schedule[$name]))
                 print "NOT YET SCHEDULED\n";
             elseif ($schedule[$name] <= time())
-                print "DELAYED: should be run ".(time() - $schedule[$name])." seconds ago\n";
+                print "DELAYED: should be run " . (time() - $schedule[$name]) . " seconds ago\n";
             else
-                print "scheduled to run in ".str_pad($schedule[$name] - time(), 6, " ", STR_PAD_LEFT)." seconds\n";
+                print "scheduled to run in " . str_pad($schedule[$name] - time(), 6, " ", STR_PAD_LEFT) . " seconds\n";
         }
         print "\n";
         print "Crontab last ping: ";
         if (Cache::get('crontab_last_ping'))
-            print (time() - Cache::get('crontab_last_ping'))." seconds ago";
+            print (time() - Cache::get('crontab_last_ping')) . " seconds ago";
         else
             print "NEVER";
-        print " (crontab_check_counter: ".Cache::get('crontab_check_counter').").\n";
+        print " (crontab_check_counter: " . Cache::get('crontab_check_counter') . ").\n";
         print "clog_revisions_daily: ";
         if (Cache::get('clog_revisions_daily'))
         {

Braces +26 added lines, -20 removed lines

@@ -28,19 +28,22 @@ 
 
         require_once($GLOBALS['rootpath']."okapi/cronjobs.php");
         $schedule = Cache::get("cron_schedule");
-        if ($schedule == null)
-            $schedule = array();
+        if ($schedule == null) {
+                    $schedule = array();
+        }
         print "Nearest event: ";
-        if (Okapi::get_var('cron_nearest_event'))
-            print "in ".(Okapi::get_var('cron_nearest_event') - time())." seconds.\n\n";
-        else
-            print "NOT SET\n\n";
+        if (Okapi::get_var('cron_nearest_event')) {
+                    print "in ".(Okapi::get_var('cron_nearest_event') - time())." seconds.\n\n";
+        } else {
+                    print "NOT SET\n\n";
+        }
         $cronjobs = CronJobController::get_enabled_cronjobs();
         usort($cronjobs, function($a, $b) {
             $cmp = function($a, $b) { return ($a < $b) ? -1 : (($a > $b) ? 1 : 0); };
             $by_type = $cmp($a->get_type(), $b->get_type());
-            if ($by_type != 0)
-                return $by_type;
+            if ($by_type != 0) {
+                            return $by_type;
+            }
             return $cmp($a->get_name(), $b->get_name());
         });
         print str_pad("TYPE", 11)."  ".str_pad("NAME", 40)."  SCHEDULE\n";
@@ -50,25 +53,28 @@ 
             $type = $cronjob->get_type();
             $name = $cronjob->get_name();
             print str_pad($type, 11)."  ".str_pad($name, 40)."  ";
-            if (!isset($schedule[$name]))
-                print "NOT YET SCHEDULED\n";
-            elseif ($schedule[$name] <= time())
-                print "DELAYED: should be run ".(time() - $schedule[$name])." seconds ago\n";
-            else
-                print "scheduled to run in ".str_pad($schedule[$name] - time(), 6, " ", STR_PAD_LEFT)." seconds\n";
+            if (!isset($schedule[$name])) {
+                            print "NOT YET SCHEDULED\n";
+            } elseif ($schedule[$name] <= time()) {
+                            print "DELAYED: should be run ".(time() - $schedule[$name])." seconds ago\n";
+            } else {
+                            print "scheduled to run in ".str_pad($schedule[$name] - time(), 6, " ", STR_PAD_LEFT)." seconds\n";
+            }
         }
         print "\n";
         print "Crontab last ping: ";
-        if (Cache::get('crontab_last_ping'))
-            print (time() - Cache::get('crontab_last_ping'))." seconds ago";
-        else
-            print "NEVER";
+        if (Cache::get('crontab_last_ping')) {
+                    print (time() - Cache::get('crontab_last_ping'))." seconds ago";
+        } else {
+                    print "NEVER";
+        }
         print " (crontab_check_counter: ".Cache::get('crontab_check_counter').").\n";
         print "clog_revisions_daily: ";
         if (Cache::get('clog_revisions_daily'))
         {
-            foreach (Cache::get('clog_revisions_daily') as $time => $rev)
-                print "$rev ";
+            foreach (Cache::get('clog_revisions_daily') as $time => $rev) {
+                            print "$rev ";
+            }
             print "\n";
         } else {
             print "NULL\n";

htdocs/okapi/views/devel/tilereport.php

Spacing +21 added lines, -21 removed lines

@@ -21,7 +21,7 @@ 
     {
         # Flush the stats, so the page is fresh upon every request.
 
-        require_once($GLOBALS['rootpath']."okapi/cronjobs.php");
+        require_once($GLOBALS['rootpath'] . "okapi/cronjobs.php");
         CronJobController::force_run("StatsWriterCronJob");
 
         # When services/caches/map/tile method is called, it writes some extra
@@ -33,7 +33,7 @@ 
         ob_start();
 
         $start = isset($_GET['start']) ? $_GET['start'] : date(
-            "Y-m-d 00:00:00", time() - 7*86400);
+            "Y-m-d 00:00:00", time() - 7 * 86400);
         $end = isset($_GET['end']) ? $_GET['end'] : date("Y-m-d 23:59:59");
 
         print "From: $start\n";
@@ -46,8 +46,8 @@ 
                 sum(total_runtime)
             from okapi_stats_hourly
             where
-                period_start >= '".Db::escape_string($start)."'
-                and period_start < '".Db::escape_string($end)."'
+                period_start >= '".Db::escape_string($start) . "'
+                and period_start < '".Db::escape_string($end) . "'
                 and service_name like '%caches/map/tile%'
             group by service_name
         ");
@@ -72,7 +72,7 @@ 
         }
         if ($total_calls != $calls['A'])
         {
-            print "Partial results. Only ".$calls['A']." out of $total_calls are covered.\n";
+            print "Partial results. Only " . $calls['A'] . " out of $total_calls are covered.\n";
             print "All other will count as \"unaccounted for\".\n\n";
             $total_calls = $calls['A'];
         }
@@ -80,37 +80,37 @@ 
         $calls_left = $total_calls;
         $runtime_left = $total_runtime;
 
-        $perc = function($a, $b) { return ($b > 0) ? sprintf("%.1f", 100 * $a / $b)."%" : "(?)"; };
-        $avg = function($a, $b) { return ($b > 0) ? sprintf("%.4f", $a / $b)."s" : "(?)"; };
+        $perc = function($a, $b) { return ($b > 0) ? sprintf("%.1f", 100 * $a / $b) . "%" : "(?)"; };
+        $avg = function($a, $b) { return ($b > 0) ? sprintf("%.4f", $a / $b) . "s" : "(?)"; };
         $get_stats = function() use (&$calls_left, &$runtime_left, &$total_calls, &$total_runtime, &$perc)
         {
             return (
-                str_pad($perc($calls_left, $total_calls), 6, " ", STR_PAD_LEFT).
+                str_pad($perc($calls_left, $total_calls), 6, " ", STR_PAD_LEFT) .
                 str_pad($perc($runtime_left, $total_runtime), 7, " ", STR_PAD_LEFT)
             );
         };
 
         print "%CALLS  %TIME  Description\n";
         print "====== ======  ======================================================================\n";
-        print $get_stats()."  $total_calls responses served. Total runtime: ".sprintf("%.2f", $total_runtime)."s\n";
+        print $get_stats() . "  $total_calls responses served. Total runtime: " . sprintf("%.2f", $total_runtime) . "s\n";
         print "\n";
         print "               All of these requests needed a TileTree build/lookup. The average runtime of\n";
-        print "               these lookups was ".$avg($runtime['A'], $total_calls).". ".$perc($runtime['A'], $total_runtime)." of total runtime was spent here.\n";
+        print "               these lookups was " . $avg($runtime['A'], $total_calls) . ". " . $perc($runtime['A'], $total_runtime) . " of total runtime was spent here.\n";
         print "\n";
 
         $runtime_left -= $runtime['A'];
 
-        print $get_stats()."  All calls passed here after ~".$avg($runtime['A'], $total_calls)."\n";
+        print $get_stats() . "  All calls passed here after ~" . $avg($runtime['A'], $total_calls) . "\n";
 
         print "\n";
         print "               Lookup result was then processed and \"image description\" was created. It was\n";
         print "               passed on to the TileRenderer to compute the ETag hash string. The average runtime\n";
-        print "               of this part was ".$avg($runtime['B'], $total_calls).". ".$perc($runtime['B'], $total_runtime)." of total runtime was spent here.\n";
+        print "               of this part was " . $avg($runtime['B'], $total_calls) . ". " . $perc($runtime['B'], $total_runtime) . " of total runtime was spent here.\n";
         print "\n";
 
         $runtime_left -= $runtime['B'];
 
-        print $get_stats()."  All calls passed here after ~".$avg($runtime['A'] + $runtime['B'], $total_calls)."\n";
+        print $get_stats() . "  All calls passed here after ~" . $avg($runtime['A'] + $runtime['B'], $total_calls) . "\n";
 
         $etag_hits = $calls['B'] - $calls['C'];
 
@@ -120,29 +120,29 @@ 
 
         $calls_left = $calls['C'];
 
-        print $get_stats()."  $calls_left calls passed here after ~".$avg($runtime['A'] + $runtime['B'], $total_calls)."\n";
+        print $get_stats() . "  $calls_left calls passed here after ~" . $avg($runtime['A'] + $runtime['B'], $total_calls) . "\n";
 
         $imagecache_hits = $calls['C'] - $calls['D'];
 
         print "\n";
         print "               $imagecache_hits of these calls hit the server image cache.\n";
-        print "               ".$perc($runtime['C'], $total_runtime)." of total runtime was spent to find these.\n";
+        print "               " . $perc($runtime['C'], $total_runtime) . " of total runtime was spent to find these.\n";
         print "\n";
 
         $calls_left = $calls['D'];
         $runtime_left -= $runtime['C'];
 
-        print $get_stats()."  $calls_left calls passed here after ~".$avg($runtime['A'] + $runtime['B'] + $runtime['C'], $total_calls)."\n";
+        print $get_stats() . "  $calls_left calls passed here after ~" . $avg($runtime['A'] + $runtime['B'] + $runtime['C'], $total_calls) . "\n";
         print "\n";
         print "               These calls required the tile to be rendered. On average, it took\n";
-        print "               ".$avg($runtime['D'], $calls['D'])." to *render* a tile.\n";
-        print "               ".$perc($runtime['D'], $total_runtime)." of total runtime was spent here.\n";
+        print "               " . $avg($runtime['D'], $calls['D']) . " to *render* a tile.\n";
+        print "               " . $perc($runtime['D'], $total_runtime) . " of total runtime was spent here.\n";
         print "\n";
 
         $runtime_left -= $runtime['D'];
 
-        print $perc($runtime_left, $total_runtime)." of runtime was unaccounted for (other processing).\n";
-        print "Average response time was ".$avg($total_runtime, $total_calls).".\n\n";
+        print $perc($runtime_left, $total_runtime) . " of runtime was unaccounted for (other processing).\n";
+        print "Average response time was " . $avg($total_runtime, $total_calls) . ".\n\n";
 
         print "Current okapi_cache score distribution:\n";
         $rs = Db::query("
@@ -153,7 +153,7 @@ 
         ");
         while (list($log2, $count, $size) = Db::fetch_row($rs))
         {
-            print $count." elements ($size bytes) with score between ".pow(2, $log2)." and ".pow(2, $log2 + 1).".\n";
+            print $count . " elements ($size bytes) with score between " . pow(2, $log2) . " and " . pow(2, $log2 + 1) . ".\n";
         }
 
         $response->body = ob_get_clean();

Braces +1 added lines, -2 removed lines

@@ -63,8 +63,7 @@
             {
                 $total_calls = $c;
                 $total_runtime = $r;
-            }
-            elseif (strpos($name, 'extra/caches/map/tile/checkpoint') === 0)
+            } elseif (strpos($name, 'extra/caches/map/tile/checkpoint') === 0)
             {
                 $calls[$name[32]] = $c;
                 $runtime[$name[32]] = $r;

htdocs/okapi/views/devel/attrlist.php

Spacing +6 added lines, -6 removed lines

@@ -34,12 +34,12 @@ 
             print "$id: $name\n";
 
         print "\nAttributes:\n\n";
-        require_once($GLOBALS['rootpath'].'okapi/services/attrs/attr_helper.inc.php');
+        require_once($GLOBALS['rootpath'] . 'okapi/services/attrs/attr_helper.inc.php');
         $internal2acode = AttrHelper::get_internal_id_to_acode_mapping();
         $dict = self::get_all_attribute_names();
         foreach ($dict as $internal_id => $langs)
         {
-            print $internal_id.": ";
+            print $internal_id . ": ";
             $langkeys = array_keys($langs);
             sort($langkeys);
             if (in_array('en', $langkeys))
@@ -47,12 +47,12 @@ 
             else
                 print ">>>> ENGLISH NAME UNSET! <<<<";
             if (isset($internal2acode[$internal_id]))
-                print " - ".$internal2acode[$internal_id];
+                print " - " . $internal2acode[$internal_id];
             else
                 print " - >>>> MISSING A-CODE MAPPING <<<<";
             print "\n";
             foreach ($langkeys as $langkey)
-                print "        $langkey: ".$langs[$langkey]."\n";
+                print "        $langkey: " . $langs[$langkey] . "\n";
         }
 
         print "\nAttribute notices:\n\n";
@@ -64,7 +64,7 @@ 
         {
             if (!isset($internal2acode[$internal_id]))
             {
-                print "(!) Attribute ".$internal_id." is not mapped to any A-code.\n";
+                print "(!) Attribute " . $internal_id . " is not mapped to any A-code.\n";
                 continue;
             }
             $acode = $internal2acode[$internal_id];
@@ -86,7 +86,7 @@ 
                 {
                     print "( ) Attribute $acode has a different name in the '$lang' language\n";
                     print "    Local name: $value\n";
-                    print "    OKAPI name: ".$attr['names'][$lang]."\n";
+                    print "    OKAPI name: " . $attr['names'][$lang] . "\n";
                 }
             }
         }

Braces +22 added lines, -20 removed lines

@@ -26,12 +26,14 @@ 
         ob_start();
 
         print "Cache Types:\n\n";
-        foreach (self::get_all_cachetypes() as $id => $name)
-            print "$id: $name\n";
+        foreach (self::get_all_cachetypes() as $id => $name) {
+                    print "$id: $name\n";
+        }
 
         print "\nLog Types:\n\n";
-        foreach (self::get_all_logtypes() as $id => $name)
-            print "$id: $name\n";
+        foreach (self::get_all_logtypes() as $id => $name) {
+                    print "$id: $name\n";
+        }
 
         print "\nAttributes:\n\n";
         require_once($GLOBALS['rootpath'].'okapi/services/attrs/attr_helper.inc.php');
@@ -42,17 +44,20 @@ 
             print $internal_id.": ";
             $langkeys = array_keys($langs);
             sort($langkeys);
-            if (in_array('en', $langkeys))
-                print strtoupper($langs['en']);
-            else
-                print ">>>> ENGLISH NAME UNSET! <<<<";
-            if (isset($internal2acode[$internal_id]))
-                print " - ".$internal2acode[$internal_id];
-            else
-                print " - >>>> MISSING A-CODE MAPPING <<<<";
+            if (in_array('en', $langkeys)) {
+                            print strtoupper($langs['en']);
+            } else {
+                            print ">>>> ENGLISH NAME UNSET! <<<<";
+            }
+            if (isset($internal2acode[$internal_id])) {
+                            print " - ".$internal2acode[$internal_id];
+            } else {
+                            print " - >>>> MISSING A-CODE MAPPING <<<<";
+            }
             print "\n";
-            foreach ($langkeys as $langkey)
-                print "        $langkey: ".$langs[$langkey]."\n";
+            foreach ($langkeys as $langkey) {
+                            print "        $langkey: ".$langs[$langkey]."\n";
+            }
         }
 
         print "\nAttribute notices:\n\n";
@@ -110,8 +115,7 @@ 
             # have translation tables.
 
             $rs = Db::query("select id, language, text_long from cache_attrib order by id");
-        }
-        else
+        } else
         {
             # OCDE branch uses translation tables. Let's make a select which will
             # produce results compatible with the one above.
@@ -146,8 +150,7 @@ 
             # OCPL branch does not store cache types in many languages (just two).
 
             $rs = Db::query("select id, en from cache_type order by id");
-        }
-        else
+        } else
         {
             # OCDE branch uses translation tables.
 
@@ -181,8 +184,7 @@ 
             # OCPL branch does not store cache types in many languages (just two).
 
             $rs = Db::query("select id, en from log_types order by id");
-        }
-        else
+        } else
         {
             # OCDE branch uses translation tables.
 

htdocs/okapi/views/devel/clogentry.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
         $tmp = Db::select_value("
             select data
             from okapi_clog
-            where id='".Db::escape_string($_GET['id'])."'
+            where id='".Db::escape_string($_GET['id']) . "'
         ");
         $data = unserialize(gzinflate($tmp));
 

htdocs/okapi/views/examples.php

Spacing +3 added lines, -3 removed lines

@@ -17,12 +17,12 @@
 {
     public static function call()
     {
-        require_once($GLOBALS['rootpath'].'okapi/service_runner.php');
-        require_once($GLOBALS['rootpath'].'okapi/views/menu.inc.php');
+        require_once($GLOBALS['rootpath'] . 'okapi/service_runner.php');
+        require_once($GLOBALS['rootpath'] . 'okapi/views/menu.inc.php');
 
         $vars = array(
             'menu' => OkapiMenu::get_menu_html("examples.html"),
-            'okapi_base_url' => Settings::get('SITE_URL')."okapi/",
+            'okapi_base_url' => Settings::get('SITE_URL') . "okapi/",
             'site_url' => Settings::get('SITE_URL'),
             'installations' => OkapiMenu::get_installations(),
             'okapi_rev' => Okapi::$version_number,

htdocs/okapi/views/method_call.php

Spacing +3 added lines, -3 removed lines

@@ -18,11 +18,11 @@
 {
     public static function call($methodname)
     {
-        require_once($GLOBALS['rootpath'].'okapi/service_runner.php');
+        require_once($GLOBALS['rootpath'] . 'okapi/service_runner.php');
 
         if (!OkapiServiceRunner::exists($methodname))
-            throw new BadRequest("Method '$methodname' does not exist. ".
-                "See OKAPI docs at ".Settings::get('SITE_URL')."okapi/");
+            throw new BadRequest("Method '$methodname' does not exist. " .
+                "See OKAPI docs at " . Settings::get('SITE_URL') . "okapi/");
         $options = OkapiServiceRunner::options($methodname);
         $request = new OkapiHttpRequest($options);
         return OkapiServiceRunner::call($methodname, $request);

Braces +3 added lines, -2 removed lines

@@ -20,9 +20,10 @@
     {
         require_once($GLOBALS['rootpath'].'okapi/service_runner.php');
 
-        if (!OkapiServiceRunner::exists($methodname))
-            throw new BadRequest("Method '$methodname' does not exist. ".
+        if (!OkapiServiceRunner::exists($methodname)) {
+                    throw new BadRequest("Method '$methodname' does not exist. ".
                 "See OKAPI docs at ".Settings::get('SITE_URL')."okapi/");
+        }
         $options = OkapiServiceRunner::options($methodname);
         $request = new OkapiHttpRequest($options);
         return OkapiServiceRunner::call($methodname, $request);

htdocs/okapi/views/changelog_feed.php

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
 {
     public static function call()
     {
-        require_once($GLOBALS['rootpath'].'okapi/views/changelog_helper.inc.php');
+        require_once($GLOBALS['rootpath'] . 'okapi/views/changelog_helper.inc.php');
 
         $changelog = new Changelog();
         $changes = array_merge($changelog->unavailable_changes, $changelog->available_changes);

htdocs/okapi/views/menu.inc.php

Spacing +5 added lines, -5 removed lines

@@ -9,14 +9,14 @@ 
 use okapi\OkapiInternalConsumer;
 use okapi\Settings;
 
-require_once($GLOBALS['rootpath'].'okapi/service_runner.php');
+require_once($GLOBALS['rootpath'] . 'okapi/service_runner.php');
 
 class OkapiMenu
 {
     private static function link($current_path, $link_path, $link_name)
     {
-        return "<a href='".Settings::get('SITE_URL')."okapi/$link_path'".(($current_path == $link_path)
-            ? " class='selected'" : "").">$link_name</a><br>";
+        return "<a href='" . Settings::get('SITE_URL') . "okapi/$link_path'" . (($current_path == $link_path)
+            ? " class='selected'" : "") . ">$link_name</a><br>";
     }
 
     /** Get HTML-formatted side menu representation. */
@@ -24,8 +24,8 @@ 
     {
         $chunks = array();
         if (Okapi::$version_number)
-            $chunks[] = "<div class='revision'>ver. ".Okapi::$version_number.
-                " (".substr(Okapi::$git_revision, 0, 7).")</div>";
+            $chunks[] = "<div class='revision'>ver. " . Okapi::$version_number .
+                " (" . substr(Okapi::$git_revision, 0, 7) . ")</div>";
         $chunks[] = "<div class='main'>";
         $chunks[] = self::link($current_path, "introduction.html", "Introduction");
         $chunks[] = self::link($current_path, "signup.html", "Sign up");

Braces +10 added lines, -8 removed lines

@@ -23,9 +23,10 @@ 
     public static function get_menu_html($current_path = null)
     {
         $chunks = array();
-        if (Okapi::$version_number)
-            $chunks[] = "<div class='revision'>ver. ".Okapi::$version_number.
+        if (Okapi::$version_number) {
+                    $chunks[] = "<div class='revision'>ver. ".Okapi::$version_number.
                 " (".substr(Okapi::$git_revision, 0, 7).")</div>";
+        }
         $chunks[] = "<div class='main'>";
         $chunks[] = self::link($current_path, "introduction.html", "Introduction");
         $chunks[] = self::link($current_path, "signup.html", "Sign up");
@@ -48,8 +49,9 @@ 
             $pos = strrpos($methodname, "/");
             $modulename = substr($methodname, 0, $pos);
             $method_short_name = substr($methodname, $pos + 1);
-            if (!isset($module_methods[$modulename]))
-                $module_methods[$modulename] = array();
+            if (!isset($module_methods[$modulename])) {
+                            $module_methods[$modulename] = array();
+            }
             $module_methods[$modulename][] = $method_short_name;
         }
         $modulenames = array_keys($module_methods);
@@ -59,8 +61,9 @@ 
         {
             $chunks[] = "<div class='module'>$modulename</div>";
             $chunks[] = "<div class='methods'>";
-            foreach ($module_methods[$modulename] as $method_short_name)
-                $chunks[] = self::link($current_path, "$modulename/$method_short_name.html", "$method_short_name");
+            foreach ($module_methods[$modulename] as $method_short_name) {
+                            $chunks[] = self::link($current_path, "$modulename/$method_short_name.html", "$method_short_name");
+            }
             $chunks[] = "</div>";
         }
         return implode("", $chunks);
@@ -84,8 +87,7 @@ 
                 $inst_ref['site_url'] = $site_url;
                 $inst_ref['okapi_base_url'] = $site_url . 'okapi/';
                 $inst_ref['selected'] = true;
-            }
-            else
+            } else
             {
                 $inst_ref['selected'] = false;
             }

htdocs/okapi/views/http404.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
         require_once('menu.inc.php');
 
         $vars = array(
-            'okapi_base_url' => Settings::get('SITE_URL')."okapi/",
+            'okapi_base_url' => Settings::get('SITE_URL') . "okapi/",
             'menu' => OkapiMenu::get_menu_html(),
             'installations' => OkapiMenu::get_installations(),
             'okapi_rev' => Okapi::$version_number,