Passed
Pull Request — master (#347)
by Mirko
08:35
created
htdocs/util/notification/run_notify.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -197,6 +197,9 @@
 block discarded – undo
197 197
     return 0;
198 198
 }
199 199
 
200
+/**
201
+ * @param string $domain
202
+ */
200 203
 function is_existent_maildomain($domain)
201 204
 {
202 205
     $smtp_serverlist = [];
Please login to merge, or discard this patch.
htdocs/util/watchlist/runwatch.php 2 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -484,6 +484,9 @@  discard block
 block discarded – undo
484 484
     );
485 485
 }
486 486
 
487
+/**
488
+ * @param string $watchtext
489
+ */
487 490
 function insert_maintenance_flags($rLog, $language, $watchtext)
488 491
 {
489 492
     global $translate;
@@ -510,6 +513,9 @@  discard block
 block discarded – undo
510 513
     return mb_ereg_replace('{maintenance_flags}', $flagtext, $watchtext);
511 514
 }
512 515
 
516
+/**
517
+ * @param string $domain
518
+ */
513 519
 function is_existent_maildomain($domain)
514 520
 {
515 521
     $smtp_serverlist = [];
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
     WHERE cache_logs.cache_id=caches.cache_id
52 52
     AND cache_logs.owner_notified=0"
53 53
 );
54
-for ($i = 0; $i < mysql_num_rows($rsNewLogs); $i ++) {
54
+for ($i = 0; $i < mysql_num_rows($rsNewLogs); $i++) {
55 55
     $rNewLog = sql_fetch_array($rsNewLogs);
56 56
 
57 57
     $rsNotified = sql(
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
     WHERE `user`.`watchmail_nextmail`<NOW()",
135 135
     $opt['template']['default']['locale']
136 136
 );
137
-for ($i = 0; $i < mysql_num_rows($rsUsers); $i ++) {
137
+for ($i = 0; $i < mysql_num_rows($rsUsers); $i++) {
138 138
     $rUser = sql_fetch_array($rsUsers);
139 139
 
140 140
     if ($rUser['watchmail_nextmail'] != '0000-00-00 00:00:00') {
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
                 );
159 159
                 if (mysql_num_rows($rsWatchesOwner) > 0) {
160 160
                     $logtexts = '';
161
-                    for ($j = 0; $j < mysql_num_rows($rsWatchesOwner); $j ++) {
161
+                    for ($j = 0; $j < mysql_num_rows($rsWatchesOwner); $j++) {
162 162
                         $rWatch = sql_fetch_array($rsWatchesOwner);
163 163
                         $logtexts .= $rWatch['watchtext'];
164 164
                     }
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
                 );
184 184
                 if (mysql_num_rows($rsWatchesLog) > 0) {
185 185
                     $logtexts = '';
186
-                    for ($j = 0; $j < mysql_num_rows($rsWatchesLog); $j ++) {
186
+                    for ($j = 0; $j < mysql_num_rows($rsWatchesLog); $j++) {
187 187
                         $rWatch = sql_fetch_array($rsWatchesLog);
188 188
                         $logtexts .= $rWatch['watchtext'];
189 189
                     }
@@ -583,7 +583,7 @@  discard block
 block discarded – undo
583 583
         $pid_daemon = fgets($pidfile, 20);
584 584
         fclose($pidfile);
585 585
 
586
-        $pid_daemon = (int) $pid_daemon;
586
+        $pid_daemon = (int)$pid_daemon;
587 587
 
588 588
         // process running?
589 589
         if (posix_kill($pid_daemon, 0)) {
Please login to merge, or discard this patch.
htdocs/util2/cron/modules/geokrety.class.php 2 patches
Doc Comments   +32 added lines patch added patch discarded remove patch
@@ -61,6 +61,10 @@  discard block
 block discarded – undo
61 61
 
62 62
     /* remove given file
63 63
      */
64
+
65
+    /**
66
+     * @param string $file
67
+     */
64 68
     public function removeXML($file)
65 69
     {
66 70
         @unlink($file);
@@ -68,6 +72,10 @@  discard block
 block discarded – undo
68 72
 
69 73
     /* import the given XML file
70 74
      */
75
+
76
+    /**
77
+     * @param string $file
78
+     */
71 79
     public function importXML($file)
72 80
     {
73 81
         global $opt;
@@ -124,6 +132,9 @@  discard block
 block discarded – undo
124 132
         setSysConfig('geokrety_lastupdate', date($opt['db']['dateformat'], strtotime($startupdate)));
125 133
     }
126 134
 
135
+    /**
136
+     * @param DOMNode $element
137
+     */
127 138
     public function importGeoKret($element)
128 139
     {
129 140
         global $opt;
@@ -204,6 +215,9 @@  discard block
 block discarded – undo
204 215
     }
205 216
 
206 217
 
218
+    /**
219
+     * @param DOMNode $element
220
+     */
207 221
     public function importMove($element)
208 222
     {
209 223
         global $opt;
@@ -292,6 +306,9 @@  discard block
 block discarded – undo
292 306
     }
293 307
 
294 308
 
309
+    /**
310
+     * @param integer $id
311
+     */
295 312
     public function checkGeoKretType($id, $name)
296 313
     {
297 314
         sql(
@@ -302,6 +319,9 @@  discard block
 block discarded – undo
302 319
     }
303 320
 
304 321
 
322
+    /**
323
+     * @param integer $id
324
+     */
305 325
     public function checkUser($id, $name)
306 326
     {
307 327
         if ($id == 0) {
@@ -312,6 +332,9 @@  discard block
 block discarded – undo
312 332
     }
313 333
 
314 334
 
335
+    /**
336
+     * @param integer $id
337
+     */
315 338
     public function checkMoveType($id, $name)
316 339
     {
317 340
         sql(
@@ -322,6 +345,9 @@  discard block
 block discarded – undo
322 345
     }
323 346
 
324 347
 
348
+    /**
349
+     * @param string $element
350
+     */
325 351
     public function GetNodeValue(&$domnode, $element)
326 352
     {
327 353
         $subnode = $domnode->getElementsByTagName($element);
@@ -333,6 +359,12 @@  discard block
 block discarded – undo
333 359
     }
334 360
 
335 361
 
362
+    /**
363
+     * @param string $element
364
+     * @param string $attr
365
+     *
366
+     * @return string
367
+     */
336 368
     public function GetNodeAttribute(&$domnode, $element, $attr)
337 369
     {
338 370
         $subnode = $domnode->getElementsByTagName($element);
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
                         break;
116 116
                 }
117 117
 
118
-                $nRecordsCount ++;
118
+                $nRecordsCount++;
119 119
             }
120 120
         } while ($xr->next());
121 121
 
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
         $waypoints = $element->getElementsByTagName('waypoints');
254 254
         if ($waypoints->length > 0) {
255 255
             $wpItems = $waypoints->item(0)->getElementsByTagName('waypoint');
256
-            for ($i = 0; $i < $wpItems->length; $i ++) {
256
+            for ($i = 0; $i < $wpItems->length; $i++) {
257 257
                 $wp = mb_trim($wpItems->item($i)->nodeValue);
258 258
                 if ($wp != '') {
259 259
                     sql("INSERT INTO `gk_move_waypoint` (`id`, `wp`) VALUES ('&1', '&2')", $id, $wp);
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
                 WHERE `id`='&2' AND `wp`!=''",
286 286
                 $gkid,
287 287
                 $r['id']
288
-            );  // "late log" bugfix: replaced $id paramter by $r['id']
288
+            ); // "late log" bugfix: replaced $id paramter by $r['id']
289 289
         } else {
290 290
             // do nothing
291 291
         }
Please login to merge, or discard this patch.
htdocs/util2/cron/modules/sitemaps.class.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -61,6 +61,9 @@
 block discarded – undo
61 61
         $this->ping_searchengine('http://www.bing.com/webmaster/ping.aspx?siteMap=' . $url);
62 62
     }
63 63
 
64
+    /**
65
+     * @param string $url
66
+     */
64 67
     public function ping_searchengine($url)
65 68
     {
66 69
         $curl = curl_init($url);
Please login to merge, or discard this patch.
htdocs/xml/ocxml11.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -368,6 +368,9 @@
 block discarded – undo
368 368
 /* end parameter reading */
369 369
 
370 370
 
371
+/**
372
+ * @param integer $sessionid
373
+ */
371 374
 function outputXmlFile($sessionid, $filenr, $bXmlDecl, $bOcXmlTag, $bDocType, $ziptype)
372 375
 {
373 376
     global $zip_basedir, $zip_wwwdir, $sDateformat, $sDateshort, $t1, $t2, $t3, $safemode_zip, $safemode_zip, $sCharset, $bAttrlist;
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 require_once __DIR__ . '/../lib2/const.inc.php';
22 22
 require_once __DIR__ . '/../lib2/logic/data-license.inc.php';
23 23
 require_once __DIR__ . '/../lib2/logic/npas.inc.php';
24
-require_once __DIR__ .' /../lib2/logic/geomath.class.php';
24
+require_once __DIR__ . ' /../lib2/logic/geomath.class.php';
25 25
 
26 26
 if ($error == true) {
27 27
     echo 'Unable to connect to database';
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
 
388 388
     $logtypes = [];
389 389
     $rs = sql('SELECT `id`, `de` FROM log_types');
390
-    for ($i = 0; $i < mysql_num_rows($rs); $i ++) {
390
+    for ($i = 0; $i < mysql_num_rows($rs); $i++) {
391 391
         $r = sql_fetch_array($rs);
392 392
         $logtypes[$r['id']] = $r['de'];
393 393
     }
@@ -395,7 +395,7 @@  discard block
 block discarded – undo
395 395
 
396 396
     $cachetypes = [];
397 397
     $rs = sql('SELECT `id`, `short`, `de` FROM cache_type');
398
-    for ($i = 0; $i < mysql_num_rows($rs); $i ++) {
398
+    for ($i = 0; $i < mysql_num_rows($rs); $i++) {
399 399
         $r = sql_fetch_array($rs);
400 400
         $cachetypes[$r['id']]['de'] = $r['de'];
401 401
         $cachetypes[$r['id']]['short'] = $r['short'];
@@ -404,7 +404,7 @@  discard block
 block discarded – undo
404 404
 
405 405
     $cachestatus = [];
406 406
     $rs = sql('SELECT `id`, `de` FROM cache_status');
407
-    for ($i = 0; $i < mysql_num_rows($rs); $i ++) {
407
+    for ($i = 0; $i < mysql_num_rows($rs); $i++) {
408 408
         $r = sql_fetch_array($rs);
409 409
         $cachestatus[$r['id']]['de'] = $r['de'];
410 410
     }
@@ -412,7 +412,7 @@  discard block
 block discarded – undo
412 412
 
413 413
     $counties = [];
414 414
     $rs = sql('SELECT `short`, `de` FROM countries');
415
-    for ($i = 0; $i < mysql_num_rows($rs); $i ++) {
415
+    for ($i = 0; $i < mysql_num_rows($rs); $i++) {
416 416
         $r = sql_fetch_array($rs);
417 417
         $counties[$r['short']]['de'] = $r['de'];
418 418
     }
@@ -420,7 +420,7 @@  discard block
 block discarded – undo
420 420
 
421 421
     $cachesizes = [];
422 422
     $rs = sql('SELECT `id`, `de` FROM cache_size');
423
-    for ($i = 0; $i < mysql_num_rows($rs); $i ++) {
423
+    for ($i = 0; $i < mysql_num_rows($rs); $i++) {
424 424
         $r = sql_fetch_array($rs);
425 425
         $cachesizes[$r['id']]['de'] = $r['de'];
426 426
     }
@@ -428,7 +428,7 @@  discard block
 block discarded – undo
428 428
 
429 429
     $languages = [];
430 430
     $rs = sql('SELECT `short`, `de` FROM languages');
431
-    for ($i = 0; $i < mysql_num_rows($rs); $i ++) {
431
+    for ($i = 0; $i < mysql_num_rows($rs); $i++) {
432 432
         $r = sql_fetch_array($rs);
433 433
         $languages[$r['short']]['de'] = $r['de'];
434 434
     }
@@ -439,7 +439,7 @@  discard block
 block discarded – undo
439 439
     $objecttypes['3'] = 'cachedesc';
440 440
     $objecttypes['1'] = 'cachelog';
441 441
     $objecttypes['6'] = 'picture';
442
-    $objecttypes['8'] = 'cachelist';    // not implemented yet
442
+    $objecttypes['8'] = 'cachelist'; // not implemented yet
443 443
 
444 444
     /* end now a few dynamically loaded constants */
445 445
 
@@ -452,7 +452,7 @@  discard block
 block discarded – undo
452 452
     while (file_exists(
453 453
         $zip_basedir . 'ocxml11/' . $sessionid . '/' . $sessionid . '-' . $filenr . '-' . $fileid . '.xml'
454 454
     )) {
455
-        $fileid ++;
455
+        $fileid++;
456 456
     }
457 457
 
458 458
     $xmlfilename = $zip_basedir . 'ocxml11/' . $sessionid . '/' . $sessionid . '-' . $filenr . '-' . $fileid . '.xml';
@@ -1300,7 +1300,7 @@  discard block
 block discarded – undo
1300 1300
 //    echo $startat . ' ' . $endat . '<br><br>';
1301 1301
 //    echo '<table>';
1302 1302
 //    echo '<tr><td>sql-start</td><td>sql-count</td><td>count</td><td>begin</td><td>end</td></tr>';
1303
-    for ($i = 0; $i < 6; $i ++) {
1303
+    for ($i = 0; $i < 6; $i++) {
1304 1304
         if (($startat >= $recordnr[$i]) && ($startat + 500 < $recordnr[$i + 1])) {
1305 1305
             if ($recordnr[$i + 1] - $startat > 500) {
1306 1306
                 $limits[$i] = ['start' => $startat - $recordnr[$i], 'count' => 500];
@@ -1422,7 +1422,7 @@  discard block
 block discarded – undo
1422 1422
     $from[4] = '\'';
1423 1423
     $to[4] = '&apos;';
1424 1424
 
1425
-    for ($i = 0; $i <= 4; $i ++) {
1425
+    for ($i = 0; $i <= 4; $i++) {
1426 1426
         $str = mb_ereg_replace($from[$i], $to[$i], $str);
1427 1427
     }
1428 1428
 
@@ -1501,13 +1501,13 @@  discard block
 block discarded – undo
1501 1501
 
1502 1502
     $hDir = opendir($path);
1503 1503
     if ($hDir === false) {
1504
-        ++ $notunlinked;
1504
+        ++$notunlinked;
1505 1505
     } else {
1506 1506
         while (false !== ($file = readdir($hDir))) {
1507 1507
             if (($file != '.') && ($file != '..')) {
1508 1508
                 if (is_dir($path . $file)) {
1509 1509
                     if (unlinkrecursiv($path . $file . '/') == false) {
1510
-                        $notunlinked ++;
1510
+                        $notunlinked++;
1511 1511
                     }
1512 1512
                 } else {
1513 1513
                     if ((mb_substr($file, - 4) == '.zip') ||
@@ -1517,7 +1517,7 @@  discard block
 block discarded – undo
1517 1517
                     ) {
1518 1518
                         @unlink($path . $file);
1519 1519
                     } else {
1520
-                        $notunlinked ++;
1520
+                        $notunlinked++;
1521 1521
                     }
1522 1522
                 }
1523 1523
             }
Please login to merge, or discard this patch.
local/devel/find_unicode_boms.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -39,6 +39,9 @@
 block discarded – undo
39 39
 }
40 40
 
41 41
 
42
+/**
43
+ * @param string $path
44
+ */
42 45
 function testforbom($path)
43 46
 {
44 47
     $filestart = file_get_contents($path, false, null, 0, 2);
Please login to merge, or discard this patch.
local/ocxml11client/index.php 2 patches
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -1281,11 +1281,19 @@
 block discarded – undo
1281 1281
     }
1282 1282
 }
1283 1283
 
1284
+/**
1285
+ * @param string $recordtype
1286
+ * @param string $info
1287
+ */
1284 1288
 function importError($recordtype, $uuid, $r, $info)
1285 1289
 {
1286 1290
     echo 'error: ' . $recordtype . ' (' . $uuid . '): ' . $info . "\n";
1287 1291
 }
1288 1292
 
1293
+/**
1294
+ * @param string $recordtype
1295
+ * @param string $info
1296
+ */
1289 1297
 function importWarn($recordtype, $uuid, $r, $info)
1290 1298
 {
1291 1299
     echo 'warn: ' . $recordtype . ' (' . $uuid . '): ' . $info . "\n";
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
     $nFileNr = 0;
68 68
     $rs = sql('SELECT `id`, `url` FROM `pictures` WHERE `local`=0');
69 69
     while ($r = sql_fetch_array($rs)) {
70
-        $nFileNr ++;
70
+        $nFileNr++;
71 71
         $fileparts = mb_split('/', $r['url']);
72 72
         $filename = $fileparts[count($fileparts) - 1];
73 73
 
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
237 237
             exit;
238 238
         }
239 239
 
240
-        for ($i = 1; $i <= $filescount; $i ++) {
240
+        for ($i = 1; $i <= $filescount; $i++) {
241 241
             echo "Download Paket: " . $i . ' von ' . $filescount . "\n";
242 242
 
243 243
             $fileurl = $opt['url_getsession'];
@@ -411,11 +411,11 @@  discard block
 block discarded – undo
411 411
                             if ($sSubElement != '') {
412 412
                                 // vorheriges element zuerst schlißen
413 413
                                 $sSubElement = '';
414
-                                $nRecursionLevel --;
414
+                                $nRecursionLevel--;
415 415
                             }
416 416
 
417 417
                             $sSubElement = mb_strtoupper($xmlReader->name);
418
-                            $nRecursionLevel ++;
418
+                            $nRecursionLevel++;
419 419
 
420 420
                             // attribute auslesen
421 421
                             if ($xmlReader->moveToFirstAttribute()) {
@@ -432,7 +432,7 @@  discard block
 block discarded – undo
432 432
                         } else {
433 433
                             if ($xmlReader->nodeType == XMLReader::END_ELEMENT) {
434 434
                                 $sSubElement = '';
435
-                                $nRecursionLevel --;
435
+                                $nRecursionLevel--;
436 436
                             }
437 437
                         }
438 438
                     }
Please login to merge, or discard this patch.
local/ocxml11client/xml2array.inc.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -26,6 +26,9 @@
 block discarded – undo
26 26
         $this->stack_ref =& $this->stack[count($this->stack) - 1];
27 27
     }
28 28
 
29
+    /**
30
+     * @param false|string $strInputXML
31
+     */
29 32
     public function parse($strInputXML)
30 33
     {
31 34
 
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -16,14 +16,14 @@
 block discarded – undo
16 16
 
17 17
     public function push_pos(&$pos)
18 18
     {
19
-        $this->stack[count($this->stack)] =& $pos;
20
-        $this->stack_ref =& $pos;
19
+        $this->stack[count($this->stack)] = & $pos;
20
+        $this->stack_ref = & $pos;
21 21
     }
22 22
 
23 23
     public function pop_pos()
24 24
     {
25 25
         unset($this->stack[count($this->stack) - 1]);
26
-        $this->stack_ref =& $this->stack[count($this->stack) - 1];
26
+        $this->stack_ref = & $this->stack[count($this->stack) - 1];
27 27
     }
28 28
 
29 29
     public function parse($strInputXML)
Please login to merge, or discard this patch.
htdocs/editdesc.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -21,8 +21,8 @@  discard block
 block discarded – undo
21 21
     // check for old-style parameters
22 22
     if (isset($_REQUEST['cacheid']) && isset($_REQUEST['desclang']) && !isset($_REQUEST['descid']))  // Ocprop
23 23
     {
24
-        $cache_id = $_REQUEST['cacheid'];  // Ocprop
25
-        $desc_lang = $_REQUEST['desclang'];  // Ocprop
24
+        $cache_id = $_REQUEST['cacheid']; // Ocprop
25
+        $desc_lang = $_REQUEST['desclang']; // Ocprop
26 26
 
27 27
         $rs = sql("SELECT `id` FROM `cache_desc` WHERE `cache_id`='&1' AND `language`='&2'", $cache_id, $desc_lang);
28 28
         if (mysql_num_rows($rs) == 1) {
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
                 if (isset($_POST['post']))  // Ocprop
91 91
                 {
92 92
                     //here we read all used information from the form if submitted
93
-                    $descMode = isset($_POST['descMode']) ? $_POST['descMode'] + 0 : 1;  // Ocprop
93
+                    $descMode = isset($_POST['descMode']) ? $_POST['descMode'] + 0 : 1; // Ocprop
94 94
 
95 95
                     // fuer alte Versionen von OCProp
96 96
                     if (isset($_POST['submit']) && !isset($_POST['version2'])) {
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
                         $oldDescMode = $descMode;
124 124
                     }
125 125
 
126
-                    $short_desc = $_POST['short_desc'];  // Ocprop
126
+                    $short_desc = $_POST['short_desc']; // Ocprop
127 127
                     $hint = htmlspecialchars($_POST['hints'], ENT_COMPAT, 'UTF-8');
128 128
                     $desclang = $_POST['desclang'];
129 129
                     $show_all_langs = isset($_POST['show_all_langs_value']) ? $_POST['show_all_langs_value'] : 0;
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
                     }
139 139
 
140 140
                     // Text from textarea
141
-                    $desc = $_POST['desc'];  // Ocprop
141
+                    $desc = $_POST['desc']; // Ocprop
142 142
 
143 143
                     // fuer alte Versionen von OCProp
144 144
                     if (isset($_POST['submit']) && !isset($_POST['version2'])) {
@@ -297,7 +297,7 @@  discard block
 block discarded – undo
297 297
                 tpl_set_var('desclang', htmlspecialchars($desc_lang, ENT_COMPAT, 'UTF-8'));
298 298
                 tpl_set_var('desclang_name', htmlspecialchars(db_LanguageFromShort($desc_lang), ENT_COMPAT, 'UTF-8'));
299 299
                 tpl_set_var('cachename', htmlspecialchars($desc_record['name'], ENT_COMPAT, 'UTF-8'));
300
-                tpl_set_var('reset', $reset);  // obsolete
300
+                tpl_set_var('reset', $reset); // obsolete
301 301
                 tpl_set_var('submit', $submit);
302 302
 
303 303
                 // Text / normal HTML / HTML editor
Please login to merge, or discard this patch.