Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
14 | View Code Duplication | class MenuSubscriber implements EventSubscriberInterface |
|
|
|||
15 | { |
||
16 | /** |
||
17 | * Returns an array of event names this subscriber wants to listen to. |
||
18 | * |
||
19 | * @return array The event names to listen to |
||
20 | */ |
||
21 | public static function getSubscribedEvents() |
||
27 | |||
28 | /** |
||
29 | * @param MenuEvent $event |
||
30 | */ |
||
31 | public function onConfigureMenu(MenuEvent $event) |
||
40 | } |
||
41 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.