Passed
Pull Request — development (#390)
by Mirko
09:05
created
htdocs/editcache.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
                 }
140 140
 
141 141
                 //here we read all used information from the form if submitted, otherwise from DB
142
-                $cache_name = trim(isset($_POST['name']) ? $_POST['name'] : $cache_record['name']);  // Ocprop
142
+                $cache_name = trim(isset($_POST['name']) ? $_POST['name'] : $cache_record['name']); // Ocprop
143 143
                 $cache_type = isset($_POST['type']) ? $_POST['type'] : $cache_record['type'];
144 144
                 if (!isset($_POST['size'])) {
145 145
                     if ($cache_type == 4 || $cache_type == 5) {
@@ -153,15 +153,15 @@  discard block
 block discarded – undo
153 153
                 $cache_hidden_day = isset($_POST['hidden_day']) ? $_POST['hidden_day'] : date(
154 154
                     'd',
155 155
                     strtotime($cache_record['date_hidden'])
156
-                );  // Ocprop
156
+                ); // Ocprop
157 157
                 $cache_hidden_month = isset($_POST['hidden_month']) ? $_POST['hidden_month'] : date(
158 158
                     'm',
159 159
                     strtotime($cache_record['date_hidden'])
160
-                );  // Ocprop
160
+                ); // Ocprop
161 161
                 $cache_hidden_year = isset($_POST['hidden_year']) ? $_POST['hidden_year'] : date(
162 162
                     'Y',
163 163
                     strtotime($cache_record['date_hidden'])
164
-                );  // Ocprop
164
+                ); // Ocprop
165 165
 
166 166
                 if (is_null($cache_record['date_activate'])) {
167 167
                     $cache_activate_day = isset($_POST['activate_day']) ? $_POST['activate_day'] : date('d');
@@ -187,11 +187,11 @@  discard block
 block discarded – undo
187 187
                     );
188 188
                 }
189 189
 
190
-                $cache_difficulty = isset($_POST['difficulty']) ? $_POST['difficulty'] : $cache_record['difficulty'];  // Ocprop
191
-                $cache_terrain = isset($_POST['terrain']) ? $_POST['terrain'] : $cache_record['terrain'];  // Ocprop
192
-                $cache_country = isset($_POST['country']) ? $_POST['country'] : $cache_record['country'];  // Ocprop
190
+                $cache_difficulty = isset($_POST['difficulty']) ? $_POST['difficulty'] : $cache_record['difficulty']; // Ocprop
191
+                $cache_terrain = isset($_POST['terrain']) ? $_POST['terrain'] : $cache_record['terrain']; // Ocprop
192
+                $cache_country = isset($_POST['country']) ? $_POST['country'] : $cache_record['country']; // Ocprop
193 193
                 $show_all_countries = isset($_POST['show_all_countries']) ? $_POST['show_all_countries'] : 0;
194
-                $status = isset($_POST['status']) ? $_POST['status'] : $cache_record['status'];  // Ocprop
194
+                $status = isset($_POST['status']) ? $_POST['status'] : $cache_record['status']; // Ocprop
195 195
                 $status_old = $cache_record['status'];
196 196
                 $search_time = isset($_POST['search_time']) ? $_POST['search_time'] : $cache_record['search_time'];
197 197
                 $way_length = isset($_POST['way_length']) ? $_POST['way_length'] : $cache_record['way_length'];
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
 
254 254
                 $log_pw = isset($_POST['log_pw']) ? mb_substr($_POST['log_pw'], 0, 20) : $cache_record['logpw'];
255 255
                 // fix #4356: gc waypoints are frequently copy&pasted with leading spaces
256
-                $wp_gc = isset($_POST['wp_gc']) ? strtoupper(trim($_POST['wp_gc'])) : $cache_record['wp_gc'];  // Ocprop
256
+                $wp_gc = isset($_POST['wp_gc']) ? strtoupper(trim($_POST['wp_gc'])) : $cache_record['wp_gc']; // Ocprop
257 257
                 $showlists = isset($_POST['showlists']) ? 1 : $cache_record['show_cachelists'] + 0;
258 258
                 $protect_old_coords = isset($_POST['protect_old_coords']) ? 1 : $cache_record['protect_old_coords'] + 0;
259 259
 
@@ -265,12 +265,12 @@  discard block
 block discarded – undo
265 265
 
266 266
                 if (isset($_POST['latNS'])) {
267 267
                     //get coords from post-form
268
-                    $coords_latNS = $_POST['latNS'];  // Ocprop
269
-                    $coords_lonEW = $_POST['lonEW'];  // Ocprop
270
-                    $coords_lat_h = $_POST['lat_h'];  // Ocprop
271
-                    $coords_lon_h = $_POST['lon_h'];  // Ocprop
272
-                    $coords_lat_min = $_POST['lat_min'];  // Ocprop
273
-                    $coords_lon_min = $_POST['lon_min'];  // Ocprop
268
+                    $coords_latNS = $_POST['latNS']; // Ocprop
269
+                    $coords_lonEW = $_POST['lonEW']; // Ocprop
270
+                    $coords_lat_h = $_POST['lat_h']; // Ocprop
271
+                    $coords_lon_h = $_POST['lon_h']; // Ocprop
272
+                    $coords_lat_min = $_POST['lat_min']; // Ocprop
273
+                    $coords_lon_min = $_POST['lon_min']; // Ocprop
274 274
                 } else {
275 275
                     //get coords from DB
276 276
                     $coords_lon = $cache_record['longitude'];
@@ -564,7 +564,7 @@  discard block
 block discarded – undo
564 564
                                     $logtype = 13;
565 565
                                     break;
566 566
                                 default:
567
-                                    $logtype = 0;  // ???
567
+                                    $logtype = 0; // ???
568 568
                             }
569 569
                             if ($logtype > 0) {
570 570
                                 sql(
@@ -585,7 +585,7 @@  discard block
 block discarded – undo
585 585
 
586 586
                         // update cache attributes
587 587
                         $attriblist = "999";
588
-                        for ($i = 0; $i < count($cache_attribs); $i ++) {
588
+                        for ($i = 0; $i < count($cache_attribs); $i++) {
589 589
                             if ($cache_attribs[$i] + 0 > 0) {
590 590
                                 sql(
591 591
                                     "INSERT IGNORE INTO `caches_attributes` (`cache_id`, `attrib_id`) VALUES('&1', '&2')",
@@ -719,7 +719,7 @@  discard block
 block discarded – undo
719 719
                         $line = mb_ereg_replace('{name}', escape_javascript($record['name']), $line);
720 720
                         $line = mb_ereg_replace('{color}', $rAttrGroup['color'], $line);
721 721
                         $group_line .= $line;
722
-                        $nLineAttrCount ++;
722
+                        $nLineAttrCount++;
723 723
 
724 724
                         $line = $cache_attrib_js;
725 725
                         $line = mb_ereg_replace('{id}', $record['id'], $line);
@@ -776,7 +776,7 @@  discard block
 block discarded – undo
776 776
 
777 777
                 //difficulty
778 778
                 $difficulty_options = '';
779
-                for ($i = 2; $i <= 10; $i ++) {
779
+                for ($i = 2; $i <= 10; $i++) {
780 780
                     if ($cache_difficulty == $i) {
781 781
                         $difficulty_options .= '<option value="' . $i . '" selected="selected">' . $i / 2 . '</option>';
782 782
                     } else {
@@ -788,7 +788,7 @@  discard block
 block discarded – undo
788 788
 
789 789
                 //build terrain options
790 790
                 $terrain_options = '';
791
-                for ($i = 2; $i <= 10; $i ++) {
791
+                for ($i = 2; $i <= 10; $i++) {
792 792
                     if ($cache_terrain == $i) {
793 793
                         $terrain_options .= '<option value="' . $i . '" selected="selected">' . $i / 2 . '</option>';
794 794
                     } else {
@@ -955,7 +955,7 @@  discard block
 block discarded – undo
955 955
                     $tmp = mb_ereg_replace('{publish_notnow_checked}', ($publish == 'notnow') ? 'checked' : '', $tmp);
956 956
 
957 957
                     $activation_hours = '';
958
-                    for ($i = 0; $i <= 23; $i ++) {
958
+                    for ($i = 0; $i <= 23; $i++) {
959 959
                         if ($cache_activate_hour == $i) {
960 960
                             $activation_hours .= '<option value="' . $i . '" selected="selected">' . $i . '</option>';
961 961
                         } else {
@@ -983,7 +983,7 @@  discard block
 block discarded – undo
983 983
                         $cache_id
984 984
                     );
985 985
 
986
-                    for ($i = 0; $i < mysql_num_rows($rspictures); $i ++) {
986
+                    for ($i = 0; $i < mysql_num_rows($rspictures); $i++) {
987 987
                         $tmpline = ($i == 0 ? $pictureline0 : $pictureline);
988 988
                         $pic_record = sql_fetch_array($rspictures);
989 989
 
@@ -1066,7 +1066,7 @@  discard block
 block discarded – undo
1066 1066
                 tpl_set_var('showlists_checked', $showlists ? 'checked="checked"' : '');
1067 1067
                 tpl_set_var('protectcoords_checked', $protect_old_coords ? 'checked="checked"' : '');
1068 1068
 
1069
-                tpl_set_var('reset', $reset);  // obsolete
1069
+                tpl_set_var('reset', $reset); // obsolete
1070 1070
                 tpl_set_var('submit', $submit);
1071 1071
             } else {
1072 1072
                 //TODO: not the owner
Please login to merge, or discard this patch.
htdocs/activation.php 1 patch
Spacing   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -14,10 +14,8 @@
 block discarded – undo
14 14
 // We use short param codes 'u' and 'c' to generate short-enough activation
15 15
 // url that will not be wrapped in plain-text emails.
16 16
 
17
-$code = isset($_REQUEST['code']) ? trim($_REQUEST['code']) :
18
-    (isset($_REQUEST['c']) ? trim($_REQUEST['c']) : '');
19
-$email = isset($_REQUEST['email']) ? trim($_REQUEST['email']) :
20
-    (isset($_REQUEST['e']) ? trim($_REQUEST['e']) : '');
17
+$code = isset($_REQUEST['code']) ? trim($_REQUEST['code']) : (isset($_REQUEST['c']) ? trim($_REQUEST['c']) : '');
18
+$email = isset($_REQUEST['email']) ? trim($_REQUEST['email']) : (isset($_REQUEST['e']) ? trim($_REQUEST['e']) : '');
21 19
 
22 20
 $tpl->assign('errorEMail', false);
23 21
 $tpl->assign('errorCode', false);
Please login to merge, or discard this patch.
htdocs/lang/de/ocstyle/rating.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
 
18 18
  ****************************************************************************/
19 19
 
20
-$rating_tpl =    '<tr>
20
+$rating_tpl = '<tr>
21 21
                 <td valign="top">' . t('Recommendations:') . '</td>
22 22
                 <td valign="top">
23 23
                     {rating_msg}
Please login to merge, or discard this patch.
htdocs/lang/de/expressions.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
 
22 22
 //common vars
23 23
 $dateformat = $opt['locale'][$locale]['format']['date'];
24
-$reset = t('Reset');  // obsolete
24
+$reset = t('Reset'); // obsolete
25 25
 $yes = t('Yes');
26 26
 $no = t('No');
27 27
 
Please login to merge, or discard this patch.
htdocs/util2/stats/rank.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,6 +19,6 @@
 block discarded – undo
19 19
               LIMIT 100');
20 20
 while ($r = sql_fetch_assoc($rs)) {
21 21
     echo $n . ' ' . $r['username'] . ': ' . $r['found'] . "\n";
22
-    $n ++;
22
+    $n++;
23 23
 }
24 24
 sql_free_result($rs);
Please login to merge, or discard this patch.
htdocs/util2/stats/owner.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
 
37 37
     $n = 1;
38 38
     while ($r = sql_fetch_assoc($rs)) {
39
-        echo "  <tr><td style='text-align:right'>&nbsp;&nbsp;" . ($n ++) . ".&nbsp;&nbsp;&nbsp;</td><td style='text-align:right'>" . $r['count'] . "</td><td>&nbsp;&nbsp;" . $r['name'] . "</td></tr>\n";
39
+        echo "  <tr><td style='text-align:right'>&nbsp;&nbsp;" . ($n++) . ".&nbsp;&nbsp;&nbsp;</td><td style='text-align:right'>" . $r['count'] . "</td><td>&nbsp;&nbsp;" . $r['name'] . "</td></tr>\n";
40 40
     }
41 41
     sql_free_result($rs);
42 42
 
Please login to merge, or discard this patch.
htdocs/util2/gns/mksearchindex.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
     foreach ($simpletextsarray as $text) {
28 28
         if ($text != '') {
29 29
             if (nonalpha($text)) {
30
-                die($r['uni'] . ' ' . $text . "\n");// obsolete for the same reason as above
30
+                die($r['uni'] . ' ' . $text . "\n"); // obsolete for the same reason as above
31 31
             }
32 32
 
33 33
             $simpletext = search_text2simple($text);
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 
60 60
 function nonalpha($str)
61 61
 {
62
-    for ($i = 0; $i < mb_strlen($str); $i ++) {
62
+    for ($i = 0; $i < mb_strlen($str); $i++) {
63 63
         if (!((ord(mb_substr($str, $i, 1)) >= ord('a')) && (ord(mb_substr($str, $i, 1)) <= ord('z')))) {
64 64
             return true;
65 65
         }
Please login to merge, or discard this patch.
htdocs/util2/gns/gns_import.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 // ported from lib1 to lib2 / untested!
23 23
 
24 24
 $opt['rootpath'] = '../../';
25
-require_once __DIR__.'/../../lib2/cli.inc.php';
25
+require_once __DIR__ . '/../../lib2/cli.inc.php';
26 26
 
27 27
 /* defaults */
28 28
 $importfiles = [
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
     $file = fopen($filename, "r");
45 45
     $cnt = 0;
46 46
     while ($line = fgets($file, 4096)) {
47
-        if ($cnt ++ == 0) {// skip first line
47
+        if ($cnt++ == 0) {// skip first line
48 48
             continue;
49 49
         }
50 50
 
Please login to merge, or discard this patch.
htdocs/util2/geodb/make_searchindex.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
 
51 51
 function nonalpha($str)
52 52
 {
53
-    for ($i = 0; $i < mb_strlen($str); $i ++) {
53
+    for ($i = 0; $i < mb_strlen($str); $i++) {
54 54
         if (!((ord(mb_substr($str, $i, 1)) >= ord('a')) && (ord(mb_substr($str, $i, 1)) <= ord('z')))) {
55 55
             return true;
56 56
         }
Please login to merge, or discard this patch.