oval_graph._builder_html_graph - Code Metrics - Inspection of "[WIP] Rework ARF XML parser" - OpenSCAP/oval-graph - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#187)

by Jan

created 2021-04-22 16:51 UTC

oval_graph._builder_html_graph A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	125
Duplicated Lines	0 %

Test Coverage

Coverage

96.55%

Importance

Changes

Metric	Value
eloc	106
dl	0
loc	125
ccs	56
cts	58
cp	0.9655
rs	10
c	0
b	0
f	0
wmc	19

12 Methods

Rating	Name	Size	Complexity
A	BuilderHtmlGraph._get_part()	6	3
A	BuilderHtmlGraph._get_script_graph_data()	10	1
A	BuilderHtmlGraph._get_html_body()	14	1
A	BuilderHtmlGraph._get_titles_and_places_for_graph()	10	2
A	BuilderHtmlGraph._get_search_bar()	12	2
A	BuilderHtmlGraph.save_html_report()	3	2
A	BuilderHtmlGraph._format_rules_output()	5	2
A	BuilderHtmlGraph.save_html()	3	1
A	BuilderHtmlGraph.__init__()	7	1
A	BuilderHtmlGraph._get_html()	15	1
A	BuilderHtmlGraph._get_html_head()	10	1
A	BuilderHtmlGraph.print_output_message()	3	2

import json
import os
import re
import sys
from io import BytesIO

import lxml.html
from lxml import etree
from lxml.builder import E, ElementMaker


class BuilderHtmlGraph():

    def __init__(self, parts, verbose, all_in_one):
        self.parts = parts
        self.verbose = verbose
        self.all_in_one = all_in_one
        self.html_head = self._get_html_head()
        self.script = self._get_part('script.js')
        self.search_bar = self._get_search_bar()

    def save_html(self, dict_oval_trees, src, rules):
        self.save_html_report(dict_oval_trees, src)
        self.print_output_message(src, self._format_rules_output(rules))

    def save_html_report(self, dict_of_rules, src):
        with open(src, "wb+") as data_file:
            data_file.writelines(self._get_html(dict_of_rules))

    def _get_html(self, dict_of_rules):
        maker = ElementMaker()
        html = maker.html(

            self.html_head,
            self._get_html_body(dict_of_rules))
        result = etree.tostring(
            html,
            xml_declaration=True,
            doctype=('<!DOCTYPE html>'),
            encoding='utf-8',
            standalone=False,
            with_tail=False,
            method='html',
            pretty_print=True)
        return BytesIO(result)

    def _get_html_head(self):
        return E.head(
            E.meta(charset="utf-8"),
            E.title("OVAL TREE"),
            E.style(self._get_part('css.txt')),
            E.style(self._get_part('bootstrapStyle.txt')),
            E.style(self._get_part('jsTreeStyle.txt')),
            E.script(self._get_part('jQueryScript.txt')),
            E.script(self._get_part('bootstrapScript.txt')),
            E.script(self._get_part('jsTreeScript.txt')),
        )

    def _get_search_bar(self):
        if self.all_in_one:
            return E.div({'class': 'search'},
                         E.div({'class': 'form-group has-feedback has-search'},
                               E.span(
                                   {'class': 'glyphicon glyphicon-search form-control-feedback'}),
                               E.input({'id': 'Search',
                                        'onkeyup': 'search()',
                                        'class': 'form-control',
                                        'type': 'text',
                                        'placeholder': 'Search rule'})))
        return E.div()

    def _get_html_body(self, dict_of_rules):
        return E.body(
            E.script(self._get_script_graph_data(dict_of_rules)),
            E.div(
                self.search_bar,
                self._get_titles_and_places_for_graph(dict_of_rules),
            ),
            E.div({'id': 'modal', 'class': 'modal'},
                  E.div({'class': 'modal-content'},
                        E.span({'id': 'close', 'class': 'close'}, '×'),
                        E.div({'id': 'content'}),
                        )
                  ),
            E.script(self.script),
        )

    def _get_script_graph_data(self, dict_of_rules):
class Foo:
    def some_method(self, x, y):
        return x + y;
        json_of_graphs = {
            re.sub(
                r'[\_\-\.]',
                '',
                k): v for k,
            v in dict_of_rules.items()}
        return ("var data_of_tree = " +
                str(json.dumps(json_of_graphs, sort_keys=False, indent=4)) +
                ";")

    def _get_titles_and_places_for_graph(self, dict_of_rules):
class Foo:
    def some_method(self, x, y):
        return x + y;
        out = '<section id="selection-content"><div id="graphs">'
        for rule in dict_of_rules.keys():
            out += ('<div class="target"><h1>' +
                    rule +
                    '</h1><div id="' +
                    re.sub(r'[\_\-\.]', '', rule) +
                    '"></div></div>')
        out += '</div>'
        return lxml.html.fromstring(out)

    def _get_part(self, part):
        out = ''
        with open(os.path.join(self.parts, part), "r") as data_file:
            for line in data_file.readlines():
                out += line
        return out

    def print_output_message(self, src, rule):

        if self.verbose:
            print('Rule(s) "{}" done!'.format(rule), file=sys.stderr)

    def _format_rules_output(self, rules):
class Foo:
    def some_method(self, x, y):
        return x + y;
        out = ''
        for rule in rules['rules']:
            out += rule + '\n'
        return out


1	1	import json
2	1	import os
3	1	import re
4	1	import sys
5	1	from io import BytesIO
6
7	1	import lxml.html
8	1	from lxml import etree
9	1	from lxml.builder import E, ElementMaker
10
11
12	1	class BuilderHtmlGraph():
13
14	1	def __init__(self, parts, verbose, all_in_one):
15	1	self.parts = parts
16	1	self.verbose = verbose
17	1	self.all_in_one = all_in_one
18	1	self.html_head = self._get_html_head()
19	1	self.script = self._get_part('script.js')
20	1	self.search_bar = self._get_search_bar()
21
22	1	def save_html(self, dict_oval_trees, src, rules):
23	1	self.save_html_report(dict_oval_trees, src)
24	1	self.print_output_message(src, self._format_rules_output(rules))
25
26	1	def save_html_report(self, dict_of_rules, src):
27	1	with open(src, "wb+") as data_file:
28	1	data_file.writelines(self._get_html(dict_of_rules))
29
30	1	def _get_html(self, dict_of_rules):
31	1	maker = ElementMaker()
32	1	html = maker.html(
		0 ignored issues – show Bug introduced 2021-03-12 15:17 UTC by Report Bug Copy Issue Report The Instance of `ElementMaker` does not seem to have a member named `html`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
33		self.html_head,
34		self._get_html_body(dict_of_rules))
35	1	result = etree.tostring(
36		html,
37		xml_declaration=True,
38		doctype=('<!DOCTYPE html>'),
39		encoding='utf-8',
40		standalone=False,
41		with_tail=False,
42		method='html',
43		pretty_print=True)
44	1	return BytesIO(result)
45
46	1	def _get_html_head(self):
47	1	return E.head(
48		E.meta(charset="utf-8"),
49		E.title("OVAL TREE"),
50		E.style(self._get_part('css.txt')),
51		E.style(self._get_part('bootstrapStyle.txt')),
52		E.style(self._get_part('jsTreeStyle.txt')),
53		E.script(self._get_part('jQueryScript.txt')),
54		E.script(self._get_part('bootstrapScript.txt')),
55		E.script(self._get_part('jsTreeScript.txt')),
56		)
57
58	1	def _get_search_bar(self):
59	1	if self.all_in_one:
60		return E.div({'class': 'search'},
61		E.div({'class': 'form-group has-feedback has-search'},
62		E.span(
63		{'class': 'glyphicon glyphicon-search form-control-feedback'}),
64		E.input({'id': 'Search',
65		'onkeyup': 'search()',
66		'class': 'form-control',
67		'type': 'text',
68		'placeholder': 'Search rule'})))
69	1	return E.div()
70
71	1	def _get_html_body(self, dict_of_rules):
72	1	return E.body(
73		E.script(self._get_script_graph_data(dict_of_rules)),
74		E.div(
75		self.search_bar,
76		self._get_titles_and_places_for_graph(dict_of_rules),
77		),
78		E.div({'id': 'modal', 'class': 'modal'},
79		E.div({'class': 'modal-content'},
80		E.span({'id': 'close', 'class': 'close'}, '×'),
81		E.div({'id': 'content'}),
82		)
83		),
84		E.script(self.script),
85		)
86
87	1	def _get_script_graph_data(self, dict_of_rules):
		0 ignored issues – show Coding Style introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
88	1	json_of_graphs = {
89		re.sub(
90		r'[\_\-\.]',
91		'',
92		k): v for k,
93		v in dict_of_rules.items()}
94	1	return ("var data_of_tree = " +
95		str(json.dumps(json_of_graphs, sort_keys=False, indent=4)) +
96		";")
97
98	1	def _get_titles_and_places_for_graph(self, dict_of_rules):
		0 ignored issues – show Coding Style introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
99	1	out = '<section id="selection-content"><div id="graphs">'
100	1	for rule in dict_of_rules.keys():
101	1	out += ('<div class="target"><h1>' +
102		rule +
103		'</h1><div id="' +
104		re.sub(r'[\_\-\.]', '', rule) +
105		'"></div></div>')
106	1	out += '</div>'
107	1	return lxml.html.fromstring(out)
108
109	1	def _get_part(self, part):
110	1	out = ''
111	1	with open(os.path.join(self.parts, part), "r") as data_file:
112	1	for line in data_file.readlines():
113	1	out += line
114	1	return out
115
116	1	def print_output_message(self, src, rule):
		0 ignored issues – show Unused Code introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report The argument `src` seems to be unused. Loading history...
117	1	if self.verbose:
118		print('Rule(s) "{}" done!'.format(rule), file=sys.stderr)
119
120	1	def _format_rules_output(self, rules):
		0 ignored issues – show Coding Style introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
121	1	out = ''
122	1	for rule in rules['rules']:
123	1	out += rule + '\n'
124		return out
125

OpenSCAP / oval-graph

Pull Request — master (#187)

oval_graph._builder_html_graph A

Complexity

Size/Duplication

Test Coverage

Importance

12 Methods

Duplication Side-by-Side

Filter issues like