tests.test_graph.test_bigOvalTree() - Code Metrics - Inspection of "[WIP] Creates requirements for tests and package" - OpenSCAP/oval-graph - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Retried Inspection

Pull Request — master (#161)

by Jan

created 2020-12-17 11:36 UTC

tests.test_graph.test_bigOvalTree() B

↳ Parent: tests.test_graph

Complexity

Conditions

Size

Total Lines	76
Code Lines	59

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	59
nop	0
dl	0
loc	76
rs	8.3417
c	0
b	0
f	0

How to fix Long Method

import pytest


from oval_graph.oval_node import OvalNode

import tests.any_test_help

missing_error_pattern = "Missing required argument!"


bad_value_error_pattern = (

    r'Wrong value of (negation|node_type|argument) (argument|value)(!| for (value|operator) node!)'

    )


def test_bad_tree():

    with pytest.raises(Exception, match="cannot contain any child"):

        assert bad_tree()



def test_bad_tree_only_and_no_child():

    with pytest.raises(Exception, match="must have a child"):

        assert tree_only_and()



def test_bad_tree_only_or_no_child():

    with pytest.raises(Exception, match="must have a child"):

        assert tree_only_or()



def test_bad_tree_with_bad_type_of_node():

    with pytest.raises(Exception, match=bad_value_error_pattern):

        assert tree_with_bad_type()



def test_bad_tree_with_bad_value_of_operator():

    with pytest.raises(Exception, match=bad_value_error_pattern):

        assert tree_with_bad_value_of_operator()



def test_bad_tree_with_bad_value_of_value():

    with pytest.raises(Exception, match=bad_value_error_pattern):

        assert tree_with_bad_value_of_value()



def test_bad_tree_with_bad_value_of_negation():

    with pytest.raises(Exception, match=bad_value_error_pattern):

        assert tree_with_bad_value_of_negation()



def test_bad_tree_with_miss_id_argument():

    with pytest.raises(Exception, match=missing_error_pattern):

        assert miss_id_argument()



def test_bad_tree_with_miss_value_argument():

    with pytest.raises(Exception, match=missing_error_pattern):

        assert miss_value_argument()



# degenered trees


def miss_id_argument():

    tree = OvalNode(

        node_type='operator',
        value='and',
        children=[
            OvalNode(
                node_id=2,
                node_type='value',
                value="false",
            ),
        ]
    )
    return



def miss_value_argument():

    tree = OvalNode(

        node_id=1,
        node_type='operator',
        children=[
            OvalNode(
                node_id=2,
                node_type='value',
                value="false",
            ),
        ]
    )
    return



def bad_tree():

    """

         t
         |
        and
         |
         t
    """
    t = OvalNode(

        node_id=1,
        node_type="value",
        value="true",
        children=[
            OvalNode(
                node_id=2,
                node_type="operator",
                value="and",
                children=[
                    OvalNode(
                        node_id=3,
                        node_type="value",
                        value="true",
                    ),
                ]
            ),
        ]
    )
    return



def tree_only_or():

    """

        or
    """
    tree = OvalNode(

        node_id=1,
        node_type="operator",
        value='or',
    )
    return



def tree_only_and():

    """

        and
    """
    tree = OvalNode(

        node_id=1,
        node_type="operator",
        value='and',
    )
    return



def tree_with_bad_value_of_operator():

    tree = OvalNode(

        node_id=1,
        node_type="operator",
        value='nad',
    )
    return



def tree_with_bad_value_of_value():

    tree = OvalNode(

        node_id=1,
        node_type="value",
        value='and',
    )
    return



def tree_with_bad_type():

    tree = OvalNode(

        node_id=1,
        node_type="car",
        value='and',
    )
    return



def tree_with_bad_value_of_negation():

    tree = OvalNode(

        node_id=1,
        node_type="operator",
        value="true",
        children=[
            OvalNode(
                node_id=2,
                node_type="value",
                value='true',
                negation="random_string",
            )
        ]
    )
    return


# normal trees


def test_UPPERCASETree():

    t = OvalNode(

        node_id=1,
        node_type="OPERATOR",
        value="AND",
        children=[
            OvalNode(
                node_id=2,
                node_type="VALUE",
                value="TRUE",
            ),
            OvalNode(
                node_id=3,
                node_type="VALUE",
                value="NOTAPPL",
            ),
        ]
    )
    return



def test_bigOvalTree():

    tree = OvalNode(

        node_id=1,
        node_type='operator',
        value='and',
        children=[
            OvalNode(
                node_id=2,
                node_type='value',
                value="false",
            ),
            OvalNode(
                node_id=3,
                node_type='operator',
                value="xor",
                children=[
                    OvalNode(
                        node_id=4,
                        node_type='value',
                        value='true',
                    ),
                    OvalNode(
                        node_id=5,
                        node_type='operator',
                        value='one',
                        children=[
                            OvalNode(
                                node_id=6,
                                node_type='value',
                                value='noteval',
                            ),
                            OvalNode(
                                node_id=7,
                                node_type='value',
                                value='true',
                            ),
                            OvalNode(
                                node_id=8,
                                node_type='value',
                                value='notappl',
                            ),
                        ]
                    ),
                    OvalNode(
                        node_id=9,
                        node_type='value',
                        value='error',
                    ),
                ]
            ),
            OvalNode(
                node_id=10,
                node_type='operator',
                value='or',
                children=[
                    OvalNode(
                        node_id=11,
                        node_type='value',
                        value="unknown",
                    ),
                    OvalNode(
                        node_id=12,
                        node_type='value',
                        value="true",
                    ),
                ]
            ),
        ]
    )

    test_data_src = 'test_data/bigOvalTree.json'

    dict_of_tree = tests.any_test_help.any_get_test_data_json(test_data_src)

    tests.any_test_help.any_test_treeEvaluation_with_tree(tree, "false")

    tests.any_test_help.any_test_tree_to_dict_of_tree(tree, dict_of_tree)

    tests.any_test_help.find_any_node(tree, 5)

    tests.any_test_help.any_test_dict_to_tree(dict_of_tree)


###################################################


def get_and_false_tree():
    """

        and
         |
         f
    """
    return OvalNode(

        node_id=1,
        node_type='operator',
        value='and',
        children=[
            OvalNode(
                node_id=2,
                node_type='value',
                value="false",
            ),
        ]
    )


def test_treeRepr():

    assert str(get_and_false_tree()) == "and"



def test_add_to_tree():

    test_data_src = 'test_data/add_to_tree.json'

    dict_of_tree = tests.any_test_help.any_get_test_data_json(test_data_src)


    tree = get_and_false_tree()

    tree1 = OvalNode(

        node_id=3,
        node_type='value',
        value="true",
    )
    tree.add_to_tree(1, tree1)

    assert tree.save_tree_to_dict() == dict_of_tree



def test_ChangeValueTree():

    """

        and
        /|\
       t t or
          / \
         f   t
    """
    Tree = OvalNode(

        node_id=1,
        node_type='operator',
        value='and',
        children=[
            OvalNode(
                node_id=2,
                node_type='value',
                value="true",
            ),
            OvalNode(
                node_id=3,
                node_type='value',
                value="false",
            ),
            OvalNode(
                node_id=4,
                node_type='operator',
                value='or',
                children=[
                    OvalNode(
                        node_id=5,
                        node_type='value',
                        value="false",
                    ),
                    OvalNode(
                        node_id=6,
                        node_type='value',
                        value="true",
                    ),
                ]
            ),
        ]
    )

    Tree.change_tree_value(3, "true")

    tests.any_test_help.any_test_treeEvaluation_with_tree(Tree, "true")



def test_node_operator_negate():
    """

        !and
         |
         f
    """
    tree = OvalNode(

        node_id=1,
        node_type='operator',
        value='and',
        negation=True,
        children=[
            OvalNode(
                node_id=2,
                node_type='value',
                value="false",
            ),
        ]
    )
    tests.any_test_help.any_test_treeEvaluation_with_tree(tree, "true")



def test_node_value_negate():
    """

        and
         |
         !f
    """
    tree = OvalNode(

        node_id=1,
        node_type='operator',
        value='and',
        children=[
            OvalNode(
                node_id=2,
                node_type='value',
                value="false",
                negation=True,
            ),
        ]
    )
    tests.any_test_help.any_test_treeEvaluation_with_tree(tree, "true")



def test_node_value_negate1():
    """

        and
         |
         !t
    """

    tree = OvalNode(

        node_id=1,
        node_type='operator',
        value='and',
        children=[
            OvalNode(
                node_id=2,
                node_type='value',
                value="true",
                negation=True,
            ),
        ]
    )
    tests.any_test_help.any_test_treeEvaluation_with_tree(tree, "false")



1			import pytest
			0 ignored issues – show introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Missing module docstring Loading history... introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report import missing `from __future__ import absolute_import` Loading history...
2
3			from oval_graph.oval_node import OvalNode
4
5			import tests.any_test_help
6
7			missing_error_pattern = "Missing required argument!"
			0 ignored issues – show Coding Style Naming introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Constant name "missing_error_pattern" doesn't conform to '(([A-Z_][A-Z0-9_])\|(__.__))$' pattern ('(([A-Z_][A-Z0-9_])\|(__.__))$' pattern) This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
8
9			bad_value_error_pattern = (
			0 ignored issues – show Coding Style Naming introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Constant name "bad_value_error_pattern" doesn't conform to '(([A-Z_][A-Z0-9_])\|(__.__))$' pattern ('(([A-Z_][A-Z0-9_])\|(__.__))$' pattern) This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
10			r'Wrong value of (negation\|node_type\|argument) (argument\|value)(!\| for (value\|operator) node!)'
			0 ignored issues – show Coding Style introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report This line is too long as per the coding-style (99/80). This check looks for lines that are too long. You can specify the maximum line length. Loading history...
11			)
12
13
14			def test_bad_tree():
			0 ignored issues – show introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Missing function or method docstring Loading history...
15			with pytest.raises(Exception, match="cannot contain any child"):
			0 ignored issues – show Coding Style introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Bad indentation. Found 4 tabs, expected 1 Loading history...
16			assert bad_tree()
			0 ignored issues – show Coding Style introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Bad indentation. Found 8 tabs, expected 2 Loading history...
17
18
19			def test_bad_tree_only_and_no_child():
			0 ignored issues – show introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Missing function or method docstring Loading history...
20			with pytest.raises(Exception, match="must have a child"):
			0 ignored issues – show Coding Style introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Bad indentation. Found 4 tabs, expected 1 Loading history...
21			assert tree_only_and()
			0 ignored issues – show Coding Style introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Bad indentation. Found 8 tabs, expected 2 Loading history...
22
23
24			def test_bad_tree_only_or_no_child():
			0 ignored issues – show introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Missing function or method docstring Loading history...
25			with pytest.raises(Exception, match="must have a child"):
			0 ignored issues – show Coding Style introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Bad indentation. Found 4 tabs, expected 1 Loading history...
26			assert tree_only_or()
			0 ignored issues – show Coding Style introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Bad indentation. Found 8 tabs, expected 2 Loading history...
27

OpenSCAP / oval-graph

Pull Request — master (#161)

tests.test_graph.test_bigOvalTree() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like