oval_graph.arf_to_json

Complexity

Total Complexity

15

Size/Duplication

Total Lines	63
Duplicated Lines	28.57 %

Test Coverage

Coverage

0%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	ArfToJson.file_is_empty()	0	2	1
A	ArfToJson._get_message()	0	6	1
A	ArfToJson.prepare_parser()	0	3	1
B	ArfToJson.save_dict_as_json()	0	8	6
A	ArfToJson._set_attributes()	0	4	1
A	ArfToJson.prepare_data()	18	18	4
A	ArfToJson.create_dict_of_rule()	0	2	1

'''
    This file contains a class for command arf-to-json
'''

import json
import os

from .client import Client
from .exceptions import NotChecked
from .xml_parser import XmlParser


class ArfToJson(Client):

Missing class docstring

    def _set_attributes(self):
        self.show_failed_rules = self.arg.show_failed_rules
        self.show_not_selected_rules = self.arg.show_not_selected_rules
        self.xml_parser = XmlParser(self.source_filename)

    def _get_message(self):
        MESSAGES = {

Variable name "MESSAGES" doesn't conform to '[a-z_][a-z0-9_]2,30$' pattern ('[a-z_][a-z0-9_]2,30$' pattern)

            'description': 'Client for generating JSON of SCAP rule evaluation results',
            'source_filename': 'ARF scan file',
        }
        return MESSAGES

    def create_dict_of_rule(self, rule_id):

Missing function or method docstring

        return self.xml_parser.get_oval_tree(rule_id).save_tree_to_dict()

    def file_is_empty(self, path):

Missing function or method docstring

This method could be written as a function/class method.

        return os.stat(path).st_size == 0

    def save_dict_as_json(self, dict_, src):

Missing function or method docstring

        if os.path.isfile(src) and not self.file_is_empty(src):
            with open(src, "r") as f:

Variable name "f" doesn't conform to '[a-z_][a-z0-9_]2,30$' pattern ('[a-z_][a-z0-9_]2,30$' pattern)

                data = json.load(f)
                for key in data:
                    dict_[key] = data[key]
        with open(src, "w+") as f:

Variable name "f" doesn't conform to '[a-z_][a-z0-9_]2,30$' pattern ('[a-z_][a-z0-9_]2,30$' pattern)

            json.dump(dict_, f)

    def prepare_data(self, rules):

This code seems to be duplicated in your project.

        out = []
        rule = None
        out_oval_tree_dict = dict()
        for rule in rules['rules']:
            try:
                out_oval_tree_dict[self.START_OF_FILE_NAME + rule +
                                   self.date] = self.create_dict_of_rule(rule)
            except NotChecked as error:
                out_oval_tree_dict[self.START_OF_FILE_NAME + rule +
                                   self.date] = str(error)
        if self.out is not None:
            self.save_dict_as_json(out_oval_tree_dict, self.out)
            out.append(self.out)
        else:
            print(
                str(json.dumps(out_oval_tree_dict, sort_keys=False, indent=4)))
        return out

    def prepare_parser(self):
        super().prepare_parser()
        self.prepare_args_when_user_can_list_in_rules()