oval_graph.command_line_client.arf_to_json.ArfToJson.prepare_data() - Code Metrics - Inspection of "Rework client" - OpenSCAP/oval-graph - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#156)

by Jan

created 2021-01-22 14:26 UTC

ArfToJson.prepare_data() A

↳ Parent: oval_graph.command_line_client.arf_to_json

Complexity

Conditions

Size

Total Lines	18
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	4.0058

Importance

Changes

Metric	Value
cc	4
eloc	17
nop	2
dl	0
loc	18
ccs	13
cts	14
cp	0.9286
crap	4.0058
rs	9.55
c	0
b	0
f	0

import json

import os

from ..exceptions import NotChecked
from .client_arf_input import ClientArfInput


class ArfToJson(ClientArfInput):

    def _get_message(self):
        return {
            'description': 'Client for generating JSON of SCAP rule evaluation results',
            'source_filename': 'ARF scan file',
        }

    def create_dict_of_rule(self, rule_id):

        return self.xml_parser.get_oval_tree(rule_id).save_tree_to_dict()

    @staticmethod
    def file_is_empty(path):

        return os.stat(path).st_size == 0

    def save_dict_as_json(self, dict_, src):

        if os.path.isfile(src) and not self.file_is_empty(src):
            with open(src, "r") as file_:
                data = json.load(file_)
                for key in data:
                    dict_[key] = data[key]
        with open(src, "w+") as file_:
            json.dump(dict_, file_)

    def prepare_data(self, rules):
        out = []
        rule = None
        out_oval_tree_dict = dict()
        for rule in rules['rules']:
            try:
                out_oval_tree_dict[
                    rule + self.date] = self.create_dict_of_rule(rule)
            except NotChecked as error:
                out_oval_tree_dict[
                    rule + self.date] = str(error)
        if self.out is not None:
            self.save_dict_as_json(out_oval_tree_dict, self.out)
            out.append(self.out)
        else:
            print(
                str(json.dumps(out_oval_tree_dict, sort_keys=False, indent=4)))
        return out

    def prepare_parser(self):
        super().prepare_parser()
        self.prepare_args_when_user_can_list_in_rules()


1	1	import json
		0 ignored issues – show introduced 2020-12-20 23:54 UTC by Report Bug Copy Issue Report Missing module docstring Loading history...
2	1	import os
3
4	1	from ..exceptions import NotChecked
5	1	from .client_arf_input import ClientArfInput
6
7
8	1	class ArfToJson(ClientArfInput):
		0 ignored issues – show introduced 2020-12-20 23:54 UTC by Report Bug Copy Issue Report Missing class docstring Loading history...
9	1	def _get_message(self):
10	1	return {
11		'description': 'Client for generating JSON of SCAP rule evaluation results',
12		'source_filename': 'ARF scan file',
13		}
14
15	1	def create_dict_of_rule(self, rule_id):
		0 ignored issues – show introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Missing function or method docstring Loading history...
16	1	return self.xml_parser.get_oval_tree(rule_id).save_tree_to_dict()
17
18	1	@staticmethod
19		def file_is_empty(path):
		0 ignored issues – show introduced 2020-12-20 23:54 UTC by Report Bug Copy Issue Report Missing function or method docstring Loading history...
20	1	return os.stat(path).st_size == 0
21
22	1	def save_dict_as_json(self, dict_, src):
		0 ignored issues – show introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Missing function or method docstring Loading history...
23	1	if os.path.isfile(src) and not self.file_is_empty(src):
24	1	with open(src, "r") as file_:
25	1	data = json.load(file_)
26	1	for key in data:
27	1	dict_[key] = data[key]
28	1	with open(src, "w+") as file_:
29	1	json.dump(dict_, file_)
30
31	1	def prepare_data(self, rules):
32	1	out = []
33	1	rule = None
34	1	out_oval_tree_dict = dict()
35	1	for rule in rules['rules']:
36	1	try:
37	1	out_oval_tree_dict[
38		rule + self.date] = self.create_dict_of_rule(rule)
39	1	except NotChecked as error:
40		out_oval_tree_dict[
41		rule + self.date] = str(error)
42	1	if self.out is not None:
43	1	self.save_dict_as_json(out_oval_tree_dict, self.out)
44	1	out.append(self.out)
45		else:
46	1	print(
47		str(json.dumps(out_oval_tree_dict, sort_keys=False, indent=4)))
48	1	return out
49
50	1	def prepare_parser(self):
51	1	super().prepare_parser()
52		self.prepare_args_when_user_can_list_in_rules()
53

OpenSCAP / oval-graph

Pull Request — master (#156)

ArfToJson.prepare_data() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like