oval_graph.converter.Converter._show_node() - Code Metrics - Inspection of "Merge pull request #164 from Honny1/fiximportsSort" - OpenSCAP/oval-graph - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d0bc7d...7bae51 )

by Matěj

created 2021-03-03 17:05 UTC

oval_graph.converter.Converter._show_node() A

↳ Parent: oval_graph.converter

Complexity

Conditions

Size

Total Lines	2
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nop	2
dl	0
loc	2
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

import re


from .oval_node import OvalNode


class Converter():

    def __init__(self, tree):
        self.VALUE_TO_BOOTSTRAP_COLOR = {

            "true": "text-success",
            "false": "text-danger",
            "error": "text-dark",
            "unknown": "text-dark",
            "noteval": "text-dark",
            "notappl": "text-dark"
        }

        self.BOOTSTRAP_COLOR_TO_LABEL_COLOR = {

            "text-success": "label-success",
            "text-danger": "label-danger",
            "text-dark": "label-default"
        }

        self.VALUE_TO_ICON = {

            "true": "glyphicon glyphicon-ok text-success",
            "false": "glyphicon glyphicon-remove text-danger",
            "error": "glyphicon glyphicon-question-sign text-dark",
            "unknown": "glyphicon glyphicon-question-sign text-dark",
            "noteval": "glyphicon glyphicon-question-sign text-dark",
            "notappl": "glyphicon glyphicon-question-sign text-dark"
        }

        if isinstance(tree, OvalNode):
            self.tree = tree
            self.result = self.tree.evaluate_tree()
            if self.tree.node_type == 'value':
                self.result = self.tree.value
        else:
            raise ValueError(
                'This converter can process only trees created from OvalNodes.')

    def _get_node_icon(self):
        values = self._get_node_style()
        return dict(
            color=self.VALUE_TO_BOOTSTRAP_COLOR[values['test_value']],
            icon=self.VALUE_TO_ICON[values['negation_color']],
        )

    def get_comment(self):

        if self.tree.comment is not None:
            return str(self.tree.comment)
        return ""

    def get_tag(self):

        if self.tree.tag is not None:
            return str(self.tree.tag)
        return ""

    def to_JsTree_dict(self, hide_passing_tests=False):

        icons = self._get_node_icon()
        label = self._get_label()
        if self.tree.test_result_details:
            self.tree.test_result_details['result'] = (
                ' <span class="label {color_tag}">{result}</span>'
                .format(
                    color_tag=self.BOOTSTRAP_COLOR_TO_LABEL_COLOR[icons['color']],
                    result=self.result,
                ))
        out = {'text':
               '{negation} <strong><span class="{icon}">{label}</span></strong>'
               ' <span class="label {color_tag}">{tag}</span>'
               ' <span class="label {color_tag}">{result}</span>'
               ' <i>{comment}</i>'
               .format(negation=str(
                   label['negation'] if label['negation'] else ""),
                   icon=icons['color'],
                   label=label['str'],
                   color_tag=self.BOOTSTRAP_COLOR_TO_LABEL_COLOR[icons['color']],
                   tag=self.get_tag(),
                   result=self._get_not_negate_result(),
                   comment=self.get_comment()),
               "icon": icons['icon'],
               "state": {"opened": self._show_node(hide_passing_tests)},
               "info": self.tree.test_result_details,
               }
        if self.tree.children:
            out['children'] = [Converter(child).to_JsTree_dict(
                hide_passing_tests) for child in self.tree.children]
        return out

    def _get_not_negate_result(self):
        if self.tree.negation and self.tree.node_type == 'operator' and self.is_bool(
                self.result):
            return self.negate_bool(self.result)
        return self.result

    def _show_node(self, hide_passing_tests):
        return not(self.result == 'true' and hide_passing_tests)

    def _get_node_style(self):
        value = self._get_not_negate_result()
        out_color = None
        if self.tree.negation and self.is_bool(value):
            out_color = self.negate_bool(value)
        else:
            out_color = value
        return dict(
            negation_color=out_color,
            test_value=value,
        )

    def get_negation_character(self, value):

        return ('<strong><span class="' +
                self.VALUE_TO_BOOTSTRAP_COLOR[value] +
                '">NOT</strong></span>')

    def _get_label(self):
        out = dict(negation=None, str="")
        if self.tree.node_type == 'value':
            out['negation'] = self._get_negation_for_label_of_value()
            out['str'] = re.sub(
                '(oval:ssg-test_|oval:ssg-)|(:def:1|:tst:1)', '', str(self.tree.node_id))
        else:
            if str(self.tree.node_id).startswith('xccdf_org'):
                out['str'] = re.sub(
                    '(xccdf_org.ssgproject.content_)', '', str(
                        self.tree.node_id))
            else:
                out['negation'] = self._get_negation_for_label_of_operator()
                out['str'] = (self.tree.value).upper()
        return out

    def _get_negation_for_label_of_value(self):

        if self.tree.negation and self.is_bool(self.tree.value):
            return self.get_negation_character(
                self.negate_bool(self.tree.value))

    def _get_negation_for_label_of_operator(self):

        if self.tree.negation and self.is_bool(self.result):
            return self.get_negation_character(self.result)

    def negate_bool(self, value):
class Foo:
    def some_method(self, x, y):
        return x + y;
        values = {
            "true": "false",
            "false": "true",
        }
        return values[str(value)]

    def is_bool(self, value):
class Foo:
    def some_method(self, x, y):
        return x + y;
        return value == "true" or value == "false"



1	1	import re
		0 ignored issues – show introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Missing module docstring Loading history...
2
3	1	from .oval_node import OvalNode
4
5
6	1	class Converter():
		0 ignored issues – show introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Missing class docstring Loading history...
7	1	def __init__(self, tree):
8	1	self.VALUE_TO_BOOTSTRAP_COLOR = {
		0 ignored issues – show Coding Style Naming introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Attribute name "VALUE_TO_BOOTSTRAP_COLOR" doesn't conform to '[a-z_][a-z0-9_]2,30$' pattern ('[a-z_][a-z0-9_]2,30$' pattern) This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
9		"true": "text-success",
10		"false": "text-danger",
11		"error": "text-dark",
12		"unknown": "text-dark",
13		"noteval": "text-dark",
14		"notappl": "text-dark"
15		}
16
17	1	self.BOOTSTRAP_COLOR_TO_LABEL_COLOR = {
		0 ignored issues – show Coding Style Naming introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Attribute name "BOOTSTRAP_COLOR_TO_LABEL_COLOR" doesn't conform to '[a-z_][a-z0-9_]2,30$' pattern ('[a-z_][a-z0-9_]2,30$' pattern) This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
18		"text-success": "label-success",
19		"text-danger": "label-danger",
20		"text-dark": "label-default"
21		}
22
23	1	self.VALUE_TO_ICON = {
		0 ignored issues – show Coding Style Naming introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Attribute name "VALUE_TO_ICON" doesn't conform to '[a-z_][a-z0-9_]2,30$' pattern ('[a-z_][a-z0-9_]2,30$' pattern) This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
24		"true": "glyphicon glyphicon-ok text-success",
25		"false": "glyphicon glyphicon-remove text-danger",
26		"error": "glyphicon glyphicon-question-sign text-dark",
27		"unknown": "glyphicon glyphicon-question-sign text-dark",
28		"noteval": "glyphicon glyphicon-question-sign text-dark",
29		"notappl": "glyphicon glyphicon-question-sign text-dark"
30		}
31
32	1	if isinstance(tree, OvalNode):
33	1	self.tree = tree
34	1	self.result = self.tree.evaluate_tree()
35	1	if self.tree.node_type == 'value':
36	1	self.result = self.tree.value
37		else:
38		raise ValueError(
39		'This converter can process only trees created from OvalNodes.')
40
41	1	def _get_node_icon(self):
42	1	values = self._get_node_style()
43	1	return dict(
44		color=self.VALUE_TO_BOOTSTRAP_COLOR[values['test_value']],
45		icon=self.VALUE_TO_ICON[values['negation_color']],
46		)
47
48	1	def get_comment(self):
		0 ignored issues – show introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Missing function or method docstring Loading history...
49	1	if self.tree.comment is not None:
50	1	return str(self.tree.comment)
51	1	return ""
52
53	1	def get_tag(self):
		0 ignored issues – show introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Missing function or method docstring Loading history...
54	1	if self.tree.tag is not None:
55	1	return str(self.tree.tag)
56	1	return ""
57
58	1	def to_JsTree_dict(self, hide_passing_tests=False):
		0 ignored issues – show Coding Style Naming introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Method name "to_JsTree_dict" doesn't conform to '[a-z_][a-z0-9_]2,30$' pattern ('[a-z_][a-z0-9_]2,30$' pattern) This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Missing function or method docstring Loading history...
59	1	icons = self._get_node_icon()
60	1	label = self._get_label()
61	1	if self.tree.test_result_details:
62	1	self.tree.test_result_details['result'] = (
63		' <span class="label {color_tag}">{result}</span>'
64		.format(
65		color_tag=self.BOOTSTRAP_COLOR_TO_LABEL_COLOR[icons['color']],
66		result=self.result,
67		))
68	1	out = {'text':
69		'{negation} <strong><span class="{icon}">{label}</span></strong>'
70		' <span class="label {color_tag}">{tag}</span>'
71		' <span class="label {color_tag}">{result}</span>'
72		' <i>{comment}</i>'
73		.format(negation=str(
74		label['negation'] if label['negation'] else ""),
75		icon=icons['color'],
76		label=label['str'],
77		color_tag=self.BOOTSTRAP_COLOR_TO_LABEL_COLOR[icons['color']],
78		tag=self.get_tag(),
79		result=self._get_not_negate_result(),
80		comment=self.get_comment()),
81		"icon": icons['icon'],
82		"state": {"opened": self._show_node(hide_passing_tests)},
83		"info": self.tree.test_result_details,
84		}
85	1	if self.tree.children:
86	1	out['children'] = [Converter(child).to_JsTree_dict(
87		hide_passing_tests) for child in self.tree.children]
88	1	return out
89
90	1	def _get_not_negate_result(self):
91	1	if self.tree.negation and self.tree.node_type == 'operator' and self.is_bool(
92		self.result):
93	1	return self.negate_bool(self.result)
94	1	return self.result
95
96	1	def _show_node(self, hide_passing_tests):
97	1	return not(self.result == 'true' and hide_passing_tests)
98
99	1	def _get_node_style(self):
100	1	value = self._get_not_negate_result()
101	1	out_color = None
102	1	if self.tree.negation and self.is_bool(value):
103	1	out_color = self.negate_bool(value)
104		else:
105	1	out_color = value
106	1	return dict(
107		negation_color=out_color,
108		test_value=value,
109		)
110
111	1	def get_negation_character(self, value):
		0 ignored issues – show introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Missing function or method docstring Loading history...
112	1	return ('<strong><span class="' +
113		self.VALUE_TO_BOOTSTRAP_COLOR[value] +
114		'">NOT</strong></span>')
115
116	1	def _get_label(self):
117	1	out = dict(negation=None, str="")
118	1	if self.tree.node_type == 'value':
119	1	out['negation'] = self._get_negation_for_label_of_value()
120	1	out['str'] = re.sub(
121		'(oval:ssg-test_\|oval:ssg-)\|(:def:1\|:tst:1)', '', str(self.tree.node_id))
122		else:
123	1	if str(self.tree.node_id).startswith('xccdf_org'):
124	1	out['str'] = re.sub(
125		'(xccdf_org.ssgproject.content_)', '', str(
126		self.tree.node_id))
127		else:
128	1	out['negation'] = self._get_negation_for_label_of_operator()
129	1	out['str'] = (self.tree.value).upper()
130	1	return out
131
132	1	def _get_negation_for_label_of_value(self):
		0 ignored issues – show Coding Style Naming introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Method name "_get_negation_for_label_of_value" doesn't conform to '[a-z_][a-z0-9_]2,30$' pattern ('[a-z_][a-z0-9_]2,30$' pattern) This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Unused Code introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Either all return statements in a function should return an expression, or none of them should. Loading history...
133	1	if self.tree.negation and self.is_bool(self.tree.value):
134	1	return self.get_negation_character(
135		self.negate_bool(self.tree.value))
136
137	1	def _get_negation_for_label_of_operator(self):
		0 ignored issues – show Coding Style Naming introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Method name "_get_negation_for_label_of_operator" doesn't conform to '[a-z_][a-z0-9_]2,30$' pattern ('[a-z_][a-z0-9_]2,30$' pattern) This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Unused Code introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Either all return statements in a function should return an expression, or none of them should. Loading history...
138	1	if self.tree.negation and self.is_bool(self.result):
139	1	return self.get_negation_character(self.result)
140
141	1	def negate_bool(self, value):
		0 ignored issues – show introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Missing function or method docstring Loading history... Coding Style introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
142	1	values = {
143		"true": "false",
144		"false": "true",
145		}
146	1	return values[str(value)]
147
148	1	def is_bool(self, value):
		0 ignored issues – show introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Missing function or method docstring Loading history... Coding Style introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
149		return value == "true" or value == "false"
		0 ignored issues – show Unused Code introduced 2020-12-17 11:40 UTC by Report Bug Copy Issue Report Consider merging these comparisons with "in" to "value in ('true', 'false')" Loading history...
150

OpenSCAP / oval-graph

Push — master ( d0bc7d...7bae51 )

oval_graph.converter.Converter._show_node() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like