tests.unit_tests.test_oval_items_parser.fixture_parser() - Code Metrics - Inspection of "Merge pull request #237 from jan-cerny/pylint_erro..." - OpenSCAP/openscap-report - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 4c53b2...a46e16 )

by Matthew

created 2024-06-26 20:41 UTC

fixture_parser() B

↳ Parent: tests.unit_tests.test_oval_items_parser

Complexity

Conditions

Size

Total Lines	76
Code Lines	64

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	64
nop	0
dl	0
loc	76
rs	8.1781
c	0
b	0
f	0

How to fix Long Method

# Copyright 2024, Red Hat, Inc.
# SPDX-License-Identifier: LGPL-2.1-or-later

import pytest
from lxml import etree

from openscap_report.scap_results_parser.namespaces import NAMESPACES
from openscap_report.scap_results_parser.parsers.oval_items_parser import \
    OVALItemsParser


# pylint: disable = too-many-locals
@pytest.fixture(name="parser")
def fixture_parser():
    sc_ns = NAMESPACES["oval-characteristics"]
    is_ns = NAMESPACES["ind-sys"]

    o1_id = "oval:example:obj:1"
    o2_id = "oval:example:obj:2"
    o3_id = "oval:example:obj:3"
    i1_id = "11117777"
    i2_id = "11117777"
    i3_id = "33339999"

    o1 = etree.Element(
        "{%s}object" % sc_ns, nsmap=NAMESPACES, id=o1_id, version="1",
        flag="complete")
    o1_r1 = etree.Element(
        "{%s}reference" % sc_ns, nsmap=NAMESPACES, item_ref=i1_id)
    o1.append(o1_r1)

    o2 = etree.Element(
        "{%s}object" % sc_ns, nsmap=NAMESPACES, id=o2_id, version="1",
        flag="complete")
    o2_r1 = etree.Element(
        "{%s}reference" % sc_ns, nsmap=NAMESPACES, item_ref=i2_id)
    o2.append(o2_r1)
    o2_r2 = etree.Element(
        "{%s}reference" % sc_ns, nsmap=NAMESPACES, item_ref=i3_id)
    o2.append(o2_r2)

    o3 = etree.Element(
        "{%s}object" % sc_ns, nsmap=NAMESPACES, id=o3_id, version="1",
        flag="does not exist")

    collected_objects = {
        o1_id: o1,
        o2_id: o2,
        o3_id: o3
    }

    i1 = etree.Element(
        "{%s}textfilecontent_item" % is_ns, nsmap=NAMESPACES, id=i1_id,
        status="exists")
    i1_filepath = etree.Element("{%s}filepath" % is_ns, nsmap=NAMESPACES)
    i1_filepath.text = "/var/cities"
    i1.append(i1_filepath)
    i1_text = etree.Element("{%s}text" % is_ns, nsmap=NAMESPACES)
    i1_text.text = "Paris"
    i1.append(i1_text)

    i2 = etree.Element(
        "{%s}textfilecontent_item" % is_ns, nsmap=NAMESPACES, id=i2_id,
        status="exists")
    i2_filepath = etree.Element("{%s}filepath" % is_ns, nsmap=NAMESPACES)
    i2_filepath.text = "/var/cities"
    i2.append(i2_filepath)
    i2_text = etree.Element("{%s}text" % is_ns, nsmap=NAMESPACES)
    i2_text.text = "London"
    i2.append(i2_text)

    i3 = etree.Element(
        "{%s}textfilecontent_item" % is_ns, nsmap=NAMESPACES, id=i3_id,
        status="exists")
    i3_filepath = etree.Element("{%s}filepath" % is_ns, nsmap=NAMESPACES)
    i3_filepath.text = "/var/cities"
    i3.append(i3_filepath)
    i3_text = etree.Element("{%s}text" % is_ns, nsmap=NAMESPACES)
    i3_text.text = "Prague"
    i3.append(i3_text)

    system_data = {
        i1_id: i1,
        i2_id: i2,
        i3_id: i3,
    }

    return OVALItemsParser(collected_objects, system_data)


@pytest.mark.unit_test
def test_oval_items_parser_single(parser):
    oi = parser.get_oval_items("oval:example:obj:1")
    assert oi is not None
    assert oi.header == ("filepath", "text")
    assert len(oi.entries) == 1
    assert oi.entries[0] == ("/var/cities", "London")


@pytest.mark.unit_test
def test_oval_items_parser_multiple(parser):
    oi = parser.get_oval_items("oval:example:obj:2")
    assert oi is not None
    assert oi.header == ("filepath", "text")
    assert len(oi.entries) == 2
    assert oi.entries[0] == ("/var/cities", "London")
    assert oi.entries[1] == ("/var/cities", "Prague")


@pytest.mark.unit_test
def test_oval_items_parser_dne(parser):
    oi = parser.get_oval_items("oval:example:obj:3")
    assert oi is None


@pytest.mark.unit_test
def test_oval_items_parser_wrong_object_id(parser):
    oi = parser.get_oval_items("oval:example:obj:666")
    assert oi is None


1			# Copyright 2024, Red Hat, Inc.
2			# SPDX-License-Identifier: LGPL-2.1-or-later
3
4			import pytest
5			from lxml import etree
6
7			from openscap_report.scap_results_parser.namespaces import NAMESPACES
8			from openscap_report.scap_results_parser.parsers.oval_items_parser import \
9			OVALItemsParser
10
11
12			# pylint: disable = too-many-locals
13			@pytest.fixture(name="parser")
14			def fixture_parser():
15			sc_ns = NAMESPACES["oval-characteristics"]
16			is_ns = NAMESPACES["ind-sys"]
17
18			o1_id = "oval:example:obj:1"
19			o2_id = "oval:example:obj:2"
20			o3_id = "oval:example:obj:3"
21			i1_id = "11117777"
22			i2_id = "11117777"
23			i3_id = "33339999"
24
25			o1 = etree.Element(
26			"{%s}object" % sc_ns, nsmap=NAMESPACES, id=o1_id, version="1",
27			flag="complete")
28			o1_r1 = etree.Element(
29			"{%s}reference" % sc_ns, nsmap=NAMESPACES, item_ref=i1_id)
30			o1.append(o1_r1)
31
32			o2 = etree.Element(
33			"{%s}object" % sc_ns, nsmap=NAMESPACES, id=o2_id, version="1",
34			flag="complete")
35			o2_r1 = etree.Element(
36			"{%s}reference" % sc_ns, nsmap=NAMESPACES, item_ref=i2_id)
37			o2.append(o2_r1)
38			o2_r2 = etree.Element(
39			"{%s}reference" % sc_ns, nsmap=NAMESPACES, item_ref=i3_id)
40			o2.append(o2_r2)
41
42			o3 = etree.Element(
43			"{%s}object" % sc_ns, nsmap=NAMESPACES, id=o3_id, version="1",
44			flag="does not exist")
45
46			collected_objects = {
47			o1_id: o1,
48			o2_id: o2,
49			o3_id: o3
50			}
51
52			i1 = etree.Element(
53			"{%s}textfilecontent_item" % is_ns, nsmap=NAMESPACES, id=i1_id,
54			status="exists")
55			i1_filepath = etree.Element("{%s}filepath" % is_ns, nsmap=NAMESPACES)
56			i1_filepath.text = "/var/cities"
57			i1.append(i1_filepath)
58			i1_text = etree.Element("{%s}text" % is_ns, nsmap=NAMESPACES)
59			i1_text.text = "Paris"
60			i1.append(i1_text)
61
62			i2 = etree.Element(
63			"{%s}textfilecontent_item" % is_ns, nsmap=NAMESPACES, id=i2_id,
64			status="exists")
65			i2_filepath = etree.Element("{%s}filepath" % is_ns, nsmap=NAMESPACES)
66			i2_filepath.text = "/var/cities"
67			i2.append(i2_filepath)
68			i2_text = etree.Element("{%s}text" % is_ns, nsmap=NAMESPACES)
69			i2_text.text = "London"
70			i2.append(i2_text)
71
72			i3 = etree.Element(
73			"{%s}textfilecontent_item" % is_ns, nsmap=NAMESPACES, id=i3_id,
74			status="exists")
75			i3_filepath = etree.Element("{%s}filepath" % is_ns, nsmap=NAMESPACES)
76			i3_filepath.text = "/var/cities"
77			i3.append(i3_filepath)
78			i3_text = etree.Element("{%s}text" % is_ns, nsmap=NAMESPACES)
79			i3_text.text = "Prague"
80			i3.append(i3_text)
81
82			system_data = {
83			i1_id: i1,
84			i2_id: i2,
85			i3_id: i3,
86			}
87
88			return OVALItemsParser(collected_objects, system_data)
89
90
91			@pytest.mark.unit_test
92			def test_oval_items_parser_single(parser):
93			oi = parser.get_oval_items("oval:example:obj:1")
94			assert oi is not None
95			assert oi.header == ("filepath", "text")
96			assert len(oi.entries) == 1
97			assert oi.entries[0] == ("/var/cities", "London")
98
99
100			@pytest.mark.unit_test
101			def test_oval_items_parser_multiple(parser):
102			oi = parser.get_oval_items("oval:example:obj:2")
103			assert oi is not None
104			assert oi.header == ("filepath", "text")
105			assert len(oi.entries) == 2
106			assert oi.entries[0] == ("/var/cities", "London")
107			assert oi.entries[1] == ("/var/cities", "Prague")
108
109
110			@pytest.mark.unit_test
111			def test_oval_items_parser_dne(parser):
112			oi = parser.get_oval_items("oval:example:obj:3")
113			assert oi is None
114
115
116			@pytest.mark.unit_test
117			def test_oval_items_parser_wrong_object_id(parser):
118			oi = parser.get_oval_items("oval:example:obj:666")
119			assert oi is None
120

OpenSCAP / openscap-report

Push — main ( 4c53b2...a46e16 )

fixture_parser() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like