OpenROV / openrov-cockpit

src/plugins/about/index.js

const bluebird = require('bluebird');

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

const Listener = require('Listener');

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

const execFile = require('child_process').execFile;

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

var logger;
//private functions


function execAsync(command,args){
    return new bluebird(function(resolve,reject){
        return execFile(command,args,function(error,stdout,stderr){
            if (error){
                 resolve(JSON.stringify(error));
            }
            resolve(stdout,stderr);
        })

There should be a semicolon.

    })

There should be a semicolon.

}

function getpsAux() {
    return execAsync('ps',['aux']);
}

function getFree() {
    return execAsync('free',[]);
}

function getDF() {
    return execAsync('df',[]);
}

function getJournalCTL() {
    return execAsync('journalctl',['-o json']);
}

function getROVImageVersion(){
    return execAsync('cat',['/ROV-Suite-version'])

There should be a semicolon.

}

class About {

'class' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

    constructor(name, deps) {
        logger = deps.logger;
        logger.info("Loaded About plugin");

        this.globalBus = deps.globalEventLoop; // This is the server-side messaging bus. The MCU sends messages to server plugins over this
        this.cockpitBus = deps.cockpit; // This is the server<->client messaging bus. This is how the server talks to the browser
        this.loopDelays = [];
        this.notifications = [];
        this.deps=deps;
        var self = this;

        this.listeners = {
            settings: new Listener(self.globalBus, 'settings-change.about', true, function(settings) {
                self.settings = settings.about;
            }),

            loopDelays: new Listener(self.globalBus, 'plugin.host-diagnostics.loopDelay', false, function(delay){
                self.loopDelays.push({timestamp:Date.now(),delay:delay});
                if (self.loopDelays.length==99){
                    self.globalBus.emit('notification','The ROV embedded computer has been struggling to process messages.');
                }
                if (self.loopDelays.length==100){
                    self.loopDelays.shift();
                }
            }),

            notifications: new Listener(self.globalBus, 'plugin.notification.all-notices', false, function(notices){
                self.notifications=notices;
            }),

            dumpReport: new Listener(self.cockpitBus, 'plugin.about.dumpReport', false, function(callback) {
                var report={}

There should be a semicolon.

                getpsAux()
                .then (function(stdout,stderr){
                    report.ps=stdout;
                    trace("ps:"+stdout);
                })
                .then (function(){
                    report.loopDelays=self.loopDelays;
                    report.notifications = self.notifications;
                    report.config=self.deps.config;
                })
                .then (getFree)
                .then (function(stdout,stderr){
                    report.free = stdout;
                })
                .then (getDF)
                .then (function(stdout,stderr){
                    report.df = stdout;
                })   
                .then (getJournalCTL)
                .then (function(stdout,stderr){
                    report.journalctl = stdout;
                })     
                .then (getROVImageVersion)
                .then (function(stdout,stderr){
                    report.rovImageVersion = stdout;
                })                                          
                .then (function(){
                    callback(JSON.stringify(report));
                })                

There should be a semicolon.

            })
        }

There should be a semicolon.

    }

    start() {
        // Enable the listeners!
        this.listeners.settings.enable();
        this.listeners.loopDelays.enable();
        this.listeners.notifications.enable();
        this.listeners.dumpReport.enable();
    }

    // This is called when the plugin is disabled
    stop() {
        // Disable listeners
        this.listeners.settings.disable();
        this.listeners.loopDelays.disable();
        this.listeners.notifications.disable();        
        this.listeners.dumpReprot.disable();
    }    

}

module.exports = function(name, deps) {
    return new About(name, deps);
};