OpenROV / openrov-cockpit

src/lib/logger.js

'use strict'

There should be a semicolon.

var dir = __dirname;

__dirname does not seem to be defined.

function Logger(options) {

var pino = require('pino');

require does not seem to be defined.

//var pretty = pino.pretty()
//pretty.pipe(process.stdout)
var log = pino(options);//,pretty);
var loggers = [log];
//AOP: Inject trace behavior in all function calls
/* Should this be handled by an external jstrace instead?
(function () {
  var oldCall = Function.prototype.call;
  var newCall = function(self) {
    Function.prototype.call = oldCall;
    if (this.name){
      log.trace('Function called:', this.name);
    }
    var args = Array.prototype.slice.call(arguments, 1);
    var res = this.apply(self, args);
    Function.prototype.call = newCall;
    return res
  }
  Function.prototype.call = newCall;
})();
*/

const Arborsculpt = require('pino-arborsculpture')

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

There should be a semicolon.

require does not seem to be defined.

const arbor = new Arborsculpt({

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

  path: dir+'/adjustments.json',
  loggers: loggers, //Will this capture children as well? If not we will need Arborsculpt entries for them as well.
  interval: 60000 // the default
})

There should be a semicolon.

log._tagged = true;
log.info('monitoring ',  dir+'/adjustments.json', ' for logging adjustments.');

arbor.on('error', function (err) {
  log.error(err,'there was a problem reading the file or setting the level');
})

There should be a semicolon.

log.on('level-change', function(lvl, val, prevLvl, prevVal){
  if  ((prevLvl !== undefined) && (lvl!==prevLvl)){
    this[lvl](`logging level changed from ${prevLvl} to ${lvl}`);

'template literal syntax' is only available in ES6 (use 'esversion: 6').

  }
  if (!this._tagged){
    //this is the first time we have seen the logger, it could be a child.
    this._tagged = true;
    loggers.push(this);
  }
})

There should be a semicolon.

log.monitor=function(logger,path){
    var childArbor = new Arborsculpt({
      path: path,
      loggers: [logger], //Will this capture children as well? If not we will need Arborsculpt entries for them as well.
      interval: 60000 // the default
    })  

There should be a semicolon.

}

There should be a semicolon.

return log;
}


module.exports = Logger;

module does not seem to be defined.