Surfnet\StepupSelfService\SelfServiceBundle\Controller\LocaleController::switchLocaleAction()

Complexity

Conditions	6
Paths	5

Size

Total Lines	57
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    #[Route(
        path: '/switch-locale',
        name: 'ss_switch_locale',
        requirements: ['return-url' => '.+'],
        methods: ['POST']
    )]
    public function switchLocale(Request $request): \Symfony\Component\HttpFoundation\RedirectResponse

Missing doc comment for function switchLocale()

    {
        $returnUrl = $request->query->get('return-url');

        // Return URLs generated by us always include a path (ie. at least a forward slash)
        // @see https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/Request.php#L878
        $domain = $request->getSchemeAndHttpHost() . '/';
        if (!str_starts_with($returnUrl, $domain)) {
            $this->get('logger')->error(sprintf(

The method get() does not exist on Surfnet\StepupSelfService\SelfServiceBundle\Controller\LocaleController.

The opening parenthesis of a multi-line function call should be the last content on the line.

                'Identity "%s" used illegal return-url for redirection after changing locale, aborting request',
                $this->getIdentity()->id
            ));

For multi-line function calls, the closing parenthesis should be on a new line.

            throw new BadRequestHttpException('Invalid return-url given');
        }

        /** @var LoggerInterface $logger */

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

        $logger = $this->get('logger');
        $logger->info('Switching locale...');

        $identity = $this->getIdentity();
        if (!$identity) {

$identity is of type Surfnet\StepupMiddlewareClientBundle\Identity\Dto\Identity, thus it always evaluated to true.

            throw new AccessDeniedHttpException('Cannot switch locales when not authenticated');
        }

        $command = new SwitchLocaleCommand();
        $command->identityId = $identity->id;

        $form = $this->createForm(
            SwitchLocaleType::class,
            $command,
            ['route' => 'ss_switch_locale', 'route_parameters' => ['return_url' => $returnUrl]]
        );
        $form->handleRequest($request);

        if (!$form->isSubmitted() || !$form->isValid()) {
            $this->addFlash('error', $this->get('translator')->trans('ss.flash.invalid_switch_locale_form'));
            $logger->error('The switch locale form unexpectedly contained invalid data');
            return $this->redirect($returnUrl);
        }

        $service = $this->get('self_service.service.identity');
        if (!$service->switchLocale($command)) {
            $this->addFlash('error', $this->get('translator')->trans('ss.flash.error_while_switching_locale'));
            $logger->error('An error occurred while switching locales');
            return $this->redirect($returnUrl);
        }

        $logger->info('Successfully switched locale');

        return $this->redirect($returnUrl);
    }