Surfnet\StepupSelfService\SelfServiceBundle\Controller\RegistrationController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	105
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes	4
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	displaySecondFactorTypesAction()	0	11	1
A	emailVerificationEmailSentAction()	0	4	1
A	verifyEmailAction()	0	23	3
B	registrationEmailSentAction()	0	45	2

<?php

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupSelfService\SelfServiceBundle\Controller;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Surfnet\StepupSelfService\SelfServiceBundle\Service\InstitutionConfigurationOptionsService;
use Surfnet\StepupSelfService\SelfServiceBundle\Service\RaLocationService;
use Surfnet\StepupSelfService\SelfServiceBundle\Service\SecondFactorService;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class RegistrationController extends Controller
{
    /**
     * @Template
     */
    public function displaySecondFactorTypesAction()
    {
        $enabledSecondFactors = $this->getParameter('ss.enabled_second_factors');

        return [
            'commonName' => $this->getIdentity()->commonName,
            'enabledSecondFactors' => array_combine($enabledSecondFactors, $enabledSecondFactors),
            'tiqrAppAndroidUrl' => $this->getParameter('tiqr_app_android_url'),
            'tiqrAppIosUrl'     => $this->getParameter('tiqr_app_ios_url'),
        ];
    }

    /**
     * @Template
     */
    public function emailVerificationEmailSentAction()
    {
        return ['email' => $this->getIdentity()->email];
    }

    /**
     * @Template
     *
     * @param Request $request
     * @return array|\Symfony\Component\HttpFoundation\RedirectResponse
     */
    public function verifyEmailAction(Request $request)
    {
        $nonce = $request->query->get('n', '');
        $identityId = $this->getIdentity()->id;

        /** @var SecondFactorService $service */
        $service = $this->get('surfnet_stepup_self_service_self_service.service.second_factor');

        $secondFactor = $service->findUnverifiedByVerificationNonce($identityId, $nonce);

        if ($secondFactor === null) {
            throw new NotFoundHttpException('No second factor can be verified using this URL.');
        }

        if ($service->verifyEmail($identityId, $nonce)) {
            return $this->redirectToRoute(
                'ss_registration_registration_email_sent',
                ['secondFactorId' => $secondFactor->id]
            );
        }

        return [];
    }

    /**
     * @param $secondFactorId
     * @return array|Response
     */
    public function registrationEmailSentAction($secondFactorId)
    {
        $identity = $this->getIdentity();

        /** @var SecondFactorService $secondFactorService */
        $secondFactorService = $this->get('surfnet_stepup_self_service_self_service.service.second_factor');

        /** @var \Surfnet\StepupSelfService\SelfServiceBundle\Service\RaService $raService */
        $raService = $this->get('self_service.service.ra');

        /** @var InstitutionConfigurationOptionsService $institutionConfigurationOptionsService */
        $institutionConfigurationOptionsService = $this->get('self_service.service.institution_configuration_options');

The variable name $institutionConfigurationOptionsService exceeds the maximum configured length of 30.

        /** @var RaLocationService $raLocationService */
        $raLocationService = $this->get('self_service.service.ra_location');

        $templatingEngine = $this->get('templating');

        $institutionConfigurationOptions = $institutionConfigurationOptionsService

The variable name $institutionConfigurationOptions exceeds the maximum configured length of 30.

            ->getInstitutionConfigurationOptionsFor($identity->institution);

        if ($institutionConfigurationOptions->useRaLocations) {
            return new Response(
                $templatingEngine->render(
                    'SurfnetStepupSelfServiceSelfServiceBundle:Registration:registrationEmailSentWithRaLocations.html.twig',

This line exceeds maximum limit of 120 characters; contains 124 characters

                    [
                        'email'            => $this->getIdentity()->email,
                        'registrationCode' => $secondFactorService->getRegistrationCode($secondFactorId, $identity->id),
                        'raLocations'      => $raLocationService->listRaLocationsFor($identity->institution),
                    ]
                )
            );
        }

        return new Response(
            $templatingEngine->render(
                'SurfnetStepupSelfServiceSelfServiceBundle:Registration:registrationEmailSentWithRas.html.twig',
                [
                    'email'            => $this->getIdentity()->email,
                    'registrationCode' => $secondFactorService->getRegistrationCode($secondFactorId, $identity->id),
                    'ras'              => $raService->listRas($identity->institution),
                ]
            )
        );
    }
}