Surfnet\StepupSelfService\SelfServiceBundle\Controller\SecondFactor\SecondFactorListController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	41	4
A	__construct()	0	8	1

<?php

declare(strict_types = 1);

/**
 * Copyright 2023 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

PHP version not specified

Missing @category tag in file comment

Missing @package tag in file comment

Missing @author tag in file comment

Missing @license tag in file comment

Missing @link tag in file comment

namespace Surfnet\StepupSelfService\SelfServiceBundle\Controller\SecondFactor;

use Surfnet\StepupBundle\DateTime\RegistrationExpirationHelper;
use Surfnet\StepupBundle\Service\SecondFactorTypeService;
use Surfnet\StepupSelfService\SelfServiceBundle\Service\AuthorizationService;
use Surfnet\StepupSelfService\SelfServiceBundle\Service\InstitutionConfigurationOptionsService;
use Surfnet\StepupSelfService\SelfServiceBundle\Service\SecondFactorService;
use Surfnet\StepupSelfService\SelfServiceBundle\Service\SelfAssertedTokens\RecoveryTokenService;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Attribute\Route;

class SecondFactorListController extends AbstractController

Missing doc comment for class SecondFactorListController

{
    public function __construct(

Missing doc comment for function __construct()

        private readonly InstitutionConfigurationOptionsService $configurationOptionsService,
        private readonly RecoveryTokenService    $recoveryTokenService,
        private readonly AuthorizationService    $authorizationService,
        private readonly SecondFactorTypeService $secondFactorTypeService,
        private readonly SecondFactorService $secondFactorService,
        private readonly RegistrationExpirationHelper $registrationExpirationHelper,
    ) {
    }

    #[Route(path: '/overview', name: 'ss_second_factor_list', methods:  ['GET'])]
    public function __invoke(): Response

Missing doc comment for function __invoke()

    {
        $identity = $this->getUser()->getIdentity();

The method getIdentity() does not exist on Symfony\Component\Security\Core\User\UserInterface. It seems like you code against a sub-type of Symfony\Component\Security\Core\User\UserInterface such as Surfnet\StepupSelfService\SelfServiceBundle\Security\Authentication\AuthenticatedIdentity.

        $institution = $identity->institution;
        $options = $this->configurationOptionsService
            ->getInstitutionConfigurationOptionsFor($institution);

        // Get all available second factors from the config.
        $allSecondFactors = $this->getParameter('ss.enabled_second_factors');

        $secondFactors = $this->secondFactorService->getSecondFactorsForIdentity(
            $identity,
            $allSecondFactors,
            $options->allowedSecondFactors,
            $options->numberOfTokensPerIdentity
        );

        $recoveryTokensAllowed = $this->authorizationService->mayRegisterRecoveryTokens($identity);
        $selfAssertedTokenRegistration = $options->allowSelfAssertedTokens === true && $recoveryTokensAllowed;
        $hasRemainingTokenTypes = $this->recoveryTokenService->getRemainingTokenTypes($identity) !== [];
        $recoveryTokens = [];
        if ($selfAssertedTokenRegistration && $recoveryTokensAllowed) {
            $recoveryTokens = $this->recoveryTokenService->getRecoveryTokensForIdentity($identity);
        }
        $loaService = $this->secondFactorTypeService;

        return $this->render('second_factor/list.html.twig',

The opening parenthesis of a multi-line function call should be the last content on the line.

            [
                'loaService' => $loaService,
                'email' => $identity->email,
                'maxNumberOfTokens' => $secondFactors->getMaximumNumberOfRegistrations(),
                'registrationsLeft' => $secondFactors->getRegistrationsLeft(),
                'unverifiedSecondFactors' => $secondFactors->unverified,
                'verifiedSecondFactors' => $secondFactors->verified,
                'vettedSecondFactors' => $secondFactors->vetted,
                'availableSecondFactors' => $secondFactors->available,
                'expirationHelper' => $this->registrationExpirationHelper,
                'selfAssertedTokenRegistration' => $selfAssertedTokenRegistration,
                'recoveryTokens' => $recoveryTokens,
                'hasRemainingRecoveryTokens' => $hasRemainingTokenTypes,
            ]
        );
    }
}