Surfnet\StepupSelfService\SelfServiceBundle\Controller\Registration\YubikeyController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	provePossession()	0	48	7

<?php

declare(strict_types = 1);

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

PHP version not specified

Missing @category tag in file comment

Missing @package tag in file comment

Missing @author tag in file comment

Missing @license tag in file comment

Missing @link tag in file comment

namespace Surfnet\StepupSelfService\SelfServiceBundle\Controller\Registration;

use Symfony\Bridge\Twig\Attribute\Template;
use Surfnet\StepupSelfService\SelfServiceBundle\Command\VerifyYubikeyOtpCommand;
use Surfnet\StepupSelfService\SelfServiceBundle\Controller\Controller;
use Surfnet\StepupSelfService\SelfServiceBundle\Form\Type\ProveYubikeyPossessionType;
use Surfnet\StepupSelfService\SelfServiceBundle\Service\YubikeySecondFactorService;
use Symfony\Component\Form\FormError;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Routing\Attribute\Route;

class YubikeyController extends Controller

Missing doc comment for class YubikeyController

{
    #[Template('registration/yubikey/prove_possession.html.twig')]
    #[Route(
        path: '/registration/yubikey/prove-possession',
        name: 'ss_registration_yubikey_prove_possession',
        methods: ['GET','POST'],
    )]
    public function provePossession(Request $request): \Symfony\Component\HttpFoundation\RedirectResponse|array

Missing doc comment for function provePossession()

    {
        $this->assertSecondFactorEnabled('yubikey');

        $identity = $this->getIdentity();

        $command = new VerifyYubikeyOtpCommand();
        $command->identity = $identity->id;
        $command->institution = $identity->institution;

        $form = $this->createForm(ProveYubikeyPossessionType::class, $command)->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {
            /** @var YubikeySecondFactorService $service */

The open comment tag must be the only content on the line

The close comment tag must be the only content on the line

Missing short description in doc comment

            $service = $this->get('surfnet_stepup_self_service_self_service.service.yubikey_second_factor');

The method get() does not exist on Surfnet\StepupSelfService\SelfServiceBundle\Controller\Registration\YubikeyController.

            $result = $service->provePossession($command);

            if ($result->isSuccessful()) {
                if ($this->emailVerificationIsRequired()) {
                    return $this->redirectToRoute(
                        'ss_registration_email_verification_email_sent',
                        ['secondFactorId' => $result->getSecondFactorId()]
                    );
                } else {
                    return $this->redirectToRoute(
                        'ss_second_factor_vetting_types',
                        ['secondFactorId' => $result->getSecondFactorId()]
                    );
                }
            } elseif ($result->isOtpInvalid()) {
                $this->addFlash('error', 'ss.verify_yubikey_command.otp.otp_invalid');
            } elseif ($result->didOtpVerificationFail()) {
                $this->addFlash('error', 'ss.verify_yubikey_command.otp.verification_error');
            } else {
                $this->addFlash('error', 'ss.prove_yubikey_possession.proof_of_possession_failed');
            }
        }

        // OTP field is rendered empty in the template.
        return [
            'form' => $form->createView(),
            'verifyEmail' => $this->emailVerificationIsRequired(),
        ];
    }
}