SecondFactorService::getSecondFactorsForIdentity() - Code Metrics - Inspection of "Release of new version 2.7.2" - OpenConext/Stepup-SelfService - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 53601d...990ac1 )

unknown

created 2018-03-15 08:51 UTC

SecondFactorService::getSecondFactorsForIdentity() B

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	28
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	28
rs	8.8571
cc	2
eloc	20
nc	2
nop	4

<?php

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupSelfService\SelfServiceBundle\Service;

use Surfnet\StepupMiddlewareClient\Identity\Dto\UnverifiedSecondFactorSearchQuery;
use Surfnet\StepupMiddlewareClient\Identity\Dto\VerifiedSecondFactorSearchQuery;
use Surfnet\StepupMiddlewareClient\Identity\Dto\VettedSecondFactorSearchQuery;
use Surfnet\StepupMiddlewareClientBundle\Identity\Command\RevokeOwnSecondFactorCommand;
use Surfnet\StepupMiddlewareClientBundle\Identity\Command\VerifyEmailCommand;
use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\UnverifiedSecondFactor;
use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\UnverifiedSecondFactorCollection;
use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\VerifiedSecondFactor;
use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\VerifiedSecondFactorCollection;
use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\VettedSecondFactor;
use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\VettedSecondFactorCollection;
use Surfnet\StepupMiddlewareClientBundle\Identity\Service\SecondFactorService as MiddlewareSecondFactorService;
use Surfnet\StepupSelfService\SelfServiceBundle\Command\RevokeCommand;
use Surfnet\StepupSelfService\SelfServiceBundle\Exception\LogicException;

/**
 * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
 */
class SecondFactorService
{
    /**
     * @var \Surfnet\StepupMiddlewareClientBundle\Identity\Service\SecondFactorService
     */
    private $secondFactors;

    /**
     * @var \Surfnet\StepupSelfService\SelfServiceBundle\Service\CommandService
     */
    private $commandService;

    /**
     * @var \Surfnet\StepupSelfService\SelfServiceBundle\Service\U2fSecondFactorService
     */
    private $u2fSecondFactorService;

    /**
     * @param MiddlewareSecondFactorService $secondFactors
     * @param CommandService                $commandService
     * @param U2fSecondFactorService        $u2fSecondFactorService
     */
    public function __construct(
        MiddlewareSecondFactorService $secondFactors,
        CommandService $commandService,
        U2fSecondFactorService $u2fSecondFactorService
    ) {
        $this->secondFactors = $secondFactors;
        $this->commandService = $commandService;
        $this->u2fSecondFactorService = $u2fSecondFactorService;
    }

    /**
     * @param string $identityId
     * @param string $nonce
     * @return bool
     */
    public function verifyEmail($identityId, $nonce)
    {
        $command                    = new VerifyEmailCommand();
        $command->identityId        = $identityId;
        $command->verificationNonce = $nonce;

        $result = $this->commandService->execute($command);

        return $result->isSuccessful();
    }

    /**
     * @param RevokeCommand $command
     * @return bool
     */
    public function revoke(RevokeCommand $command)
    {
        /** @var UnverifiedSecondFactor|VerifiedSecondFactor|VettedSecondFactor $secondFactor */
        $secondFactor = $command->secondFactor;

        $apiCommand = new RevokeOwnSecondFactorCommand();
        $apiCommand->identityId = $command->identity->id;
        $apiCommand->secondFactorId = $secondFactor->id;

        $result = $this->commandService->execute($apiCommand);

        if ($secondFactor->type === 'u2f') {
            $this->u2fSecondFactorService->revokeRegistration(
                $command->identity,
                $secondFactor->secondFactorIdentifier
            );
        }

        return $result->isSuccessful();
    }

    /**
     * Returns whether the given registrant has registered second factors with Step-up. The state of the second factor
     * is irrelevant.
     *
     * @param string $identityId
     * @return bool
     */
    public function doSecondFactorsExistForIdentity($identityId)
    {
        $unverifiedSecondFactors = $this->findUnverifiedByIdentity($identityId);
        $verifiedSecondFactors = $this->findVerifiedByIdentity($identityId);
        $vettedSecondFactors = $this->findVettedByIdentity($identityId);

        return $unverifiedSecondFactors->getTotalItems() +
               $verifiedSecondFactors->getTotalItems() +
               $vettedSecondFactors->getTotalItems() > 0;
    }

    public function identityHasSecondFactorOfStateWithId($identityId, $state, $secondFactorId)
    {
        switch ($state) {
            case 'unverified':
                $secondFactors = $this->findUnverifiedByIdentity($identityId);
                break;
            case 'verified':
                $secondFactors = $this->findVerifiedByIdentity($identityId);
                break;
            case 'vetted':
                $secondFactors = $this->findVettedByIdentity($identityId);
                break;
            default:
                throw new LogicException(sprintf('Invalid second factor state "%s" given.', $state));
        }

        if (count($secondFactors->getElements()) === 0) {
            return false;
        }

        foreach ($secondFactors->getElements() as $secondFactor) {
            if ($secondFactor->id === $secondFactorId) {
                return true;
            }
        }

        return false;
    }

    /**
     * Returns the given registrant's unverified second factors.
     *
     * @param string $identityId
     * @return UnverifiedSecondFactorCollection

     */
    public function findUnverifiedByIdentity($identityId)
    {
        return $this->secondFactors->searchUnverified(
            (new UnverifiedSecondFactorSearchQuery())->setIdentityId($identityId)
        );
    }

    /**
     * Returns the given registrant's verified second factors.
     *
     * @param string $identityId
     * @return VerifiedSecondFactorCollection

     */
    public function findVerifiedByIdentity($identityId)
    {
        return $this->secondFactors->searchVerified(
            (new VerifiedSecondFactorSearchQuery())->setIdentityId($identityId)
        );
    }

    /**
     * Returns the given registrant's verified second factors.
     *
     * @param string $identityId
     * @return VettedSecondFactorCollection

     */
    public function findVettedByIdentity($identityId)
    {
        return $this->secondFactors->searchVetted(
            (new VettedSecondFactorSearchQuery())->setIdentityId($identityId)
        );
    }

    /**
     * @param string $secondFactorId
     * @return null|UnverifiedSecondFactor
     */
    public function findOneUnverified($secondFactorId)
    {
        return $this->secondFactors->getUnverified($secondFactorId);
    }

    /**
     * @param string $secondFactorId
     * @return null|VerifiedSecondFactor
     */
    public function findOneVerified($secondFactorId)
    {
        return $this->secondFactors->getVerified($secondFactorId);
    }

    /**
     * @param string $secondFactorId
     * @return null|VettedSecondFactor
     */
    public function findOneVetted($secondFactorId)
    {
        return $this->secondFactors->getVetted($secondFactorId);
    }

    /**
     * @param string $identityId
     * @param string $verificationNonce
     * @return UnverifiedSecondFactor|null
     */
    public function findUnverifiedByVerificationNonce($identityId, $verificationNonce)

    {
        $secondFactors = $this->secondFactors->searchUnverified(
            (new UnverifiedSecondFactorSearchQuery())
                ->setIdentityId($identityId)
                ->setVerificationNonce($verificationNonce)
        );

        $elements = $secondFactors->getElements();

        switch (count($elements)) {
            case 0:
                return null;
            case 1:
                return reset($elements);
            default:
                throw new LogicException('There cannot be more than one unverified second factor with the same nonce');
        }
    }

    /**
     * @param string $secondFactorId
     * @param string $identityId
     * @return null|string
     */
    public function getRegistrationCode($secondFactorId, $identityId)

    {
        $query = (new VerifiedSecondFactorSearchQuery())
            ->setIdentityId($identityId)
            ->setSecondFactorId($secondFactorId);

        /** @var VerifiedSecondFactor[] $verifiedSecondFactors */
        $verifiedSecondFactors = $this->secondFactors->searchVerified($query)->getElements();

        switch (count($verifiedSecondFactors)) {
            case 0:
                return null;
            case 1:
                return reset($verifiedSecondFactors)->registrationCode;
            default:
                throw new LogicException('Searching by second factor ID cannot result in multiple results.');
        }
    }
}


1		<?php
2
3		/**
4		* Copyright 2014 SURFnet bv
5		*
6		* Licensed under the Apache License, Version 2.0 (the "License");
7		* you may not use this file except in compliance with the License.
8		* You may obtain a copy of the License at
9		*
10		* http://www.apache.org/licenses/LICENSE-2.0
11		*
12		* Unless required by applicable law or agreed to in writing, software
13		* distributed under the License is distributed on an "AS IS" BASIS,
14		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15		* See the License for the specific language governing permissions and
16		* limitations under the License.
17		*/
18
19		namespace Surfnet\StepupSelfService\SelfServiceBundle\Service;
20
21		use Surfnet\StepupMiddlewareClient\Identity\Dto\UnverifiedSecondFactorSearchQuery;
22		use Surfnet\StepupMiddlewareClient\Identity\Dto\VerifiedSecondFactorSearchQuery;
23		use Surfnet\StepupMiddlewareClient\Identity\Dto\VettedSecondFactorSearchQuery;
24		use Surfnet\StepupMiddlewareClientBundle\Identity\Command\RevokeOwnSecondFactorCommand;
25		use Surfnet\StepupMiddlewareClientBundle\Identity\Command\VerifyEmailCommand;
26		use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\UnverifiedSecondFactor;
27		use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\UnverifiedSecondFactorCollection;
28		use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\VerifiedSecondFactor;
29		use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\VerifiedSecondFactorCollection;
30		use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\VettedSecondFactor;
31		use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\VettedSecondFactorCollection;
32		use Surfnet\StepupMiddlewareClientBundle\Identity\Service\SecondFactorService as MiddlewareSecondFactorService;
33		use Surfnet\StepupSelfService\SelfServiceBundle\Command\RevokeCommand;
34		use Surfnet\StepupSelfService\SelfServiceBundle\Exception\LogicException;
35
36		/**
37		* @SuppressWarnings(PHPMD.TooManyPublicMethods)
38		* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
39		*/
40		class SecondFactorService
41		{
42		/**
43		* @var \Surfnet\StepupMiddlewareClientBundle\Identity\Service\SecondFactorService
44		*/
45		private $secondFactors;
46
47		/**
48		* @var \Surfnet\StepupSelfService\SelfServiceBundle\Service\CommandService
49		*/
50		private $commandService;
51
52		/**
53		* @var \Surfnet\StepupSelfService\SelfServiceBundle\Service\U2fSecondFactorService
54		*/
55		private $u2fSecondFactorService;
56
57		/**
58		* @param MiddlewareSecondFactorService $secondFactors
59		* @param CommandService $commandService
60		* @param U2fSecondFactorService $u2fSecondFactorService
61		*/
62		public function __construct(
63		MiddlewareSecondFactorService $secondFactors,
64		CommandService $commandService,
65		U2fSecondFactorService $u2fSecondFactorService
66		) {
67		$this->secondFactors = $secondFactors;
68		$this->commandService = $commandService;
69		$this->u2fSecondFactorService = $u2fSecondFactorService;
70		}
71
72		/**
73		* @param string $identityId
74		* @param string $nonce
75		* @return bool
76		*/
77		public function verifyEmail($identityId, $nonce)
78		{
79		$command = new VerifyEmailCommand();
80		$command->identityId = $identityId;
81		$command->verificationNonce = $nonce;
82
83		$result = $this->commandService->execute($command);
84
85		return $result->isSuccessful();
86		}
87
88		/**
89		* @param RevokeCommand $command
90		* @return bool
91		*/
92		public function revoke(RevokeCommand $command)
93		{
94		/** @var UnverifiedSecondFactor\|VerifiedSecondFactor\|VettedSecondFactor $secondFactor */
95		$secondFactor = $command->secondFactor;
96
97		$apiCommand = new RevokeOwnSecondFactorCommand();
98		$apiCommand->identityId = $command->identity->id;
99		$apiCommand->secondFactorId = $secondFactor->id;
100
101		$result = $this->commandService->execute($apiCommand);
102
103		if ($secondFactor->type === 'u2f') {
104		$this->u2fSecondFactorService->revokeRegistration(
105		$command->identity,
106		$secondFactor->secondFactorIdentifier
107		);
108		}
109
110		return $result->isSuccessful();
111		}
112
113		/**
114		* Returns whether the given registrant has registered second factors with Step-up. The state of the second factor
115		* is irrelevant.
116		*
117		* @param string $identityId
118		* @return bool
119		*/
120		public function doSecondFactorsExistForIdentity($identityId)
121		{
122		$unverifiedSecondFactors = $this->findUnverifiedByIdentity($identityId);
123		$verifiedSecondFactors = $this->findVerifiedByIdentity($identityId);
124		$vettedSecondFactors = $this->findVettedByIdentity($identityId);
125
126		return $unverifiedSecondFactors->getTotalItems() +
127		$verifiedSecondFactors->getTotalItems() +
128		$vettedSecondFactors->getTotalItems() > 0;
129		}
130
131		public function identityHasSecondFactorOfStateWithId($identityId, $state, $secondFactorId)
132		{
133		switch ($state) {
134		case 'unverified':
135		$secondFactors = $this->findUnverifiedByIdentity($identityId);
136		break;
137		case 'verified':
138		$secondFactors = $this->findVerifiedByIdentity($identityId);
139		break;
140		case 'vetted':
141		$secondFactors = $this->findVettedByIdentity($identityId);
142		break;
143		default:
144		throw new LogicException(sprintf('Invalid second factor state "%s" given.', $state));
145		}
146
147		if (count($secondFactors->getElements()) === 0) {
148		return false;
149		}
150
151		foreach ($secondFactors->getElements() as $secondFactor) {
152		if ($secondFactor->id === $secondFactorId) {
153		return true;
154		}
155		}
156
157		return false;
158		}
159
160		/**
161		* Returns the given registrant's unverified second factors.
162		*
163		* @param string $identityId
164		* @return UnverifiedSecondFactorCollection
		0 ignored issues – show Documentation introduced 2015-12-15 13:40 UTC by Report Bug Copy Issue Report Should the return type not be `UnverifiedSecondFactorCollection\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
165		*/
166		public function findUnverifiedByIdentity($identityId)
167		{
168		return $this->secondFactors->searchUnverified(
169		(new UnverifiedSecondFactorSearchQuery())->setIdentityId($identityId)
170		);
171		}
172
173		/**
174		* Returns the given registrant's verified second factors.
175		*
176		* @param string $identityId
177		* @return VerifiedSecondFactorCollection
		0 ignored issues – show Documentation introduced 2015-12-15 13:40 UTC by Report Bug Copy Issue Report Should the return type not be `VerifiedSecondFactorCollection\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
178		*/
179		public function findVerifiedByIdentity($identityId)
180		{
181		return $this->secondFactors->searchVerified(
182		(new VerifiedSecondFactorSearchQuery())->setIdentityId($identityId)
183		);
184		}
185
186		/**
187		* Returns the given registrant's verified second factors.
188		*
189		* @param string $identityId
190		* @return VettedSecondFactorCollection
		0 ignored issues – show Documentation introduced 2015-12-15 13:40 UTC by Report Bug Copy Issue Report Should the return type not be `VettedSecondFactorCollection\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
191		*/
192		public function findVettedByIdentity($identityId)
193		{
194		return $this->secondFactors->searchVetted(
195		(new VettedSecondFactorSearchQuery())->setIdentityId($identityId)
196		);
197		}
198
199		/**
200		* @param string $secondFactorId
201		* @return null\|UnverifiedSecondFactor
202		*/
203		public function findOneUnverified($secondFactorId)
204		{
205		return $this->secondFactors->getUnverified($secondFactorId);
206		}
207
208		/**
209		* @param string $secondFactorId
210		* @return null\|VerifiedSecondFactor
211		*/
212		public function findOneVerified($secondFactorId)
213		{
214		return $this->secondFactors->getVerified($secondFactorId);
215		}
216
217		/**
218		* @param string $secondFactorId
219		* @return null\|VettedSecondFactor
220		*/
221		public function findOneVetted($secondFactorId)
222		{
223		return $this->secondFactors->getVetted($secondFactorId);
224		}
225
226		/**
227		* @param string $identityId
228		* @param string $verificationNonce
229		* @return UnverifiedSecondFactor\|null
230		*/
231	View Code Duplication	public function findUnverifiedByVerificationNonce($identityId, $verificationNonce)
		0 ignored issues – show Duplication introduced 2017-08-01 07:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
232		{
233		$secondFactors = $this->secondFactors->searchUnverified(
234		(new UnverifiedSecondFactorSearchQuery())
235		->setIdentityId($identityId)
236		->setVerificationNonce($verificationNonce)
237		);
238
239		$elements = $secondFactors->getElements();
240
241		switch (count($elements)) {
242		case 0:
243		return null;
244		case 1:
245		return reset($elements);
246		default:
247		throw new LogicException('There cannot be more than one unverified second factor with the same nonce');
248		}
249		}
250
251		/**
252		* @param string $secondFactorId
253		* @param string $identityId
254		* @return null\|string
255		*/
256	View Code Duplication	public function getRegistrationCode($secondFactorId, $identityId)
		0 ignored issues – show Duplication introduced 2017-08-01 07:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
257		{
258		$query = (new VerifiedSecondFactorSearchQuery())
259		->setIdentityId($identityId)
260		->setSecondFactorId($secondFactorId);
261
262		/** @var VerifiedSecondFactor[] $verifiedSecondFactors */
263		$verifiedSecondFactors = $this->secondFactors->searchVerified($query)->getElements();
264
265		switch (count($verifiedSecondFactors)) {
266		case 0:
267		return null;
268		case 1:
269		return reset($verifiedSecondFactors)->registrationCode;
270		default:
271		throw new LogicException('Searching by second factor ID cannot result in multiple results.');
272		}
273		}
274		}
275

OpenConext / Stepup-SelfService

Push — master ( 53601d...990ac1 )

SecondFactorService::getSecondFactorsForIdentity() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like