Surfnet\StepupSelfService\SelfServiceBundle\Service\SecondFactorAvailabilityHelper

Complexity

Total Complexity

4

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	filter()	0	14	3
A	__construct()	0	2	1

<?php

declare(strict_types = 1);

/**
 * Copyright 2023 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

PHP version not specified

Missing @category tag in file comment

Missing @package tag in file comment

Missing @author tag in file comment

Missing @license tag in file comment

Missing @link tag in file comment

namespace Surfnet\StepupSelfService\SelfServiceBundle\Service;

use Surfnet\StepupBundle\Value\Provider\ViewConfigCollection;
use Surfnet\StepupSelfService\SamlStepupProviderBundle\Provider\ViewConfig;
use Surfnet\StepupSelfService\SelfServiceBundle\Value\AvailableTokenCollection;

readonly class SecondFactorAvailabilityHelper

Missing doc comment for class SecondFactorAvailabilityHelper

{
    public function __construct(private ViewConfigCollection $viewConfigCollection)

Missing doc comment for function __construct()

    {
    }
    // Based on a list of available SF types for the current identity
    // Return a more specific list of available tokens (ordered on gssp or built in
    // Used by the view to create a UI overview for registering different tokens
    public function filter(SecondFactorTypeCollection $secondFactors): AvailableTokenCollection

You must use "/**" style comments for a function comment

    {
        $availableGsspSecondFactors = [];
        foreach ($secondFactors->available as $index => $secondFactor) {
            if ($this->viewConfigCollection->isGssp($secondFactor)) {
                /** @var ViewConfig $secondFactorConfig */

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

                $secondFactorConfig = $this->viewConfigCollection->getByIdentifier($secondFactor);
                $availableGsspSecondFactors[$index] = $secondFactorConfig;
                // Remove the gssp second factors from the regular second factors.
                unset($secondFactors->available[$index]);
            }
        }

        return AvailableTokenCollection::from($secondFactors->available, $availableGsspSecondFactors);
    }
}