Passed
Pull Request — main (#308)
by Paul
25:26 queued 18:28
created
StepupSelfService/SelfServiceBundle/Controller/SecondFactorController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 /**
6 6
  * Copyright 2014 SURFnet bv
@@ -102,9 +102,9 @@  discard block
 block discarded – undo
102 102
         path: '/second-factor/{state}/{secondFactorId}/revoke',
103 103
         name: 'ss_second_factor_revoke',
104 104
         requirements: ['state' => '^(unverified|verified|vetted)$'],
105
-        methods: ['GET','POST']
105
+        methods: ['GET', 'POST']
106 106
     )]
107
-    public function revoke(Request $request, string $state, string $secondFactorId): array|Response
107
+    public function revoke(Request $request, string $state, string $secondFactorId): array | Response
108 108
     {
109 109
         $identity = $this->getIdentity();
110 110
 
Please login to merge, or discard this patch.
SelfServiceBundle/Controller/Registration/SmsController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 /**
6 6
  * Copyright 2014 SURFnet bv
@@ -48,9 +48,9 @@  discard block
 block discarded – undo
48 48
     #[Route(
49 49
         path: '/registration/sms/send-challenge',
50 50
         name: 'ss_registration_sms_send_challenge',
51
-        methods: ['GET','POST'],
51
+        methods: ['GET', 'POST'],
52 52
     )]
53
-    public function sendChallenge(Request $request): array|RedirectResponse
53
+    public function sendChallenge(Request $request): array | RedirectResponse
54 54
     {
55 55
         $this->assertSecondFactorEnabled('sms');
56 56
 
@@ -92,9 +92,9 @@  discard block
 block discarded – undo
92 92
     #[Route(
93 93
         path: '/registration/sms/prove-possession',
94 94
         name: 'ss_registration_sms_prove_possession',
95
-        methods: ['GET','POST'],
95
+        methods: ['GET', 'POST'],
96 96
     )]
97
-    public function provePossession(Request $request): RedirectResponse|array
97
+    public function provePossession(Request $request): RedirectResponse | array
98 98
     {
99 99
         $this->assertSecondFactorEnabled('sms');
100 100
 
Please login to merge, or discard this patch.
SelfServiceBundle/Controller/Registration/GssfController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 /**
6 6
  * Copyright 2014 SURFnet bv
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
     #[Route(
84 84
         path: '/registration/gssf/{provider}/status',
85 85
         name: 'ss_registration_gssf_status_report',
86
-        defaults: ['authenticationFailed' => false, 'proofOfPossessionFailed'=> false ],
86
+        defaults: ['authenticationFailed' => false, 'proofOfPossessionFailed'=> false],
87 87
         methods: ['GET'],
88 88
     )]
89 89
 
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
         name: 'ss_registration_gssf_authenticate',
106 106
         methods: ['POST'],
107 107
     )]
108
-    public function authenticate(string $provider): array|Response
108
+    public function authenticate(string $provider): array | Response
109 109
     {
110 110
         $this->assertSecondFactorEnabled($provider);
111 111
 
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
         name: 'ss_registration_gssf_consume_assertion',
140 140
         methods: ['POST'],
141 141
     )]
142
-    public function consumeAssertion(Request $httpRequest, string $provider): array|Response
142
+    public function consumeAssertion(Request $httpRequest, string $provider): array | Response
143 143
     {
144 144
         $this->assertSecondFactorEnabled($provider);
145 145
 
Please login to merge, or discard this patch.
SelfServiceBundle/Controller/Registration/YubikeyController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 /**
6 6
  * Copyright 2014 SURFnet bv
@@ -35,9 +35,9 @@  discard block
 block discarded – undo
35 35
     #[Route(
36 36
         path: '/registration/yubikey/prove-possession',
37 37
         name: 'ss_registration_yubikey_prove_possession',
38
-        methods: ['GET','POST'],
38
+        methods: ['GET', 'POST'],
39 39
     )]
40
-    public function provePossession(Request $request): \Symfony\Component\HttpFoundation\RedirectResponse|array
40
+    public function provePossession(Request $request): \Symfony\Component\HttpFoundation\RedirectResponse | array
41 41
     {
42 42
         $this->assertSecondFactorEnabled('yubikey');
43 43
 
Please login to merge, or discard this patch.
SelfServiceBundle/Controller/SelfAssertedTokensController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 /**
6 6
  * Copyright 2022 SURFnet B.V.
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
     #[Route(
148 148
         path: '/second-factor/{secondFactorId}/self-asserted-token-registration/{recoveryTokenId}',
149 149
         name: 'ss_second_factor_self_asserted_tokens_recovery_token',
150
-        methods: ['GET','POST']
150
+        methods: ['GET', 'POST']
151 151
     )]
152 152
     public function selfAssertedTokenRegistrationRecoveryToken(
153 153
         Request $request,
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
     #[Route(
272 272
         path: '/second-factor/{secondFactorId}/self-asserted-token-registration/{recoveryTokenId}/authenticate',
273 273
         name: 'ss_second_factor_self_asserted_tokens_recovery_token_sms',
274
-        methods: ['GET','POST']
274
+        methods: ['GET', 'POST']
275 275
     )]
276 276
     public function selfAssertedTokenRecoveryTokenSmsAuthentication(
277 277
         Request $request,
@@ -344,7 +344,7 @@  discard block
 block discarded – undo
344 344
     #[Route(
345 345
         path: '/second-factor/{secondFactorId}/safe-store',
346 346
         name: 'ss_registration_recovery_token_safe_store',
347
-        methods: ['GET','POST']
347
+        methods: ['GET', 'POST']
348 348
     )]
349 349
     public function registerCreateRecoveryTokenSafeStore(Request $request, string $secondFactorId): Response
350 350
     {
@@ -389,7 +389,7 @@  discard block
 block discarded – undo
389 389
     #[Route(
390 390
         path: '/second-factor/{secondFactorId}/sms',
391 391
         name: 'ss_registration_recovery_token_sms',
392
-        methods: ['GET','POST'],
392
+        methods: ['GET', 'POST'],
393 393
     )]
394 394
     public function registerRecoveryTokenSms(Request $request, string $secondFactorId): Response
395 395
     {
Please login to merge, or discard this patch.
StepupSelfService/SelfServiceBundle/Controller/RegistrationController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 /**
6 6
  * Copyright 2014 SURFnet bv
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
         name: 'ss_registration_display_types',
61 61
         methods: ['GET'],
62 62
     )]
63
-    public function displaySecondFactorTypes(): Response|array
63
+    public function displaySecondFactorTypes(): Response | array
64 64
     {
65 65
         $institution = $this->getIdentity()->institution;
66 66
         $institutionConfigurationOptions = $this->configurationOptionsService
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
         name: 'ss_second_factor_vetting_types',
101 101
         methods:  ['GET'],
102 102
     )]
103
-    public function displayVettingTypes(Request $request, string $secondFactorId): array|Response
103
+    public function displayVettingTypes(Request $request, string $secondFactorId): array | Response
104 104
     {
105 105
         /**
106 106
          * @var VettingTypeService
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
         name: 'ss_registration_verify_email',
176 176
         methods: ['GET'],
177 177
     )]
178
-    public function verifyEmail(Request $request): RedirectResponse|array
178
+    public function verifyEmail(Request $request): RedirectResponse | array
179 179
     {
180 180
         $nonce = $request->query->get('n', '');
181 181
         $identityId = $this->getIdentity()->id;
Please login to merge, or discard this patch.
SamlStepupProviderBundle/Provider/MetadataFactoryCollection.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 /**
6 6
  * Copyright 2013 SURFnet bv
Please login to merge, or discard this patch.
DependencyInjection/SurfnetStepupSelfServiceSamlStepupProviderExtension.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 /**
6 6
  * Copyright 2014 SURFnet bv
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
     {
53 53
         $configuration = new Configuration();
54 54
         $config = $this->processConfiguration($configuration, $configs);
55
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
55
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
56 56
         $loader->load('services.yml');
57 57
 
58 58
         foreach ($config['providers'] as $provider => $providerConfiguration) {
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
         $hostedDefinition = $this->buildHostedEntityDefinition($provider, $configuration, $routes);
159 159
         $container->setDefinition('gssp.provider.' . $provider . '.hosted_entities', $hostedDefinition);
160 160
 
161
-        $hostedSpDefinition  = (new Definition())
161
+        $hostedSpDefinition = (new Definition())
162 162
             ->setClass(\Surfnet\SamlBundle\Entity\ServiceProvider::class)
163 163
             ->setFactory([
164 164
                 new Reference('gssp.provider.' . $provider . '.hosted_entities'),
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
 
197 197
     private function createRemoteDefinition(string $provider, array $configuration, ContainerBuilder $container): void
198 198
     {
199
-        $definition    = new Definition(IdentityProvider::class, [
199
+        $definition = new Definition(IdentityProvider::class, [
200 200
             [
201 201
                 'entityId'        => $configuration['entity_id'],
202 202
                 'ssoUrl'          => $configuration['sso_url'],
@@ -257,14 +257,14 @@  discard block
 block discarded – undo
257 257
 
258 258
     private function validateDescriptions($descriptions, $appUrl, string $provider, string $type): void
259 259
     {
260
-        $regex ="/%%{$type}_link_start%%[a-zA-Z0-9 ]+%%{$type}_link_end%%/";
260
+        $regex = "/%%{$type}_link_start%%[a-zA-Z0-9 ]+%%{$type}_link_end%%/";
261 261
         foreach ($descriptions as $lang => $description) {
262 262
             if ($appUrl !== false && preg_match($regex, (string) $description) === 0) {
263 263
                 throw new InvalidConfigurationException(
264 264
                     sprintf(
265 265
                         'You have configured a GSSP provider with app URL\'s but the description is not ' .
266 266
                         'configured correctly yet. Missing "%%%1$s_link_start%%" or "%%%1$s_link_end%%" in ' .
267
-                        'GSSP description for language "%2$s" in "providers.%3$s.view_config.description" of '.
267
+                        'GSSP description for language "%2$s" in "providers.%3$s.view_config.description" of ' .
268 268
                         'samlstepupproviders.yml',
269 269
                         $type,
270 270
                         $lang,
Please login to merge, or discard this patch.
StepupSelfService/SelfServiceBundle/Service/GsspUserAttributeService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 /**
6 6
  * Copyright 2021 SURFnet B.V.
Please login to merge, or discard this patch.