Passed
Push — feature/symfony6-upgrade ( 76f00a...ba8023 )
by Michiel
06:58
created
public/index.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,8 +17,8 @@
 block discarded – undo
17 17
 
18 18
 use Surfnet\StepupSelfService\Kernel;
19 19
 
20
-require_once dirname(__DIR__).'/vendor/autoload_runtime.php';
20
+require_once dirname(__DIR__) . '/vendor/autoload_runtime.php';
21 21
 
22
-return function (array $context) {
22
+return function(array $context) {
23 23
     return new Kernel($context['APP_ENV'], (bool) $context['APP_DEBUG']);
24 24
 };
Please login to merge, or discard this patch.
SelfServiceBundle/Controller/Registration/GssfController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
     #[Route(
55 55
         path: '/registration/gssf/{provider}/status',
56 56
         name: 'ss_registration_gssf_status_report',
57
-        defaults: ['authenticationFailed' => false, 'proofOfPossessionFailed'=> false ],
57
+        defaults: ['authenticationFailed' => false, 'proofOfPossessionFailed'=> false],
58 58
         methods: ['GET'],
59 59
     )]
60 60
 
Please login to merge, or discard this patch.
StepupSelfService/SelfServiceBundle/Controller/SecondFactorController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -96,9 +96,9 @@
 block discarded – undo
96 96
         path: '/second-factor/{state}/{secondFactorId}/revoke',
97 97
         name: 'ss_second_factor_revoke',
98 98
         requirements: ['state' => '^(unverified|verified|vetted)$'],
99
-        methods: ['GET','POST']
99
+        methods: ['GET', 'POST']
100 100
     )]
101
-    public function revoke(Request $request, string $state, string $secondFactorId): array|Response
101
+    public function revoke(Request $request, string $state, string $secondFactorId): array | Response
102 102
     {
103 103
         $identity = $this->getIdentity();
104 104
 
Please login to merge, or discard this patch.
SelfServiceBundle/Controller/Registration/YubikeyController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,9 +35,9 @@
 block discarded – undo
35 35
     #[Route(
36 36
         path: '/registration/yubikey/prove-possession',
37 37
         name: 'ss_registration_yubikey_prove_possession',
38
-        methods: ['GET','POST'],
38
+        methods: ['GET', 'POST'],
39 39
     )]
40
-    public function provePossession(Request $request): \Symfony\Component\HttpFoundation\RedirectResponse|array
40
+    public function provePossession(Request $request): \Symfony\Component\HttpFoundation\RedirectResponse | array
41 41
     {
42 42
         $this->assertSecondFactorEnabled('yubikey');
43 43
 
Please login to merge, or discard this patch.
SelfServiceBundle/Controller/Registration/SmsController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -37,9 +37,9 @@  discard block
 block discarded – undo
37 37
     #[Route(
38 38
         path: '/registration/sms/send-challenge',
39 39
         name: 'ss_registration_sms_send_challenge',
40
-        methods: ['GET','POST'],
40
+        methods: ['GET', 'POST'],
41 41
     )]
42
-    public function sendChallenge(Request $request): array|\Symfony\Component\HttpFoundation\RedirectResponse
42
+    public function sendChallenge(Request $request): array | \Symfony\Component\HttpFoundation\RedirectResponse
43 43
     {
44 44
         $this->assertSecondFactorEnabled('sms');
45 45
 
@@ -84,9 +84,9 @@  discard block
 block discarded – undo
84 84
     #[Route(
85 85
         path: '/registration/sms/prove-possession',
86 86
         name: 'ss_registration_sms_prove_possession',
87
-        methods: ['GET','POST'],
87
+        methods: ['GET', 'POST'],
88 88
     )]
89
-    public function provePossession(Request $request): \Symfony\Component\HttpFoundation\RedirectResponse|array
89
+    public function provePossession(Request $request): \Symfony\Component\HttpFoundation\RedirectResponse | array
90 90
     {
91 91
         $this->assertSecondFactorEnabled('sms');
92 92
 
Please login to merge, or discard this patch.
DependencyInjection/SurfnetStepupSelfServiceSamlStepupProviderExtension.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
     {
50 50
         $configuration = new Configuration();
51 51
         $config = $this->processConfiguration($configuration, $configs);
52
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
52
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
53 53
         $loader->load('services.yml');
54 54
 
55 55
         foreach ($config['providers'] as $provider => $providerConfiguration) {
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
         $hostedDefinition = $this->buildHostedEntityDefinition($provider, $configuration, $routes);
155 155
         $container->setDefinition('gssp.provider.' . $provider . '.hosted_entities', $hostedDefinition);
156 156
 
157
-        $hostedSpDefinition  = (new Definition())
157
+        $hostedSpDefinition = (new Definition())
158 158
             ->setClass(\Surfnet\SamlBundle\Entity\ServiceProvider::class)
159 159
             ->setFactory([
160 160
                 new Reference('gssp.provider.' . $provider . '.hosted_entities'),
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 
193 193
     private function createRemoteDefinition(string $provider, array $configuration, ContainerBuilder $container): void
194 194
     {
195
-        $definition    = new Definition(IdentityProvider::class, [
195
+        $definition = new Definition(IdentityProvider::class, [
196 196
             [
197 197
                 'entityId'        => $configuration['entity_id'],
198 198
                 'ssoUrl'          => $configuration['sso_url'],
@@ -249,14 +249,14 @@  discard block
 block discarded – undo
249 249
 
250 250
     private function validateDescriptions($descriptions, $appUrl, string $provider, string $type): void
251 251
     {
252
-        $regex ="/%%{$type}_link_start%%[a-zA-Z0-9 ]+%%{$type}_link_end%%/";
252
+        $regex = "/%%{$type}_link_start%%[a-zA-Z0-9 ]+%%{$type}_link_end%%/";
253 253
         foreach ($descriptions as $lang => $description) {
254 254
             if ($appUrl !== false && preg_match($regex, (string) $description) === 0) {
255 255
                 throw new InvalidConfigurationException(
256 256
                     sprintf(
257 257
                         'You have configured a GSSP provider with app URL\'s but the description is not ' .
258 258
                         'configured correctly yet. Missing "%%%1$s_link_start%%" or "%%%1$s_link_end%%" in ' .
259
-                        'GSSP description for language "%2$s" in "providers.%3$s.view_config.description" of '.
259
+                        'GSSP description for language "%2$s" in "providers.%3$s.view_config.description" of ' .
260 260
                         'samlstepupproviders.yml',
261 261
                         $type,
262 262
                         $lang,
Please login to merge, or discard this patch.
SelfServiceBundle/Controller/SelfAssertedTokensController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
     #[Route(
146 146
         path: '/second-factor/{secondFactorId}/self-asserted-token-registration/{recoveryTokenId}',
147 147
         name: 'ss_second_factor_self_asserted_tokens_recovery_token',
148
-        methods: ['GET','POST']
148
+        methods: ['GET', 'POST']
149 149
     )]
150 150
     public function selfAssertedTokenRegistrationRecoveryToken(
151 151
         Request $request,
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
     #[Route(
270 270
         path: '/second-factor/{secondFactorId}/self-asserted-token-registration/{recoveryTokenId}/authenticate',
271 271
         name: 'ss_second_factor_self_asserted_tokens_recovery_token_sms',
272
-        methods: ['GET','POST']
272
+        methods: ['GET', 'POST']
273 273
     )]
274 274
     public function selfAssertedTokenRecoveryTokenSmsAuthentication(
275 275
         Request $request,
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
     #[Route(
343 343
         path: '/second-factor/{secondFactorId}/safe-store',
344 344
         name: 'ss_registration_recovery_token_safe_store',
345
-        methods: ['GET','POST']
345
+        methods: ['GET', 'POST']
346 346
     )]
347 347
     public function registerCreateRecoveryTokenSafeStore(Request $request, string $secondFactorId): Response
348 348
     {
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
     #[Route(
388 388
         path: '/second-factor/{secondFactorId}/sms',
389 389
         name: 'ss_registration_recovery_token_sms',
390
-        methods: ['GET','POST'],
390
+        methods: ['GET', 'POST'],
391 391
     )]
392 392
     public function registerRecoveryTokenSms(Request $request, string $secondFactorId): Response
393 393
     {
Please login to merge, or discard this patch.
SelfServiceBundle/Security/Authentication/Session/SessionStorage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
 
107 107
     public function hasRequestId(): bool
108 108
     {
109
-        return $this->requestStack->getSession()->has(self::SAML_SESSION_KEY. 'request_id');
109
+        return $this->requestStack->getSession()->has(self::SAML_SESSION_KEY . 'request_id');
110 110
     }
111 111
 
112 112
     public function clearRequestId(): void
Please login to merge, or discard this patch.
Security/Authentication/Handler/ProcessSamlAuthenticationHandler.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
         AuthenticationManagerInterface $authenticationManager,
53 53
         private readonly SamlAuthenticationLogger $authenticationLogger,
54 54
     ) {
55
-        $this->authenticationManager      = $authenticationManager;
55
+        $this->authenticationManager = $authenticationManager;
56 56
     }
57 57
 
58 58
     public function process(RequestEvent $event): void
Please login to merge, or discard this patch.