Surfnet\StepupSelfService\SelfServiceBundle\Security\Authentication\Session\SessionLifetimeGuard

Complexity

Total Complexity

9

Size/Duplication

Total Lines	69
Duplicated Lines	46.38 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	sessionLifetimeWithinLimits()	0	5	2
A	sessionLifetimeWithinAbsoluteLimit()	16	16	3
A	sessionLifetimeWithinRelativeLimit()	16	16	3

<?php

/**
 * Copyright 2016 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupSelfService\SelfServiceBundle\Security\Authentication\Session;

use Surfnet\StepupSelfService\SelfServiceBundle\Security\Authentication\AuthenticatedSessionStateHandler;
use Surfnet\StepupSelfService\SelfServiceBundle\Value\DateTime;
use Surfnet\StepupSelfService\SelfServiceBundle\Value\TimeFrame;

class SessionLifetimeGuard
{
    /**
     * @var TimeFrame
     */
    private $relativeTimeoutLimit;
    /**
     * @var TimeFrame
     */
    private $absoluteTimeoutLimit;

    public function __construct(TimeFrame $absoluteTimeoutLimit, TimeFrame $relativeTimeoutLimit)
    {
        $this->absoluteTimeoutLimit = $absoluteTimeoutLimit;
        $this->relativeTimeoutLimit = $relativeTimeoutLimit;
    }

    /**
     * @param AuthenticatedSessionStateHandler $sessionStateHandler
     * @return bool
     */
    public function sessionLifetimeWithinLimits(AuthenticatedSessionStateHandler $sessionStateHandler)
    {
        return $this->sessionLifetimeWithinAbsoluteLimit($sessionStateHandler)
                && $this->sessionLifetimeWithinRelativeLimit($sessionStateHandler);
    }

    /**
     * @param AuthenticatedSessionStateHandler $sessionStateHandler
     * @return bool
     */
    public function sessionLifetimeWithinAbsoluteLimit(AuthenticatedSessionStateHandler $sessionStateHandler)

This method seems to be duplicated in your project.

    {
        if (!$sessionStateHandler->isAuthenticationMomentLogged()) {
            return true;
        }

        $authenticationMoment = $sessionStateHandler->getAuthenticationMoment();
        $sessionTimeoutMoment = $this->absoluteTimeoutLimit->getEndWhenStartingAt($authenticationMoment);
        $now = DateTime::now();

        if ($now->comesBeforeOrIsEqual($sessionTimeoutMoment)) {

This if statement, and the following return statement can be replaced with return $now->comesBeforeOrIsEqual($sessionTimeoutMoment);.

            return true;
        }

        return false;
    }

    /**
     * @param AuthenticatedSessionStateHandler $sessionStateHandler
     * @return bool
     */
    public function sessionLifetimeWithinRelativeLimit(AuthenticatedSessionStateHandler $sessionStateHandler)

This method seems to be duplicated in your project.

    {
        if (!$sessionStateHandler->hasSeenInteraction()) {
            return true;
        }

        $lastInteractionMoment = $sessionStateHandler->getLastInteractionMoment();
        $sessionTimeoutMoment = $this->relativeTimeoutLimit->getEndWhenStartingAt($lastInteractionMoment);
        $now = DateTime::now();

        if ($now->comesBeforeOrIsEqual($sessionTimeoutMoment)) {

This if statement, and the following return statement can be replaced with return $now->comesBeforeOrIsEqual($sessionTimeoutMoment);.

            return true;
        }

        return false;
    }
}