Surfnet\StepupSelfService\SelfServiceBundle\Controller\SecurityController

Complexity

Total Complexity

1

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	sessionExpiredAction()	0	22	1

<?php

/**
 * Copyright 2016 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupSelfService\SelfServiceBundle\Controller;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;

class SecurityController extends Controller
{
    public function sessionExpiredAction(Request $request)

The parameter $request is not used and could be removed.

    {
        $redirectToUrl = $this
            ->get('self_service.security.authentication.session.session_storage')
            ->getCurrentRequestUri();

//        // Return URLs generated by us always include a path (ie. at least a forward slash)

49% of this comment could be valid code. Did you maybe forget this after debugging?

//        // @see https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/Request.php#L878
//        $domain = $request->getSchemeAndHttpHost() . '/';
//        if (strpos($redirectToUrl, $domain) !== 0) {
//            $this->get('logger')->error(
//                'Illegal return-url for redirection after session expired and user was logged out, aborting request'
//            );
//
//            throw new BadRequestHttpException('Invalid return-url given');
//        }

        return $this->render(
            '@SurfnetStepupSelfServiceSelfService/Security/sessionExpired.html.twig',
            ['redirect_to_url' => $redirectToUrl]
        );
    }
}