Surfnet\StepupSelfService\SelfServiceBundle\Controller\SecondFactor\SecondFactorRevokeController::__invoke()

Complexity

Conditions	6
Paths	5

Size

Total Lines	54
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    #[Template('second_factor/revoke.html.twig')]
    #[Route(
        path: '/second-factor/{state}/{secondFactorId}/revoke',
        name: 'ss_second_factor_revoke',
        requirements: ['state' => '^(unverified|verified|vetted)$'],
        methods: ['GET','POST']
    )]
    public function __invoke(Request $request, string $state, string $secondFactorId): array|Response

Missing doc comment for function __invoke()

    {
        $identity = $this->getUser()->getIdentity();

The method getIdentity() does not exist on Symfony\Component\Security\Core\User\UserInterface. It seems like you code against a sub-type of Symfony\Component\Security\Core\User\UserInterface such as Surfnet\StepupSelfService\SelfServiceBundle\Security\Authentication\AuthenticatedIdentity.

        if (!$this->secondFactorService->identityHasSecondFactorOfStateWithId($identity->id, $state, $secondFactorId)) {
            $this->logger->error(sprintf(

The opening parenthesis of a multi-line function call should be the last content on the line.

                'Identity "%s" tried to revoke "%s" second factor "%s", but does not own that second factor',
                $identity->id,
                $state,
                $secondFactorId
            ));

For multi-line function calls, the closing parenthesis should be on a new line.

            throw new NotFoundHttpException();
        }

        $secondFactor = match ($state) {
            'unverified' => $this->secondFactorService->findOneUnverified($secondFactorId),
            'verified' => $this->secondFactorService->findOneVerified($secondFactorId),
            'vetted' => $this->secondFactorService->findOneVetted($secondFactorId),
            default => throw new LogicException('There are no other types of second factor.'),
        };

        if ($secondFactor === null) {
            throw new NotFoundHttpException(
                sprintf("No %s second factor with id '%s' exists.", $state, $secondFactorId)
            );
        }

        $command = new RevokeCommand();
        $command->identity = $identity;
        $command->secondFactor = $secondFactor;

        $form = $this->createForm(RevokeSecondFactorType::class, $command)->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {
            
            if ($this->secondFactorService->revoke($command)) {
                $this->addFlash('success', 'ss.second_factor.revoke.alert.revocation_successful');
            } else {
                $this->addFlash('error', 'ss.second_factor.revoke.alert.revocation_failed');
            }

            return $this->redirectToRoute('ss_second_factor_list');
        }

        return [
            'form'         => $form->createView(),
            'secondFactor' => $secondFactor,
        ];