Code Duplication - OpenConext/Stepup-SelfService - Measure and Improve Code Quality continuously with Scrutinizer

Code Duplication Length = 11-15 lines in 4 locations

src/Surfnet/StepupSelfService/SelfServiceBundle/Controller/Registration/GssfController.php 1 location



        $secondFactorId = $service->provePossession($this->getIdentity()->id, $provider->getName(), $gssfId);

        if ($secondFactorId) {
            $this->getLogger()->notice('GSSF possession has been proven successfully');

            if ($this->emailVerificationIsRequired()) {
                return $this->redirectToRoute(
                    'ss_registration_email_verification_email_sent',
                    ['secondFactorId' => $secondFactorId]
                );
            } else {
                return $this->redirectToRoute(
                    'ss_registration_registration_email_sent',
                    ['secondFactorId' => $secondFactorId]
                );
            }
        }

        $this->getLogger()->error('Unable to prove GSSF possession');


src/Surfnet/StepupSelfService/SelfServiceBundle/Controller/Registration/SmsController.php 1 location


            if ($result->isSuccessful()) {
                $service->clearSmsVerificationState();

                if ($this->emailVerificationIsRequired()) {
                    return $this->redirectToRoute(
                        'ss_registration_email_verification_email_sent',
                        ['secondFactorId' => $result->getSecondFactorId()]
                    );
                } else {
                    return $this->redirectToRoute(
                        'ss_registration_registration_email_sent',
                        ['secondFactorId' => $result->getSecondFactorId()]
                    );
                }
            } elseif ($result->wasIncorrectChallengeResponseGiven()) {
                $form->addError(new FormError('ss.prove_phone_possession.incorrect_challenge_response'));
            } elseif ($result->hasChallengeExpired()) {

src/Surfnet/StepupSelfService/SelfServiceBundle/Controller/Registration/U2fController.php 1 location


        $result = $service->provePossession($this->getIdentity(), $registerRequest, $registerResponse);

        if ($result->wasSuccessful()) {
            if ($this->emailVerificationIsRequired()) {
                return $this->redirectToRoute(
                    'ss_registration_email_verification_email_sent',
                    ['secondFactorId' => $result->getSecondFactorId()]
                );
            } else {
                return $this->redirectToRoute(
                    'ss_registration_registration_email_sent',
                    ['secondFactorId' => $result->getSecondFactorId()]
                );
            }
        } elseif ($result->didDeviceReportAnyError()) {
            $this->addFlash('error', 'ss.registration.u2f.alert.device_reported_an_error');
        } else {

src/Surfnet/StepupSelfService/SelfServiceBundle/Controller/Registration/YubikeyController.php 1 location


            $result = $service->provePossession($command);

            if ($result->isSuccessful()) {
                if ($this->emailVerificationIsRequired()) {
                    return $this->redirectToRoute(
                        'ss_registration_email_verification_email_sent',
                        ['secondFactorId' => $result->getSecondFactorId()]
                    );
                } else {
                    return $this->redirectToRoute(
                        'ss_registration_registration_email_sent',
                        ['secondFactorId' => $result->getSecondFactorId()]
                    );
                }
            } elseif ($result->isOtpInvalid()) {
                $form->get('otp')->addError(new FormError('ss.verify_yubikey_command.otp.otp_invalid'));
            } elseif ($result->didOtpVerificationFail()) {

		@@ 141-155 (lines=15) @@
138
139		$secondFactorId = $service->provePossession($this->getIdentity()->id, $provider->getName(), $gssfId);
140
141		if ($secondFactorId) {
142		$this->getLogger()->notice('GSSF possession has been proven successfully');
143
144		if ($this->emailVerificationIsRequired()) {
145		return $this->redirectToRoute(
146		'ss_registration_email_verification_email_sent',
147		['secondFactorId' => $secondFactorId]
148		);
149		} else {
150		return $this->redirectToRoute(
151		'ss_registration_registration_email_sent',
152		['secondFactorId' => $secondFactorId]
153		);
154		}
155		}
156
157		$this->getLogger()->error('Unable to prove GSSF possession');
158

		@@ 106-116 (lines=11) @@
103		if ($result->isSuccessful()) {
104		$service->clearSmsVerificationState();
105
106		if ($this->emailVerificationIsRequired()) {
107		return $this->redirectToRoute(
108		'ss_registration_email_verification_email_sent',
109		['secondFactorId' => $result->getSecondFactorId()]
110		);
111		} else {
112		return $this->redirectToRoute(
113		'ss_registration_registration_email_sent',
114		['secondFactorId' => $result->getSecondFactorId()]
115		);
116		}
117		} elseif ($result->wasIncorrectChallengeResponseGiven()) {
118		$form->addError(new FormError('ss.prove_phone_possession.incorrect_challenge_response'));
119		} elseif ($result->hasChallengeExpired()) {

		@@ 105-115 (lines=11) @@
102		$result = $service->provePossession($this->getIdentity(), $registerRequest, $registerResponse);
103
104		if ($result->wasSuccessful()) {
105		if ($this->emailVerificationIsRequired()) {
106		return $this->redirectToRoute(
107		'ss_registration_email_verification_email_sent',
108		['secondFactorId' => $result->getSecondFactorId()]
109		);
110		} else {
111		return $this->redirectToRoute(
112		'ss_registration_registration_email_sent',
113		['secondFactorId' => $result->getSecondFactorId()]
114		);
115		}
116		} elseif ($result->didDeviceReportAnyError()) {
117		$this->addFlash('error', 'ss.registration.u2f.alert.device_reported_an_error');
118		} else {

		@@ 51-61 (lines=11) @@
48		$result = $service->provePossession($command);
49
50		if ($result->isSuccessful()) {
51		if ($this->emailVerificationIsRequired()) {
52		return $this->redirectToRoute(
53		'ss_registration_email_verification_email_sent',
54		['secondFactorId' => $result->getSecondFactorId()]
55		);
56		} else {
57		return $this->redirectToRoute(
58		'ss_registration_registration_email_sent',
59		['secondFactorId' => $result->getSecondFactorId()]
60		);
61		}
62		} elseif ($result->isOtpInvalid()) {
63		$form->get('otp')->addError(new FormError('ss.verify_yubikey_command.otp.otp_invalid'));
64		} elseif ($result->didOtpVerificationFail()) {

OpenConext / Stepup-SelfService

Code Duplication Length = 11-15 lines in 4 locations

src/Surfnet/StepupSelfService/SelfServiceBundle/Controller/Registration/GssfController.php 1 location

src/Surfnet/StepupSelfService/SelfServiceBundle/Controller/Registration/SmsController.php 1 location

src/Surfnet/StepupSelfService/SelfServiceBundle/Controller/Registration/U2fController.php 1 location

src/Surfnet/StepupSelfService/SelfServiceBundle/Controller/Registration/YubikeyController.php 1 location