SamlListener::handleEvent() - Code Metrics - Inspection of "Merge branch 'release-2.x'" - OpenConext/Stepup-RA - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7f018f...75cfb8 )

by A.

created 2016-08-12 12:37 UTC

SamlListener::handleEvent() C

↳ Parent: Project

Complexity

Conditions	8
Paths	8

Size

Total Lines	85
Code Lines	49

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	85
c	1
b	0
f	0
rs	5.8037
cc	8
eloc	49
nc	8
nop	1

How to fix Long Method

<?php

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupRa\RaBundle\Security\Firewall;

use Exception;
use Psr\Log\LoggerInterface;
use Surfnet\StepupRa\RaBundle\Security\Authentication\Handler\AuthenticationHandler;
use Surfnet\StepupRa\RaBundle\Security\Authentication\SamlInteractionProvider;
use Symfony\Component\HttpKernel\Event\GetResponseEvent;
use Symfony\Component\Security\Core\Exception\AuthenticationException;
use Symfony\Component\Security\Http\Firewall\ListenerInterface;

/**
 * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
 */
class SamlListener implements ListenerInterface
{
    /**
     * @var AuthenticationHandler
     */
    private $authenticationHandler;

    /**
     * @var SamlInteractionProvider
     */
    private $samlInteractionProvider;

    /**
     * @var LoggerInterface
     */
    private $logger;

    public function __construct(
        AuthenticationHandler $authenticationHandler,
        SamlInteractionProvider $samlInteractionProvider,
        LoggerInterface $logger
    ) {
        $this->authenticationHandler = $authenticationHandler;
        $this->samlInteractionProvider = $samlInteractionProvider;
        $this->logger = $logger;
    }

    public function handle(GetResponseEvent $event)
    {
        try {
            $this->authenticationHandler->process($event);
        } catch (AuthenticationException $exception) {
            $this->samlInteractionProvider->reset();

            $this->logger->warning(sprintf(
                'Could not authenticate, AuthenticationException encountered: "%s"',
                $exception->getMessage()
            ));

            throw $exception;
        } catch (Exception $exception) {
            $this->samlInteractionProvider->reset();

            $this->logger->error(sprintf(
                'Could not authenticate, Exception of type "%s" encountered: %s',
                get_class($exception),
                $exception->getMessage()
            ));

            throw $exception;
        }
    }
}


1			<?php
2
3			/**
4			* Copyright 2014 SURFnet bv
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19			namespace Surfnet\StepupRa\RaBundle\Security\Firewall;
20
21			use Exception;
22			use Psr\Log\LoggerInterface;
23			use Surfnet\StepupRa\RaBundle\Security\Authentication\Handler\AuthenticationHandler;
24			use Surfnet\StepupRa\RaBundle\Security\Authentication\SamlInteractionProvider;
25			use Symfony\Component\HttpKernel\Event\GetResponseEvent;
26			use Symfony\Component\Security\Core\Exception\AuthenticationException;
27			use Symfony\Component\Security\Http\Firewall\ListenerInterface;
28
29			/**
30			* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
31			*/
32			class SamlListener implements ListenerInterface
33			{
34			/**
35			* @var AuthenticationHandler
36			*/
37			private $authenticationHandler;
38
39			/**
40			* @var SamlInteractionProvider
41			*/
42			private $samlInteractionProvider;
43
44			/**
45			* @var LoggerInterface
46			*/
47			private $logger;
48
49			public function __construct(
50			AuthenticationHandler $authenticationHandler,
51			SamlInteractionProvider $samlInteractionProvider,
52			LoggerInterface $logger
53			) {
54			$this->authenticationHandler = $authenticationHandler;
55			$this->samlInteractionProvider = $samlInteractionProvider;
56			$this->logger = $logger;
57			}
58
59			public function handle(GetResponseEvent $event)
60			{
61			try {
62			$this->authenticationHandler->process($event);
63			} catch (AuthenticationException $exception) {
64			$this->samlInteractionProvider->reset();
65
66			$this->logger->warning(sprintf(
67			'Could not authenticate, AuthenticationException encountered: "%s"',
68			$exception->getMessage()
69			));
70
71			throw $exception;
72			} catch (Exception $exception) {
73			$this->samlInteractionProvider->reset();
74
75			$this->logger->error(sprintf(
76			'Could not authenticate, Exception of type "%s" encountered: %s',
77			get_class($exception),
78			$exception->getMessage()
79			));
80
81			throw $exception;
82			}
83			}
84			}
85

OpenConext / Stepup-RA

Push — master ( 7f018f...75cfb8 )

SamlListener::handleEvent() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like