SamlToken::getInstitutionConfigurationOptions() - Code Metrics - Inspection of "Merge branch 'develop' into feature/add-institutio..." - OpenConext/Stepup-RA - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/add-institution-config... ( 9e78e8...c98478 )

by A.

created 2016-08-03 15:16 UTC

SamlToken::getInstitutionConfigurationOptions() A

↳ Parent: SamlToken

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupRa\RaBundle\Security\Authentication\Token;

use Surfnet\StepupBundle\Value\Loa;
use Surfnet\StepupMiddlewareClientBundle\Configuration\Dto\InstitutionConfigurationOptions;
use Symfony\Component\Security\Core\Authentication\Token\AbstractToken;

class SamlToken extends AbstractToken
{
    /**
     * @var \SAML2_Assertion
     */
    public $assertion;

    /**
     * @var \Surfnet\StepupBundle\Value\Loa
     */
    private $loa;

    /**
     * @var InstitutionConfigurationOptions
     */
    private $institutionConfigurationOptions;

    public function __construct(
        Loa $loa,
        array $roles = [],
        InstitutionConfigurationOptions $institutionConfigurationOptions = null

    ) {
        parent::__construct($roles);

        $this->loa = $loa;
        $this->institutionConfigurationOptions = $institutionConfigurationOptions;
        $this->setAuthenticated(count($roles));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @return InstitutionConfigurationOptions
     */
    public function getInstitutionConfigurationOptions()
    {
        return $this->institutionConfigurationOptions;
    }

    /**
     * Returns the user credentials.
     *
     * @return mixed The user credentials
     */
    public function getCredentials()
    {
        return '';
    }

    /**
     * @return Loa
     */
    public function getLoa()
    {
        return $this->loa;
    }

    public function serialize()
    {
        return serialize([parent::serialize(), $this->loa, $this->institutionConfigurationOptions]);
    }

    public function unserialize($serialized)
    {
        list($parent, $this->loa, $this->institutionConfigurationOptions) = unserialize($serialized);

        parent::unserialize($parent);
    }
}


1			<?php
2
3			/**
4			* Copyright 2014 SURFnet bv
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19			namespace Surfnet\StepupRa\RaBundle\Security\Authentication\Token;
20
21			use Surfnet\StepupBundle\Value\Loa;
22			use Surfnet\StepupMiddlewareClientBundle\Configuration\Dto\InstitutionConfigurationOptions;
23			use Symfony\Component\Security\Core\Authentication\Token\AbstractToken;
24
25			class SamlToken extends AbstractToken
26			{
27			/**
28			* @var \SAML2_Assertion
29			*/
30			public $assertion;
31
32			/**
33			* @var \Surfnet\StepupBundle\Value\Loa
34			*/
35			private $loa;
36
37			/**
38			* @var InstitutionConfigurationOptions
39			*/
40			private $institutionConfigurationOptions;
41
42			public function __construct(
43			Loa $loa,
44			array $roles = [],
45			InstitutionConfigurationOptions $institutionConfigurationOptions = null
			0 ignored issues – show Comprehensibility Naming introduced 2016-08-02 13:40 UTC by Report Bug Copy Issue Report The variable name `$institutionConfigurationOptions` exceeds the maximum configured length of `30`. Very long variable names usually make code harder to read. It is therefore recommended not to make variable names too verbose. Loading history...
46			) {
47			parent::__construct($roles);
48
49			$this->loa = $loa;
50			$this->institutionConfigurationOptions = $institutionConfigurationOptions;
51			$this->setAuthenticated(count($roles));
			0 ignored issues – show Documentation introduced 2015-12-15 13:46 UTC by Report Bug Copy Issue Report `count($roles)` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
52			}
53
54			/**
55			* @return InstitutionConfigurationOptions
56			*/
57			public function getInstitutionConfigurationOptions()
58			{
59			return $this->institutionConfigurationOptions;
60			}
61
62			/**
63			* Returns the user credentials.
64			*
65			* @return mixed The user credentials
66			*/
67			public function getCredentials()
68			{
69			return '';
70			}
71
72			/**
73			* @return Loa
74			*/
75			public function getLoa()
76			{
77			return $this->loa;
78			}
79
80			public function serialize()
81			{
82			return serialize([parent::serialize(), $this->loa, $this->institutionConfigurationOptions]);
83			}
84
85			public function unserialize($serialized)
86			{
87			list($parent, $this->loa, $this->institutionConfigurationOptions) = unserialize($serialized);
88
89			parent::unserialize($parent);
90			}
91			}
92

OpenConext / Stepup-RA

Push — feature/add-institution-config... ( 9e78e8...c98478 )

SamlToken::getInstitutionConfigurationOptions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like