Inspection of "Implement optional prove possession step" - OpenConext/Stepup-RA - Measure and Improve Code Quality continuously with Scrutinizer

Stepup-RA

Completed

Push — feature/ra-optional-vetting ( 23510f...388e27 )

unknown

created 2020-07-09 12:05 UTC

Status

All Patches
9
New
1

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -159,7 +159,7 @@  discard block
 block discarded – undo
 
     /**
      * @param StartVettingProcedureCommand $command
-     * @return bool
+     * @return null|boolean
      */
     public function isVettedImplicitly(StartVettingProcedureCommand $command)
     {
@@ -437,7 +437,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @param $procedureId
+     * @param string $procedureId
      * @return string
      * @throws UnknownVettingProcedureException
      */

Please login to merge, or discard this patch.

		@@ -159,7 +159,7 @@ discard block
		block discarded – undo
159	159
160	160	/**
161	161	* @param StartVettingProcedureCommand $command
162		- * @return bool
	162	+ * @return null\|boolean
163	163	*/
164	164	public function isVettedImplicitly(StartVettingProcedureCommand $command)
165	165	{
		@@ -437,7 +437,7 @@ discard block
		block discarded – undo
437	437	}
438	438
439	439	/**
440		- * @param $procedureId
	440	+ * @param string $procedureId
441	441	* @return string
442	442	* @throws UnknownVettingProcedureException
443	443	*/

OpenConext / Stepup-RA

Push — feature/ra-optional-vetting ( 23510f...388e27 )

Status

Category

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch