RaListingService::search() - Code Metrics - OpenConext/Stepup-RA - Measure and Improve Code Quality continuously with Scrutinizer

RaListingService::search() B
last analyzed 2021-02-03 08:59 UTC

↳ Parent: RaListingService

Complexity

Conditions	10
Paths	128

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	34
rs	7.4333
c	0
b	0
f	0
cc	10
nc	128
nop	1

How to fix Complexity

<?php

/**
 * Copyright 2019 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupRa\RaBundle\Service;

use Psr\Log\LoggerInterface;
use Surfnet\StepupMiddlewareClient\Identity\Dto\RaListingSearchQuery;
use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\RaListing;
use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\RaListingCollection;
use Surfnet\StepupMiddlewareClientBundle\Identity\Service\RaListingService as ApiRaListingService;
use Surfnet\StepupRa\RaBundle\Command\SearchRaListingCommand;
use Surfnet\StepupRa\RaBundle\Exception\InvalidArgumentException;

final class RaListingService
{
    /**
     * @var ApiRaListingService
     */
    private $apiRaListingService;

    /**
     * @var LoggerInterface
     */
    private $logger;

    public function __construct(ApiRaListingService $raListingService, LoggerInterface $logger)
    {
        $this->apiRaListingService = $raListingService;
        $this->logger = $logger;
    }

    /**
     * @SuppressWarnings(PHPMD.CyclomaticComplexity)  -- The command to query mapping in search exceed the
     * @SuppressWarnings(PHPMD.NPathComplexity)          CyclomaticComplexity and NPathComplexity threshold.
     *
     * @param SearchRaListingCommand $command
     * @return RaListingCollection
     */
    public function search(SearchRaListingCommand $command)
    {
        $query = new RaListingSearchQuery($command->actorId, $command->pageNumber);

        if ($command->name) {
            $query->setName($command->name);
        }

        if ($command->email) {
            $query->setEmail($command->email);
        }

        if ($command->institution) {
            $query->setInstitution($command->institution);
        }

        if ($command->roleAtInstitution && $command->roleAtInstitution->hasRole()) {
            $query->setRole($command->roleAtInstitution->getRole());
        }

        if ($command->roleAtInstitution && $command->roleAtInstitution->hasInstitution()) {
            $query->setRaInstitution($command->roleAtInstitution->getInstitution());
        }

        if ($command->orderBy) {
            $query->setOrderBy($command->orderBy);
        }

        if ($command->orderDirection) {
            $query->setOrderDirection($command->orderDirection);
        }

        return $this->apiRaListingService->search($query);
    }

    /**
     * @param string $identityId
     * @param string $institution
     * @param string $actorId
     * @return null|RaListing
     */
    public function get($identityId, $institution, $actorId)
    {
        if (!is_string($identityId)) {
            throw InvalidArgumentException::invalidType('string', 'identityId', $identityId);
        }

        if (!is_string($institution)) {
            throw InvalidArgumentException::invalidType('string', 'institution', $institution);
        }

        if (!is_string($actorId)) {
            throw InvalidArgumentException::invalidType('string', 'actorId', $actorId);
        }

        return $this->apiRaListingService->get($identityId, $institution, $actorId);
    }
}


1			<?php
2
3			/**
4			* Copyright 2019 SURFnet B.V.
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19			namespace Surfnet\StepupRa\RaBundle\Service;
20
21			use Psr\Log\LoggerInterface;
22			use Surfnet\StepupMiddlewareClient\Identity\Dto\RaListingSearchQuery;
23			use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\RaListing;
24			use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\RaListingCollection;
25			use Surfnet\StepupMiddlewareClientBundle\Identity\Service\RaListingService as ApiRaListingService;
26			use Surfnet\StepupRa\RaBundle\Command\SearchRaListingCommand;
27			use Surfnet\StepupRa\RaBundle\Exception\InvalidArgumentException;
28
29			final class RaListingService
30			{
31			/**
32			* @var ApiRaListingService
33			*/
34			private $apiRaListingService;
35
36			/**
37			* @var LoggerInterface
38			*/
39			private $logger;
40
41			public function __construct(ApiRaListingService $raListingService, LoggerInterface $logger)
42			{
43			$this->apiRaListingService = $raListingService;
44			$this->logger = $logger;
45			}
46
47			/**
48			* @SuppressWarnings(PHPMD.CyclomaticComplexity) -- The command to query mapping in search exceed the
49			* @SuppressWarnings(PHPMD.NPathComplexity) CyclomaticComplexity and NPathComplexity threshold.
50			*
51			* @param SearchRaListingCommand $command
52			* @return RaListingCollection
53			*/
54			public function search(SearchRaListingCommand $command)
55			{
56			$query = new RaListingSearchQuery($command->actorId, $command->pageNumber);
57
58			if ($command->name) {
59			$query->setName($command->name);
60			}
61
62			if ($command->email) {
63			$query->setEmail($command->email);
64			}
65
66			if ($command->institution) {
67			$query->setInstitution($command->institution);
68			}
69
70			if ($command->roleAtInstitution && $command->roleAtInstitution->hasRole()) {
71			$query->setRole($command->roleAtInstitution->getRole());
72			}
73
74			if ($command->roleAtInstitution && $command->roleAtInstitution->hasInstitution()) {
75			$query->setRaInstitution($command->roleAtInstitution->getInstitution());
76			}
77
78			if ($command->orderBy) {
79			$query->setOrderBy($command->orderBy);
80			}
81
82			if ($command->orderDirection) {
83			$query->setOrderDirection($command->orderDirection);
84			}
85
86			return $this->apiRaListingService->search($query);
87			}
88
89			/**
90			* @param string $identityId
91			* @param string $institution
92			* @param string $actorId
93			* @return null\|RaListing
94			*/
95			public function get($identityId, $institution, $actorId)
96			{
97			if (!is_string($identityId)) {
98			throw InvalidArgumentException::invalidType('string', 'identityId', $identityId);
99			}
100
101			if (!is_string($institution)) {
102			throw InvalidArgumentException::invalidType('string', 'institution', $institution);
103			}
104
105			if (!is_string($actorId)) {
106			throw InvalidArgumentException::invalidType('string', 'actorId', $actorId);
107			}
108
109			return $this->apiRaListingService->get($identityId, $institution, $actorId);
110			}
111			}
112

OpenConext / Stepup-RA

RaListingService::search() B last analyzed 2021-02-03 08:59 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

RaListingService::search() B
last analyzed 2021-02-03 08:59 UTC