Surfnet\StepupRa\RaBundle\Service\YubikeyService

Complexity

Total Complexity

8

Size/Duplication

Total Lines	67
Duplicated Lines	14.93 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	verify()	10	40	7

<?php

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupRa\RaBundle\Service;

use GuzzleHttp\Client;
use Psr\Log\LoggerInterface;
use Surfnet\StepupBundle\Http\JsonHelper;
use Surfnet\StepupRa\RaBundle\Command\VerifyYubikeyOtpCommand;

class YubikeyService
{
    /**
     * @var Client
     */
    private $guzzleClient;

    /**
     * @var LoggerInterface
     */
    private $logger;

    /**
     * @param Client $guzzleClient A Guzzle client configured with the Yubikey API base URL and authentication.
     * @param LoggerInterface $logger
     */
    public function __construct(Client $guzzleClient, LoggerInterface $logger)
    {
        $this->guzzleClient = $guzzleClient;
        $this->logger = $logger;
    }

    /**
     * @param VerifyYubikeyOtpCommand $command
     * @return YubikeyVerificationResult
     */
    public function verify(VerifyYubikeyOtpCommand $command)
    {
        $this->logger->info('Verifying Yubikey OTP');

        $body = [
            'requester' => ['institution' => $command->institution, 'identity' => $command->identityId],
            'otp' => ['value' => $command->otp],
        ];
        $response = $this->guzzleClient->post('api/verify-yubikey', ['json' => $body, 'http_errors' => false]);
        $statusCode = $response->getStatusCode();

        if ($statusCode != 200) {
            $type = $statusCode >= 400 && $statusCode < 500 ? 'client' : 'server';
            $this->logger->info(sprintf('Yubikey OTP verification failed; %s error', $type));

            return new YubikeyVerificationResult(true, false);
        }

        try {
            $result = JsonHelper::decode((string) $response->getBody());
        } catch (\RuntimeException $e) {
            $this->logger->error('Yubikey OTP verification failed; server responded with malformed JSON.');

            return new YubikeyVerificationResult(false, true);
        }

        if (!isset($result['status'])) {

This code seems to be duplicated across your project.

            $this->logger->error('Yubikey OTP verification failed; server responded without status report.');

            return new YubikeyVerificationResult(false, true);
        }

        if ($result['status'] !== 'OK') {

This code seems to be duplicated across your project.

            $this->logger->error('Yubikey OTP verification failed; server responded with non-OK status report.');

            return new YubikeyVerificationResult(false, true);
        }

        return new YubikeyVerificationResult(false, false);
    }
}