Surfnet\StepupRa\RaBundle\Controller\Vetting\SmsController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	130
Duplicated Lines	13.08 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getVettingService()	0	4	1
B	sendChallengeAction()	4	55	5
B	provePossessionAction()	13	51	7

<?php

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupRa\RaBundle\Controller\Vetting;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Surfnet\StepupBundle\Command\SendSmsChallengeCommand;
use Surfnet\StepupBundle\Command\VerifyPhoneNumberCommand;
use Surfnet\StepupBundle\Command\VerifyPossessionOfPhoneCommand;
use Surfnet\StepupBundle\Value\PhoneNumber\InternationalPhoneNumber;
use Surfnet\StepupRa\RaBundle\Form\Type\SendSmsChallengeType;
use Surfnet\StepupRa\RaBundle\Form\Type\VerifyPhoneNumberType;
use Surfnet\StepupRa\RaBundle\Service\VettingService;
use Symfony\Component\Form\FormError;
use Symfony\Component\Form\SubmitButton;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class SmsController extends SecondFactorController
{
    /**
     * @Template
     * @param Request $request
     * @param string $procedureId
     * @return array|Response
     */
    public function sendChallengeAction(Request $request, $procedureId)
    {
        $this->assertSecondFactorEnabled('sms');

        $this->denyAccessUnlessGranted(['ROLE_RA']);

        $logger = $this->get('ra.procedure_logger')->forProcedure($procedureId);
        $logger->notice('Received request for Send SMS Challenge page');

        if (!$this->getVettingService()->hasProcedure($procedureId)) {

This code seems to be duplicated across your project.

            $logger->notice(sprintf('Vetting procedure "%s" not found', $procedureId));
            throw new NotFoundHttpException(sprintf('Vetting procedure "%s" not found', $procedureId));
        }

        $command = new SendSmsChallengeCommand();
        $form = $this->createForm(SendSmsChallengeType::class, $command)->handleRequest($request);

        $vettingService = $this->getVettingService();
        $phoneNumber = InternationalPhoneNumber::fromStringFormat(
            $vettingService->getSecondFactorIdentifier($procedureId)
        );

        $otpRequestsRemaining = $vettingService->getSmsOtpRequestsRemainingCount();
        $maximumOtpRequests = $vettingService->getSmsMaximumOtpRequestsCount();
        $viewVariables = ['otpRequestsRemaining' => $otpRequestsRemaining, 'maximumOtpRequests' => $maximumOtpRequests];

        if (!$form->isSubmitted() || !$form->isValid()) {
            $logger->notice('Form has not been submitted, not sending SMS, rendering Send SMS Challenge page');

            return array_merge(
                $viewVariables,
                ['phoneNumber' => $phoneNumber, 'form' => $form->createView()]
            );
        }

        $logger->notice('Sending of SMS Challenge has been requested, sending OTP via SMS');
        if ($vettingService->sendSmsChallenge($procedureId, $command)) {
            $logger->notice(
                'SMS Challenge successfully sent, redirecting to Proof of Possession page to verify challenge'
            );

            return $this->redirectToRoute('ra_vetting_sms_prove_possession', ['procedureId' => $procedureId]);
        }

        $this->addFlash('error', 'ra.sms_send_challenge.send_sms_challenge_failed');

        $logger->notice(
            'SMS Challenge could not be sent, added error to page to notify user and re-rendering send challenge page'
        );

        return array_merge(
            $viewVariables,
            ['phoneNumber' => $phoneNumber, 'form' => $form->createView()]
        );
    }

    /**
     * @Template
     * @param Request $request
     * @param string $procedureId
     * @return array|Response
     */
    public function provePossessionAction(Request $request, $procedureId)
    {
        $this->assertSecondFactorEnabled('sms');
        $this->denyAccessUnlessGranted(['ROLE_RA']);
        $logger = $this->get('ra.procedure_logger')->forProcedure($procedureId);

        $logger->notice('Received request for Proof of Possession of SMS Second Factor page');

        $command = new VerifyPossessionOfPhoneCommand();
        $form = $this
            ->createForm(VerifyPhoneNumberType::class, $command, ['procedureId' => $procedureId])
            ->handleRequest($request);

        /** @var SubmitButton $cancelButton */
        $cancelButton = $form->get('cancel');
        if ($cancelButton->isClicked()) {

This code seems to be duplicated across your project.

            $this->getVettingService()->cancelProcedure($procedureId);
            $this->addFlash('info', $this->get('translator')->trans('ra.vetting.flash.cancelled'));

            return $this->redirectToRoute('ra_vetting_search');
        }

        if (!$form->isSubmitted() || !$form->isValid()) {

This code seems to be duplicated across your project.

            $logger->notice(
                'SMS OTP was not submitted through form, rendering Proof of Possession of SMS Second Factor page'
            );

            return ['form' => $form->createView()];
        }

        $logger->notice('SMS OTP has been entered, attempting to verify Proof of Possession');
        $verification = $this->getVettingService()->verifyPhoneNumber($procedureId, $command);
        if ($verification->wasSuccessful()) {
            $logger->notice('SMS OTP was valid, Proof of Possession given, redirecting to Identity Vetting page');

            return $this->redirectToRoute(
                'ra_vetting_verify_identity',
                ['procedureId' => $procedureId]
            );
        } elseif ($verification->didOtpExpire()) {
            $this->addFlash('error', 'ra.prove_phone_possession.challenge_expired');
        } elseif ($verification->wasAttemptedTooManyTimes()) {
            $this->addFlash('error', 'ra.prove_phone_possession.too_many_attempts');
        } else {
            $this->addFlash('error', 'ra.prove_phone_possession.challenge_response_incorrect');
        }

        $logger->notice('SMS OTP verification failed - Proof of Possession denied, added error to form');

        return ['form' => $form->createView()];
    }

    /**
     * @return VettingService
     */
    private function getVettingService()
    {
        return $this->get('ra.service.vetting');
    }
}