Surfnet\StepupMiddleware\ApiBundle\Configuration\Entity\InstitutionWithPersonalRaDetails

Complexity

Total Complexity

2

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	2
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	createFrom()	0	8	1
A	jsonSerialize()	0	4	1

<?php

/**
 * Copyright 2016 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddleware\ApiBundle\Configuration\Entity;

use Doctrine\ORM\Mapping as ORM;
use JsonSerializable;
use Surfnet\Stepup\Configuration\Value\Institution;

/**
 * @ORM\Entity(
 *      repositoryClass="Surfnet\StepupMiddleware\ApiBundle\Configuration\Repository\InstitutionWithPersonalRaDetailsRepository"

This line exceeds maximum limit of 120 characters; contains 128 characters

 * )
 * @ORM\Table()
 */
class InstitutionWithPersonalRaDetails implements JsonSerializable
{
    /**
     * @ORM\Id
     * @ORM\Column(type="institution")
     *
     * @var string
     */
    public $institution;

    public static function createFrom(Institution $institution)
    {
        $institutionWithPersonalRaDetails = new self;

The variable name $institutionWithPersonalRaDetails exceeds the maximum configured length of 30.

        $institutionWithPersonalRaDetails->institution = $institution;

It seems like $institution of type object<Surfnet\Stepup\Configuration\Value\Institution> is incompatible with the declared type string of property $institution.

        return $institutionWithPersonalRaDetails;
    }

    public function jsonSerialize()
    {
        return ['institution' => $this->institution];
    }
}