Completed
Push — feature/improve-input-validati... ( 8f7b6e...dd35c7 )
by Michiel
02:12
created
MiddlewareBundle/Console/Command/BootstrapYubikeySecondFactorCommand.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -136,6 +136,10 @@
 block discarded – undo
136 136
         );
137 137
     }
138 138
 
139
+    /**
140
+     * @param string $secondFactorId
141
+     * @param \Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\Identity $identity
142
+     */
139 143
     private function provePossession($secondFactorId, $identity, $phoneNumber)
140 144
     {
141 145
         $command = new ProveYubikeyPossessionCommand();
Please login to merge, or discard this patch.
MiddlewareBundle/Console/Command/BootstrapGsspSecondFactorCommand.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -143,6 +143,10 @@
 block discarded – undo
143 143
         );
144 144
     }
145 145
 
146
+    /**
147
+     * @param string $secondFactorId
148
+     * @param \Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\Identity $identity
149
+     */
146 150
     private function provePossession($secondFactorId, $identity, $tokenType, $tokenIdentifier)
147 151
     {
148 152
         $command = new ProveGssfPossessionCommand();
Please login to merge, or discard this patch.
Surfnet/StepupMiddleware/MiddlewareBundle/Service/TokenBootstrapService.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
     }
79 79
 
80 80
     /**
81
-     * @param $identityId
81
+     * @param string $identityId
82 82
      * @param $tokenType
83 83
      * @return UnverifiedSecondFactor|null
84 84
      */
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
     }
91 91
 
92 92
     /**
93
-     * @param $identityId
93
+     * @param string $identityId
94 94
      * @param $tokenType
95 95
      * @return VerifiedSecondFactor|null
96 96
      */
Please login to merge, or discard this patch.
MiddlewareBundle/Console/Command/AbstractBootstrapCommand.php 1 patch
Doc Comments   +8 added lines, -1 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 
90 90
     /**
91 91
      * @param string $registrationStatus
92
-     * @return bool
92
+     * @return boolean|null
93 93
      */
94 94
     protected function validRegistrationStatus($registrationStatus)
95 95
     {
@@ -113,6 +113,10 @@  discard block
 block discarded – undo
113 113
         return true;
114 114
     }
115 115
 
116
+    /**
117
+     * @param \Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\Identity $identity
118
+     * @param string $secondFactorId
119
+     */
116 120
     protected function vetSecondFactor($tokenType, $actorId, $identity, $secondFactorId, $verifiedSecondFactor, $phoneNumber)
117 121
     {
118 122
         $command = new VetSecondFactorCommand();
@@ -137,6 +141,9 @@  discard block
 block discarded – undo
137 141
         $this->enricher->setMetadata($metadata);
138 142
     }
139 143
 
144
+    /**
145
+     * @param \Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\Identity $identity
146
+     */
140 147
     protected function verifyEmail($identity, $unverifiedSecondFactor)
141 148
     {
142 149
         $command = new VerifyEmailCommand();
Please login to merge, or discard this patch.