Surfnet\StepupMiddleware\CommandHandlingBundle\Processor\RegistrationEmailProcessor

Complexity

Total Complexity

11

Size/Duplication

Total Lines	124
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
A	handlePhonePossessionProvenAndVerifiedEvent()	0	4	1
A	handleYubikeyPossessionProvenAndVerifiedEvent()	0	4	1
A	handleGssfPossessionProvenAndVerifiedEvent()	0	4	1
A	handleEmailVerifiedEvent()	0	4	1
A	handlePossessionProvenAndVerifiedEvent()	0	26	3
A	sendRegistrationEmailWithRaLocations()	0	11	1
A	sendRegistrationEmailWithRas()	0	11	1
A	getExpirationDateOfRegistration()	0	6	1

<?php

/**
 * Copyright 2016 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddleware\CommandHandlingBundle\Processor;

use Broadway\Processor\Processor;
use DateInterval;
use Surfnet\Stepup\Configuration\Value\Institution;
use Surfnet\Stepup\DateTime\DateTime;
use Surfnet\Stepup\Identity\Event\EmailVerifiedEvent;
use Surfnet\Stepup\Identity\Event\GssfPossessionProvenAndVerifiedEvent;
use Surfnet\Stepup\Identity\Event\PhonePossessionProvenAndVerifiedEvent;
use Surfnet\Stepup\Identity\Event\PossessionProvenAndVerified;
use Surfnet\Stepup\Identity\Event\YubikeyPossessionProvenAndVerifiedEvent;
use Surfnet\StepupMiddleware\ApiBundle\Configuration\Service\InstitutionConfigurationOptionsService;
use Surfnet\StepupMiddleware\ApiBundle\Configuration\Service\RaLocationService;
use Surfnet\StepupMiddleware\ApiBundle\Identity\Service\RaListingService;
use Surfnet\StepupMiddleware\ApiBundle\Identity\Value\RegistrationAuthorityCredentials;
use Surfnet\StepupMiddleware\CommandHandlingBundle\Identity\Service\RegistrationMailService;

/**
 * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
 */
final class RegistrationEmailProcessor extends Processor
{
    /**
     * @var RaLocationService
     */
    private $raLocationsService;

    /**
     * @var RegistrationMailService
     */
    private $registrationMailService;

    /**
     * @var InstitutionConfigurationOptionsService
     */
    private $institutionConfigurationOptionsService;

    /**
     * @var RaListingService
     */
    private $raListingService;

    public function __construct(
        RegistrationMailService $registrationMailService,
        RaListingService $raListingService,
        InstitutionConfigurationOptionsService $institutionConfigurationOptionsService,
        RaLocationService $raLocationsService
    ) {
        $this->registrationMailService = $registrationMailService;
        $this->raListingService = $raListingService;
        $this->institutionConfigurationOptionsService = $institutionConfigurationOptionsService;
        $this->raLocationsService = $raLocationsService;
    }

    public function handlePhonePossessionProvenAndVerifiedEvent(PhonePossessionProvenAndVerifiedEvent $event)
    {
        $this->handlePossessionProvenAndVerifiedEvent($event);
    }

    public function handleYubikeyPossessionProvenAndVerifiedEvent(YubikeyPossessionProvenAndVerifiedEvent $event)
    {
        $this->handlePossessionProvenAndVerifiedEvent($event);
    }

    public function handleGssfPossessionProvenAndVerifiedEvent(GssfPossessionProvenAndVerifiedEvent $event)
    {
        $this->handlePossessionProvenAndVerifiedEvent($event);
    }

    public function handleEmailVerifiedEvent(EmailVerifiedEvent $event)
    {
        $this->handlePossessionProvenAndVerifiedEvent($event);
    }

    private function handlePossessionProvenAndVerifiedEvent(PossessionProvenAndVerified $event)
    {
        $institution = new Institution($event->identityInstitution->getInstitution());

Accessing identityInstitution on the interface Surfnet\Stepup\Identity\Event\PossessionProvenAndVerified suggest that you code against a concrete implementation. How about adding an instanceof check?

        $institutionConfigurationOptions = $this->institutionConfigurationOptionsService
            ->findInstitutionConfigurationOptionsFor($institution);

        if ($institutionConfigurationOptions->useRaLocationsOption->isEnabled()) {
            $this->sendRegistrationEmailWithRaLocations($event, $institution);

            return;
        }

        $ras = $this->raListingService->listRegistrationAuthoritiesFor($event->identityInstitution);

Accessing identityInstitution on the interface Surfnet\Stepup\Identity\Event\PossessionProvenAndVerified suggest that you code against a concrete implementation. How about adding an instanceof check?

        if ($institutionConfigurationOptions->showRaaContactInformationOption->isEnabled()) {
            $this->sendRegistrationEmailWithRas($event, $ras);

            return;
        }

        $rasWithoutRaas = array_filter($ras, function (RegistrationAuthorityCredentials $ra) {
            return !$ra->isRaa();
        });

        $this->sendRegistrationEmailWithRas($event, $rasWithoutRaas);
    }

    /**
     * @param EmailVerifiedEvent $event

Should the type for parameter $event not be PossessionProvenAndVerified?

     * @param Institution $institution
     */
    private function sendRegistrationEmailWithRaLocations(PossessionProvenAndVerified $event, Institution $institution)
    {
        $this->registrationMailService->sendRegistrationEmailWithRaLocations(
            (string)$event->preferredLocale,

Accessing preferredLocale on the interface Surfnet\Stepup\Identity\Event\PossessionProvenAndVerified suggest that you code against a concrete implementation. How about adding an instanceof check?

            (string)$event->commonName,

Accessing commonName on the interface Surfnet\Stepup\Identity\Event\PossessionProvenAndVerified suggest that you code against a concrete implementation. How about adding an instanceof check?

            (string)$event->email,

Accessing email on the interface Surfnet\Stepup\Identity\Event\PossessionProvenAndVerified suggest that you code against a concrete implementation. How about adding an instanceof check?

            $event->registrationCode,

Accessing registrationCode on the interface Surfnet\Stepup\Identity\Event\PossessionProvenAndVerified suggest that you code against a concrete implementation. How about adding an instanceof check?

            $this->getExpirationDateOfRegistration($event),
            $this->raLocationsService->listRaLocationsFor($institution)
        );
    }

    /**
     * @param PossessionProvenAndVerified $event
     * @param RegistrationAuthorityCredentials[] $ras
     */
    private function sendRegistrationEmailWithRas(PossessionProvenAndVerified $event, array $ras)
    {
        $this->registrationMailService->sendRegistrationEmailWithRas(
            (string)$event->preferredLocale,

Accessing preferredLocale on the interface Surfnet\Stepup\Identity\Event\PossessionProvenAndVerified suggest that you code against a concrete implementation. How about adding an instanceof check?

            (string)$event->commonName,

Accessing commonName on the interface Surfnet\Stepup\Identity\Event\PossessionProvenAndVerified suggest that you code against a concrete implementation. How about adding an instanceof check?

            (string)$event->email,

Accessing email on the interface Surfnet\Stepup\Identity\Event\PossessionProvenAndVerified suggest that you code against a concrete implementation. How about adding an instanceof check?

            $event->registrationCode,

Accessing registrationCode on the interface Surfnet\Stepup\Identity\Event\PossessionProvenAndVerified suggest that you code against a concrete implementation. How about adding an instanceof check?

            $this->getExpirationDateOfRegistration($event),
            $ras
        );
    }

    /**
     * @param EmailVerifiedEvent $event

Should the type for parameter $event not be PossessionProvenAndVerified?

     * @return DateTime
     */
    private function getExpirationDateOfRegistration(PossessionProvenAndVerified $event)
    {
        return $event->registrationRequestedAt->add(

Accessing registrationRequestedAt on the interface Surfnet\Stepup\Identity\Event\PossessionProvenAndVerified suggest that you code against a concrete implementation. How about adding an instanceof check?

            new DateInterval('P14D')
        )->endOfDay();
    }
}