OpenConext / Stepup-Middleware

src/Surfnet/Stepup/Identity/Entity/RegistrationAuthorityCollection.php

Doc Comments +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
 
     /**
      * @param Institution $institution
-     * @return RegistrationAuthority
+     * @return boolean
      */
     public function exists(Institution $institution)
     {

src/Surfnet/Stepup/Identity/Entity/InstitutionCollection.php

Doc Comments +2 added lines, -2 removed lines

@@ -49,7 +49,7 @@ 
 
     /**
      * @param Institution $institution
-     * @return Institution
+     * @return InstitutionRole
      */
     public function get(Institution $institution)
     {
@@ -58,7 +58,7 @@ 
 
     /**
      * @param Institution $institution
-     * @return Institution
+     * @return boolean
      */
     public function exists(Institution $institution)
     {

src/Surfnet/Stepup/Identity/Event/AppointedAsRaaEvent.php

Doc Comments +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
     }
 
     /**
-     * @return mixed The object instance
+     * @return AppointedAsRaaEvent The object instance
      */
     public static function deserialize(array $data)
     {

src/Surfnet/Stepup/Identity/Event/AppointedAsRaEvent.php

Doc Comments +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
     }
 
     /**
-     * @return mixed The object instance
+     * @return AppointedAsRaEvent The object instance
      */
     public static function deserialize(array $data)
     {

src/Surfnet/Stepup/Identity/Api/Identity.php

Doc Comments +3 added lines, -1 removed lines

@@ -66,6 +66,7 @@ 
 
     /**
      * Construct a new aggregate root. Aggregate roots can only be affected by events, so no parameters are allowed.
+     * @return void
      */
     public function __construct();
 
@@ -297,13 +298,14 @@ 
     public function getVerifiedSecondFactor(SecondFactorId $secondFactorId);
 
     /**
-     * @return IdentityId We're deviating from Broadway's official API, as they accept toString-able VOs as IDs, and we
+     * @return string We're deviating from Broadway's official API, as they accept toString-able VOs as IDs, and we
      *     require the IdentityId VO in our SensitiveDataEventStoreDecorator.
      */
     public function getAggregateRootId(): string;
 
     /**
      * @param int $numberOfTokens
+     * @return void
      */
     public function setMaxNumberOfTokens($numberOfTokens);
 }

src/Surfnet/StepupMiddleware/ApiBundle/Identity/Repository/RaListingRepository.php

Doc Comments +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
 
     /**
      * @param IdentityId $identityId The RA's identity id.
-     * @return null|RaListing[]
+     * @return RaListing[]
      */
     public function findByIdentityId(IdentityId $identityId)
     {

src/Surfnet/StepupMiddleware/ManagementBundle/Validator/ReconfigureInstitutionRequestValidator.php

Doc Comments +3 added lines, -3 removed lines

@@ -241,7 +241,7 @@ 
 
     /**
      * @param string[] $institutions
-     * @param $configuredInstitutions
+     * @param string[] $configuredInstitutions
      * @return string[]
      */
     public function determineNonExistentInstitutions(array $institutions, $configuredInstitutions)
@@ -270,8 +270,8 @@ 
      *  - Or be empty
      *
      * @param $authorizationSettings
-     * @param $institution
-     * @param $propertyPath
+     * @param string $institution
+     * @param string $propertyPath
      * @throws \Assert\AssertionFailedException
      */
     private function validateAuthorizationSettings($authorizationSettings, $institution, $propertyPath)

src/Surfnet/StepupMiddleware/MiddlewareBundle/Console/Command/AbstractBootstrapCommand.php

Doc Comments +8 added lines

@@ -93,6 +93,10 @@ 
         return true;
     }
 
+    /**
+     * @param \Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\Identity $identity
+     * @param \Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\VerifiedSecondFactor|null $verifiedSecondFactor
+     */
     protected function vetSecondFactor($tokenType, $actorId, $identity, $secondFactorId, $verifiedSecondFactor, $phoneNumber)
     {
         $command = new VetSecondFactorCommand();
@@ -117,6 +121,10 @@ 
         $this->enricher->setMetadata($metadata);
     }
 
+    /**
+     * @param \Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\Identity $identity
+     * @param \Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\UnverifiedSecondFactor|null $unverifiedSecondFactor
+     */
     protected function verifyEmail($identity, $unverifiedSecondFactor)
     {
         $command = new VerifyEmailCommand();

src/Surfnet/StepupMiddleware/MiddlewareBundle/Service/VerifiedSecondFactorReminderMailService.php

Doc Comments +1 added lines

@@ -167,6 +167,7 @@
      * @param string $email
      * @param DateTime $requestedAt
      * @param $registrationCode
+     * @param \Surfnet\StepupMiddleware\ApiBundle\Configuration\Entity\RaLocation[] $raLocations
      * @return int
      */
     private function sendReminderWithInstitution(