Surfnet\StepupMiddleware\ApiBundle\Authorization\Value\InstitutionAuthorizationContext

Complexity

Total Complexity

3

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getActorInstitution()	0	4	1
A	getRoleRequirements()	0	4	1

<?php

/**
 * Copyright 2018 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddleware\ApiBundle\Authorization\Value;

use Surfnet\Stepup\Identity\Value\Institution;
use Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\Identity;

class InstitutionAuthorizationContext implements InstitutionAuthorizationContextInterface
{
    /**
     * @var Institution
     */
    private $actorInstitution;

    /**
     * @var InstitutionRoleSet
     */
    private $roleRequirements;

    /**
     * AuthorizationContext constructor.
     * @param string $actorId

There is no parameter named $actorId. Was it maybe removed?

     * @param string $actorInstitution
     * @param InstitutionRoleSetInterface $roleRequirements
     */
    public function __construct($actorInstitution, InstitutionRoleSetInterface $roleRequirements)
    {
        $this->actorInstitution = $actorInstitution;

It seems like $actorInstitution of type string is incompatible with the declared type object<Surfnet\Stepup\Identity\Value\Institution> of property $actorInstitution.

        $this->roleRequirements = $roleRequirements;

$roleRequirements is of type object<Surfnet\StepupMiddleware\ApiBundle\Authorization\Value\InstitutionRoleSetInterface>, but the property $roleRequirements was declared to be of type object<Surfnet\StepupMiddleware\ApiBundle\Authorization\Value\InstitutionRoleSet>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * @return Institution
     */
    public function getActorInstitution()
    {
        return $this->actorInstitution;
    }

    /**
     * @return InstitutionRoleSet
     */
    public function getRoleRequirements()
    {
        return $this->roleRequirements;
    }
}