Completed
Pull Request — feature/fine-grained-authoriza... (#243)
by Michiel
85:01 queued 41:32
created
StepupMiddleware/ApiBundle/Identity/Value/VerifiedTokenInformation.php 1 patch
Doc Comments   +11 added lines, -8 removed lines patch added patch discarded remove patch
@@ -40,14 +40,14 @@  discard block
 block discarded – undo
40 40
     private $registrationCode;
41 41
 
42 42
     /**
43
-     * @param $email
44
-     * @param $tokenId
45
-     * @param $tokenType
46
-     * @param $commonName
47
-     * @param $requestedAt
48
-     * @param $preferredLocale
49
-     * @param $institution
50
-     * @param $registrationCode
43
+     * @param string $email
44
+     * @param string $tokenId
45
+     * @param string $tokenType
46
+     * @param string $commonName
47
+     * @param \DateTime $requestedAt
48
+     * @param string $preferredLocale
49
+     * @param \Surfnet\Stepup\Identity\Value\Institution $institution
50
+     * @param string $registrationCode
51 51
      */
52 52
     public function __construct(
53 53
         $email,
@@ -115,6 +115,9 @@  discard block
 block discarded – undo
115 115
         return $this->preferredLocale;
116 116
     }
117 117
 
118
+    /**
119
+     * @return \Surfnet\Stepup\Identity\Value\Institution
120
+     */
118 121
     public function getInstitution()
119 122
     {
120 123
         return $this->institution;
Please login to merge, or discard this patch.
ApiBundle/Configuration/Repository/InstitutionAuthorizationRepository.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,6 @@
 block discarded – undo
79 79
 
80 80
     /**
81 81
      * @param Institution $institution
82
-     * @param InstitutionAuthorizationOption $institutionOption
83 82
      * @throws \Doctrine\ORM\OptimisticLockException
84 83
      */
85 84
     public function clearInstitutionOption(Institution $institution)
Please login to merge, or discard this patch.
ApiBundle/Authorization/Value/InstitutionRoleSetInterface.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -23,5 +23,8 @@
 block discarded – undo
23 23
 
24 24
 interface InstitutionRoleSetInterface
25 25
 {
26
+    /**
27
+     * @return InstitutionRole[]
28
+     */
26 29
     public function getRoles();
27 30
 }
Please login to merge, or discard this patch.
ApiBundle/Authorization/Value/InstitutionAuthorizationContext.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,6 @@
 block discarded – undo
35 35
 
36 36
     /**
37 37
      * AuthorizationContext constructor.
38
-     * @param string $actorId
39 38
      * @param string $actorInstitution
40 39
      * @param InstitutionRoleSetInterface $roleRequirements
41 40
      */
Please login to merge, or discard this patch.
ApiBundle/Identity/Repository/VerifiedSecondFactorRepository.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -87,8 +87,6 @@
 block discarded – undo
87 87
 
88 88
     /**
89 89
      * @param VerifiedSecondFactorQuery $query
90
-     * @param InstitutionAuthorizationContextInterface $authorizationContext
91
-     * @param InstitutionAuthorizationRepositoryFilter $authorizationRepositoryFilter
92 90
      * @return Query
93 91
      */
94 92
     public function createSearchQuery(VerifiedSecondFactorQuery $query)
Please login to merge, or discard this patch.
src/Surfnet/StepupMiddleware/ApiBundle/Identity/Service/IdentityService.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,6 @@
 block discarded – undo
73 73
 
74 74
     /**
75 75
      * @param IdentityQuery $query
76
-     * @param InstitutionRoleSet $institutionRoles
77 76
      * @return \Pagerfanta\Pagerfanta
78 77
      */
79 78
     public function search(IdentityQuery $query)
Please login to merge, or discard this patch.
Surfnet/StepupMiddleware/ApiBundle/Controller/RaSecondFactorController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
 
75 75
     /**
76 76
      * @param Request $request
77
-     * @param Institution $institution
77
+     * @param Institution $actorInstitution
78 78
      * @return RaSecondFactorQuery
79 79
      */
80 80
     private function buildRaSecondFactorQuery(Request $request, Institution $actorInstitution)
Please login to merge, or discard this patch.