InstitutionConfigurationCommandHandler::__construct() - Code Metrics - Inspection of "Update command handler for dealing with both norma..." - OpenConext/Stepup-Middleware - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#168)

by A.

created 2017-02-06 16:31 UTC

__construct() A

↳ Parent: InstitutionConfigurationCommandHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php

/**
 * Copyright 2016 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddleware\CommandHandlingBundle\Configuration\CommandHandler;

use Broadway\CommandHandling\CommandHandler;
use Broadway\Repository\AggregateNotFoundException;
use Broadway\Repository\RepositoryInterface;
use Surfnet\Stepup\Configuration\InstitutionConfiguration;
use Surfnet\Stepup\Configuration\Value\InstitutionConfigurationId;
use Surfnet\Stepup\Configuration\Value\Institution;
use Surfnet\Stepup\Configuration\Value\Location;
use Surfnet\Stepup\Configuration\Value\RaLocationId;
use Surfnet\Stepup\Configuration\Value\RaLocationName;
use Surfnet\Stepup\Configuration\Value\ContactInformation;
use Surfnet\Stepup\Configuration\Value\ShowRaaContactInformationOption;
use Surfnet\Stepup\Configuration\Value\UseRaLocationsOption;
use Surfnet\StepupMiddleware\CommandHandlingBundle\Configuration\Command\AddRaLocationCommand;
use Surfnet\StepupMiddleware\CommandHandlingBundle\Configuration\Command\ChangeRaLocationCommand;
use Surfnet\StepupMiddleware\CommandHandlingBundle\Configuration\Command\ReconfigureInstitutionConfigurationOptionsCommand;

use Surfnet\StepupMiddleware\CommandHandlingBundle\Configuration\Command\CreateInstitutionConfigurationCommand;
use Surfnet\StepupMiddleware\CommandHandlingBundle\Configuration\Command\RemoveInstitutionConfigurationByUnnormalizedIdCommand;

use Surfnet\StepupMiddleware\CommandHandlingBundle\Configuration\Command\RemoveRaLocationCommand;

/**
 * @SuppressWarnings(PHPMD.CouplingBetweenObjects) Value objects
 */
class InstitutionConfigurationCommandHandler extends CommandHandler
{
    /**
     * @var RepositoryInterface
     */
    private $repository;

    public function __construct(RepositoryInterface $repository)
    {
        $this->repository = $repository;
    }

    public function handleCreateInstitutionConfigurationCommand(CreateInstitutionConfigurationCommand $command)

    {
        $institution = new Institution($command->institution);
        $institutionConfigurationId = InstitutionConfigurationId::normalizedFrom($institution);

        try {
            /** @var InstitutionConfiguration $institutionConfiguration */
            $institutionConfiguration = $this->repository->load(
                $institutionConfigurationId->getInstitutionConfigurationId()
            );

            $institutionConfiguration->rebuild();

        } catch (AggregateNotFoundException $exception) {
            $institutionConfiguration = InstitutionConfiguration::create($institutionConfigurationId, $institution);
        }

        $this->repository->save($institutionConfiguration);
    }

    public function handleReconfigureInstitutionConfigurationOptionsCommand(
        ReconfigureInstitutionConfigurationOptionsCommand $command
    ) {
        $institution = new Institution($command->institution);

        $institutionConfiguration = $this->loadInstitutionConfigurationFor($institution);

        $institutionConfiguration->configureUseRaLocationsOption(
            new UseRaLocationsOption($command->useRaLocationsOption)
        );
        $institutionConfiguration->configureShowRaaContactInformationOption(
            new ShowRaaContactInformationOption($command->showRaaContactInformationOption)
        );

        $this->repository->save($institutionConfiguration);
    }

    public function handleAddRaLocationCommand(AddRaLocationCommand $command)

    {
        $institution = new Institution($command->institution);

        $institutionConfiguration = $this->loadInstitutionConfigurationFor($institution);

        $institutionConfiguration->addRaLocation(
            new RaLocationId($command->raLocationId),
            new RaLocationName($command->raLocationName),
            new Location($command->location),
            new ContactInformation($command->contactInformation)
        );

        $this->repository->save($institutionConfiguration);
    }

    public function handleChangeRaLocationCommand(ChangeRaLocationCommand $command)

    {
        $institution = new Institution($command->institution);

        $institutionConfiguration = $this->loadInstitutionConfigurationFor($institution);

        $institutionConfiguration->changeRaLocation(
            new RaLocationId($command->raLocationId),
            new RaLocationName($command->raLocationName),
            new Location($command->location),
            new ContactInformation($command->contactInformation)
        );

        $this->repository->save($institutionConfiguration);
    }

    public function handleRemoveRaLocationCommand(RemoveRaLocationCommand $command)
    {
        $institution = new Institution($command->institution);

        $institutionConfiguration = $this->loadInstitutionConfigurationFor($institution);

        $institutionConfiguration->removeRaLocation(new RaLocationId($command->raLocationId));

        $this->repository->save($institutionConfiguration);
    }

    public function handleRemoveInstitutionConfigurationByUnnormalizedIdCommand(
        RemoveInstitutionConfigurationByUnnormalizedIdCommand $command
    ) {
        $institution = new Institution($command->institution);

        $institutionConfigurationId = InstitutionConfigurationId::from($institution);

        $institutionConfiguration = $this->repository->load(
            $institutionConfigurationId->getInstitutionConfigurationId()
        );
        $institutionConfiguration->destroy();

        $this->repository->save($institutionConfiguration);
    }

    /**
     * @deprecated Should be used until existing institution configurations have been migrated to using normalized ids
     *
     * @param Institution $institution
     * @return InstitutionConfiguration
     */
    private function loadInstitutionConfigurationFor(Institution $institution)

    {
        try {
            $institutionConfigurationId = InstitutionConfigurationId::normalizedFrom($institution);
            $institutionConfiguration = $this->repository->load(
                $institutionConfigurationId->getInstitutionConfigurationId()
            );
        } catch (AggregateNotFoundException $exception) {
            $institutionConfigurationId = InstitutionConfigurationId::from($institution);

            $institutionConfiguration = $this->repository->load(
                $institutionConfigurationId->getInstitutionConfigurationId()
            );
        }

        return $institutionConfiguration;
    }
}


1		<?php
2
3		/**
4		* Copyright 2016 SURFnet B.V.
5		*
6		* Licensed under the Apache License, Version 2.0 (the "License");
7		* you may not use this file except in compliance with the License.
8		* You may obtain a copy of the License at
9		*
10		* http://www.apache.org/licenses/LICENSE-2.0
11		*
12		* Unless required by applicable law or agreed to in writing, software
13		* distributed under the License is distributed on an "AS IS" BASIS,
14		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15		* See the License for the specific language governing permissions and
16		* limitations under the License.
17		*/
18
19		namespace Surfnet\StepupMiddleware\CommandHandlingBundle\Configuration\CommandHandler;
20
21		use Broadway\CommandHandling\CommandHandler;
22		use Broadway\Repository\AggregateNotFoundException;
23		use Broadway\Repository\RepositoryInterface;
24		use Surfnet\Stepup\Configuration\InstitutionConfiguration;
25		use Surfnet\Stepup\Configuration\Value\InstitutionConfigurationId;
26		use Surfnet\Stepup\Configuration\Value\Institution;
27		use Surfnet\Stepup\Configuration\Value\Location;
28		use Surfnet\Stepup\Configuration\Value\RaLocationId;
29		use Surfnet\Stepup\Configuration\Value\RaLocationName;
30		use Surfnet\Stepup\Configuration\Value\ContactInformation;
31		use Surfnet\Stepup\Configuration\Value\ShowRaaContactInformationOption;
32		use Surfnet\Stepup\Configuration\Value\UseRaLocationsOption;
33		use Surfnet\StepupMiddleware\CommandHandlingBundle\Configuration\Command\AddRaLocationCommand;
34		use Surfnet\StepupMiddleware\CommandHandlingBundle\Configuration\Command\ChangeRaLocationCommand;
35		use Surfnet\StepupMiddleware\CommandHandlingBundle\Configuration\Command\ReconfigureInstitutionConfigurationOptionsCommand;
		0 ignored issues – show Coding Style introduced 2016-07-25 09:03 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 123 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
36		use Surfnet\StepupMiddleware\CommandHandlingBundle\Configuration\Command\CreateInstitutionConfigurationCommand;
37		use Surfnet\StepupMiddleware\CommandHandlingBundle\Configuration\Command\RemoveInstitutionConfigurationByUnnormalizedIdCommand;
		0 ignored issues – show Coding Style introduced 2017-01-30 16:00 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 127 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
38		use Surfnet\StepupMiddleware\CommandHandlingBundle\Configuration\Command\RemoveRaLocationCommand;
39
40		/**
41		* @SuppressWarnings(PHPMD.CouplingBetweenObjects) Value objects
42		*/
43		class InstitutionConfigurationCommandHandler extends CommandHandler
44		{
45		/**
46		* @var RepositoryInterface
47		*/
48		private $repository;
49
50		public function __construct(RepositoryInterface $repository)
51		{
52		$this->repository = $repository;
53		}
54
55	View Code Duplication	public function handleCreateInstitutionConfigurationCommand(CreateInstitutionConfigurationCommand $command)
		0 ignored issues – show Duplication introduced 2017-02-06 16:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		{
57		$institution = new Institution($command->institution);
58		$institutionConfigurationId = InstitutionConfigurationId::normalizedFrom($institution);
59
60		try {
61		/** @var InstitutionConfiguration $institutionConfiguration */
62		$institutionConfiguration = $this->repository->load(
63		$institutionConfigurationId->getInstitutionConfigurationId()
64		);
65
66		$institutionConfiguration->rebuild();
67
68		} catch (AggregateNotFoundException $exception) {
69		$institutionConfiguration = InstitutionConfiguration::create($institutionConfigurationId, $institution);
70		}
71
72		$this->repository->save($institutionConfiguration);
73		}
74
75		public function handleReconfigureInstitutionConfigurationOptionsCommand(
76		ReconfigureInstitutionConfigurationOptionsCommand $command
77		) {
78		$institution = new Institution($command->institution);
79
80		$institutionConfiguration = $this->loadInstitutionConfigurationFor($institution);
		0 ignored issues – show Deprecated Code introduced 2017-02-06 16:23 UTC by Report Bug Copy Issue Report The method `Surfnet\StepupMiddleware...utionConfigurationFor()` has been deprecated with message: Should be used until existing institution configurations have been migrated to using normalized ids This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
81		$institutionConfiguration->configureUseRaLocationsOption(
82		new UseRaLocationsOption($command->useRaLocationsOption)
83		);
84		$institutionConfiguration->configureShowRaaContactInformationOption(
85		new ShowRaaContactInformationOption($command->showRaaContactInformationOption)
86		);
87
88		$this->repository->save($institutionConfiguration);
89		}
90
91	View Code Duplication	public function handleAddRaLocationCommand(AddRaLocationCommand $command)
		0 ignored issues – show Duplication introduced 2016-07-12 15:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
92		{
93		$institution = new Institution($command->institution);
94
95		$institutionConfiguration = $this->loadInstitutionConfigurationFor($institution);
		0 ignored issues – show Deprecated Code introduced 2017-02-06 16:23 UTC by Report Bug Copy Issue Report The method `Surfnet\StepupMiddleware...utionConfigurationFor()` has been deprecated with message: Should be used until existing institution configurations have been migrated to using normalized ids This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
96		$institutionConfiguration->addRaLocation(
97		new RaLocationId($command->raLocationId),
98		new RaLocationName($command->raLocationName),
99		new Location($command->location),
100		new ContactInformation($command->contactInformation)
101		);
102
103		$this->repository->save($institutionConfiguration);
104		}
105
106	View Code Duplication	public function handleChangeRaLocationCommand(ChangeRaLocationCommand $command)
		0 ignored issues – show Duplication introduced 2016-07-12 15:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
107		{
108		$institution = new Institution($command->institution);
109
110		$institutionConfiguration = $this->loadInstitutionConfigurationFor($institution);
		0 ignored issues – show Deprecated Code introduced 2017-02-06 16:23 UTC by Report Bug Copy Issue Report The method `Surfnet\StepupMiddleware...utionConfigurationFor()` has been deprecated with message: Should be used until existing institution configurations have been migrated to using normalized ids This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
111		$institutionConfiguration->changeRaLocation(
112		new RaLocationId($command->raLocationId),
113		new RaLocationName($command->raLocationName),
114		new Location($command->location),
115		new ContactInformation($command->contactInformation)
116		);
117
118		$this->repository->save($institutionConfiguration);
119		}
120
121		public function handleRemoveRaLocationCommand(RemoveRaLocationCommand $command)
122		{
123		$institution = new Institution($command->institution);
124
125		$institutionConfiguration = $this->loadInstitutionConfigurationFor($institution);
		0 ignored issues – show Deprecated Code introduced 2017-02-06 16:23 UTC by Report Bug Copy Issue Report The method `Surfnet\StepupMiddleware...utionConfigurationFor()` has been deprecated with message: Should be used until existing institution configurations have been migrated to using normalized ids This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
126		$institutionConfiguration->removeRaLocation(new RaLocationId($command->raLocationId));
127
128		$this->repository->save($institutionConfiguration);
129		}
130
131		public function handleRemoveInstitutionConfigurationByUnnormalizedIdCommand(
132		RemoveInstitutionConfigurationByUnnormalizedIdCommand $command
133		) {
134		$institution = new Institution($command->institution);
135
136		$institutionConfigurationId = InstitutionConfigurationId::from($institution);
		0 ignored issues – show Deprecated Code introduced 2017-02-06 16:23 UTC by Report Bug Copy Issue Report The method `Surfnet\Stepup\Configura...ConfigurationId::from()` has been deprecated with message: To be removed in next release; use normalizedFrom method to account for case-(in)sensitivity issues This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
137		$institutionConfiguration = $this->repository->load(
138		$institutionConfigurationId->getInstitutionConfigurationId()
139		);
140		$institutionConfiguration->destroy();
141
142		$this->repository->save($institutionConfiguration);
143		}
144
145		/**
146		* @deprecated Should be used until existing institution configurations have been migrated to using normalized ids
147		*
148		* @param Institution $institution
149		* @return InstitutionConfiguration
150		*/
151	View Code Duplication	private function loadInstitutionConfigurationFor(Institution $institution)
		0 ignored issues – show Duplication introduced 2017-02-06 16:23 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
152		{
153		try {
154		$institutionConfigurationId = InstitutionConfigurationId::normalizedFrom($institution);
155		$institutionConfiguration = $this->repository->load(
156		$institutionConfigurationId->getInstitutionConfigurationId()
157		);
158		} catch (AggregateNotFoundException $exception) {
159		$institutionConfigurationId = InstitutionConfigurationId::from($institution);
		0 ignored issues – show Deprecated Code introduced 2017-02-06 16:23 UTC by Report Bug Copy Issue Report The method `Surfnet\Stepup\Configura...ConfigurationId::from()` has been deprecated with message: To be removed in next release; use normalizedFrom method to account for case-(in)sensitivity issues This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
160		$institutionConfiguration = $this->repository->load(
161		$institutionConfigurationId->getInstitutionConfigurationId()
162		);
163		}
164
165		return $institutionConfiguration;
166		}
167		}
168

OpenConext / Stepup-Middleware

Pull Request — develop (#168)

__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like