SecondFactorNotAllowedException - Code Metrics - Inspection of "Enforce Allowed Second Factor List" - OpenConext/Stepup-Middleware - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#179)

by A.

created 2017-02-13 17:15 UTC

SecondFactorNotAllowedException A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	2
c	1
b	0
f	0
lcom	0
cbo	1
dl	0
loc	22
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getErrors()	0	4	1
A	__construct()	0	6	1

<?php

/**
 * Copyright 2017 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddleware\CommandHandlingBundle\Exception;

use Exception;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Surfnet\StepupMiddleware\CommandHandlingBundle\Pipeline\Exception\ProcessingAbortedException;

class SecondFactorNotAllowedException extends RuntimeException implements ProcessingAbortedException
{
    /**
     * @var string[]
     */
    private $errors;

    /**
     * @return string[]
     */
    public function getErrors()
    {
        return $this->errors;
    }

    public function __construct($message = "", $code = 0, Exception $previous = null)
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    {
        parent::__construct($message, $code, $previous);

        $this->errors[] = $message;
    }
}


1			<?php
2
3			/**
4			* Copyright 2017 SURFnet B.V.
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19			namespace Surfnet\StepupMiddleware\CommandHandlingBundle\Exception;
20
21			use Exception;
			0 ignored issues – show Bug introduced 2017-02-13 15:31 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Surfnet\StepupMiddleware...dle\Exception\Exception`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
22			use Surfnet\StepupMiddleware\CommandHandlingBundle\Pipeline\Exception\ProcessingAbortedException;
23
24			class SecondFactorNotAllowedException extends RuntimeException implements ProcessingAbortedException
25			{
26			/**
27			* @var string[]
28			*/
29			private $errors;
30
31			/**
32			* @return string[]
33			*/
34			public function getErrors()
35			{
36			return $this->errors;
37			}
38
39			public function __construct($message = "", $code = 0, Exception $previous = null)
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-02-13 15:31 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
40			{
41			parent::__construct($message, $code, $previous);
42
43			$this->errors[] = $message;
44			}
45			}
46

OpenConext / Stepup-Middleware

Pull Request — develop (#179)

SecondFactorNotAllowedException A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like