Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\RaCandidate

Complexity

Total Complexity

3

Size/Duplication

Total Lines	81
Duplicated Lines	13.58 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	nominate()	0	18	1
A	jsonSerialize()	11	11	1

<?php

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddleware\ApiBundle\Identity\Entity;

use Doctrine\ORM\Mapping as ORM;
use JsonSerializable;
use Surfnet\Stepup\Identity\Value\CommonName;
use Surfnet\Stepup\Identity\Value\Email;
use Surfnet\Stepup\Identity\Value\IdentityId;
use Surfnet\Stepup\Identity\Value\Institution;
use Surfnet\Stepup\Identity\Value\NameId;

/**
 * Be aware that this entity is used for the RA Candidate presentation only. This entity shouldn't be used to store any RA candidates.
 *
 * @ORM\Entity(repositoryClass="Surfnet\StepupMiddleware\ApiBundle\Identity\Repository\RaCandidateRepository", readOnly=true)
 */
class RaCandidate implements JsonSerializable

Since you have declared the constructor as private, maybe you should also declare the class as final.

{
    /**
     * @ORM\Id
     * @ORM\Column(length=36)
     *
     * @var string
     */
    public $identityId;

    /**
     * @ORM\Id
     * @ORM\Column(type="institution")
     *
     * @var Institution
     */
    public $raInstitution;

    /**
     * @ORM\Column(type="institution")
     *
     * @var \Surfnet\Stepup\Identity\Value\Institution
     */
    public $institution;

    /**
     * @ORM\Column(type="stepup_name_id")
     *
     * @var \Surfnet\Stepup\Identity\Value\NameId
     */
    public $nameId;

    /**
     * @ORM\Column(type="stepup_common_name")
     *
     * @var \Surfnet\Stepup\Identity\Value\CommonName
     */
    public $commonName;

    /**
     * @ORM\Column(type="stepup_email")
     *
     * @var \Surfnet\Stepup\Identity\Value\Email
     */
    public $email;

    private function __construct()
    {
    }

    public static function nominate(
        IdentityId $identityId,
        Institution $institution,
        NameId $nameId,
        CommonName $commonName,
        Email $email,
        Institution $raInstitution
    ) {
        $candidate                = new self();
        $candidate->identityId    = (string) $identityId;
        $candidate->institution   = $institution;
        $candidate->nameId        = $nameId;
        $candidate->commonName    = $commonName;
        $candidate->email         = $email;
        $candidate->raInstitution = $raInstitution;

        return $candidate;
    }

    public function jsonSerialize()

This method seems to be duplicated in your project.

    {
        return [
            'identity_id'    => $this->identityId,
            'institution'    => $this->institution,
            'common_name'    => $this->commonName,
            'email'          => $this->email,
            'name_id'        => $this->nameId,
            'ra_institution' => $this->raInstitution,
        ];
    }
}