View GitHub Repository Stepup-Middleware

Schedule Inspection
Subscribe
Passed
Push — fix-integration-tests ( 7756a6...cc952a )
by Pieter van der
05:42
created
Status
Category
Toggle Patches
src/Surfnet/StepupMiddleware/ApiBundle/Request/CommandValueResolver.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -44,9 +44,9 @@  discard block
 
 block discarded – undo
44 44 
         $this->assertIsValidCommandStructure($data);
45 45
46 46 
         $commandNameParts = [];
47 
-        $found = preg_match('~^(\w+):([\w\\.]+)$~', (string)$data['command']['name'], $commandNameParts);
47 
+        $found = preg_match('~^(\w+):([\w\\.]+)$~', (string) $data['command']['name'], $commandNameParts);
48 48 
         if ($found !== 1) {
49 
-            $message = sprintf('Command does not have a valid command name %s', (string)$data['command']['name']);
49 
+            $message = sprintf('Command does not have a valid command name %s', (string) $data['command']['name']);
50 50 
             throw new BadCommandRequestException(
51 51 
                 [$message],
52 52 
                 $message,
 
@@ -60,10 +60,10 @@  discard block
 
 block discarded – undo
60 60
61 61 
         /** @var AbstractCommand $command */
62 62 
         $command = new $commandClassName;
63 
-        $command->UUID = (string)$data['command']['uuid'];
63 
+        $command->UUID = (string) $data['command']['uuid'];
64 64
65 
-        foreach ((array)$data['command']['payload'] as $property => $value) {
66 
-            $properlyCasedProperty = lcfirst(str_replace(' ', '', ucwords(str_replace('_', ' ', (string)$property))));
65 
+        foreach ((array) $data['command']['payload'] as $property => $value) {
66 
+            $properlyCasedProperty = lcfirst(str_replace(' ', '', ucwords(str_replace('_', ' ', (string) $property))));
67 67 
             $command->$properlyCasedProperty = $value;
68 68 
         }
69 69
Please login to merge, or discard this patch.
src/Surfnet/Stepup/Identity/Event/IdentityRestoredEvent.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -51,10 +51,10 @@
 
 block discarded – undo
51 51 
     public function serialize(): array
52 52 
     {
53 53 
         return [
54 
-            'id' => (string)$this->id,
55 
-            'institution' => (string)$this->institution,
56 
-            'common_name' => (string)$this->commonName,
57 
-            'email' => (string)$this->email,
54 
+            'id' => (string) $this->id,
55 
+            'institution' => (string) $this->institution,
56 
+            'common_name' => (string) $this->commonName,
57 
+            'email' => (string) $this->email,
58 58 
         ];
59 59 
     }
60 60
Please login to merge, or discard this patch.
Surfnet/StepupMiddleware/ApiBundle/Identity/Projector/IdentityProjector.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch 
@@ -42,7 +42,7 @@  discard block
 
 block discarded – undo
42 42 
     {
43 43 
         $this->identityRepository->save(
44 44 
             Identity::create(
45 
-                (string)$event->identityId,
45 
+                (string) $event->identityId,
46 46 
                 $event->identityInstitution,
47 47 
                 $event->nameId,
48 48 
                 $event->email,
 
@@ -54,7 +54,7 @@  discard block
 
 block discarded – undo
54 54
55 55 
     public function applyIdentityRenamedEvent(IdentityRenamedEvent $event): void
56 56 
     {
57 
-        $identity = $this->identityRepository->find((string)$event->identityId);
57 
+        $identity = $this->identityRepository->find((string) $event->identityId);
58 58 
         $identity->commonName = $event->commonName;
59 59
60 60 
         $this->identityRepository->save($identity);
 
@@ -62,7 +62,7 @@  discard block
 
 block discarded – undo
62 62
63 63 
     public function applyIdentityEmailChangedEvent(IdentityEmailChangedEvent $event): void
64 64 
     {
65 
-        $identity = $this->identityRepository->find((string)$event->identityId);
65 
+        $identity = $this->identityRepository->find((string) $event->identityId);
66 66 
         $identity->email = $event->email;
67 67
68 68 
         $this->identityRepository->save($identity);
 
@@ -70,7 +70,7 @@  discard block
 
 block discarded – undo
70 70
71 71 
     public function applyLocalePreferenceExpressedEvent(LocalePreferenceExpressedEvent $event): void
72 72 
     {
73 
-        $identity = $this->identityRepository->find((string)$event->identityId);
73 
+        $identity = $this->identityRepository->find((string) $event->identityId);
74 74 
         $identity->preferredLocale = $event->preferredLocale;
75 75
76 76 
         $this->identityRepository->save($identity);
 
@@ -78,7 +78,7 @@  discard block
 
 block discarded – undo
78 78
79 79 
     public function applyIdentityRestoredEvent(IdentityRestoredEvent $event): void
80 80 
     {
81 
-        $identity = $this->identityRepository->find((string)$event->identityId);
81 
+        $identity = $this->identityRepository->find((string) $event->identityId);
82 82 
         $identity->email = $event->email;
83 83 
         $identity->commonName = $event->commonName;
84 84 
 
@@ -88,13 +88,13 @@  discard block
 
 block discarded – undo
88 88
89 89 
     public function applySecondFactorVettedEvent(SecondFactorVettedEvent $event): void
90 90 
     {
91 
-        $this->determinePossessionOfSelfAssertedToken($event->vettingType, (string)$event->identityId);
91 
+        $this->determinePossessionOfSelfAssertedToken($event->vettingType, (string) $event->identityId);
92 92 
     }
93 93
94 94 
     public function applySecondFactorVettedWithoutTokenProofOfPossession(
95 95 
         SecondFactorVettedWithoutTokenProofOfPossession $event,
96 96 
     ): void {
97 
-        $this->determinePossessionOfSelfAssertedToken($event->vettingType, (string)$event->identityId);
97 
+        $this->determinePossessionOfSelfAssertedToken($event->vettingType, (string) $event->identityId);
98 98 
     }
99 99
100 100 
     private function determinePossessionOfSelfAssertedToken(VettingType $vettingType, string $identityId): void
Please login to merge, or discard this patch.
ApiBundle/Doctrine/Type/SsoRegistrationBypassOptionType.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -50,12 +50,12 @@  discard block
 
 block discarded – undo
50 50 
                     "Encountered illegal sso registration bypass option %s '%s', expected a
51 51 
                     SsoRegistrationBypassOption instance",
52 52 
                     get_debug_type($value),
53 
-                    is_scalar($value) ? (string)$value : '',
53 
+                    is_scalar($value) ? (string) $value : '',
54 54 
                 ),
55 55 
             );
56 56 
         }
57 57
58 
-        return (int)$value->isEnabled();
58 
+        return (int) $value->isEnabled();
59 59 
     }
60 60
61 61 
     public function convertToPHPValue($value, AbstractPlatform $platform): ?SsoRegistrationBypassOption
 
@@ -65,7 +65,7 @@  discard block
 
 block discarded – undo
65 65 
         }
66 66
67 67 
         try {
68 
-            $ssoRegistrationBypassOption = new SsoRegistrationBypassOption((bool)$value);
68 
+            $ssoRegistrationBypassOption = new SsoRegistrationBypassOption((bool) $value);
69 69 
         } catch (TypeError $e) {
70 70 
             // get nice standard message, so we can throw it keeping the exception chain
71 71 
             $doctrineExceptionMessage = ConversionException::conversionFailed(
Please login to merge, or discard this patch.
GatewayBundle/Projector/InstitutionConfigurationProjector.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -40,7 +40,7 @@  discard block
 
 block discarded – undo
40 40 
     public function applyNewInstitutionConfigurationCreatedEvent(NewInstitutionConfigurationCreatedEvent $event): void
41 41 
     {
42 42 
         $institutionConfiguration = new InstitutionConfiguration(
43 
-            (string)$event->institution,
43 
+            (string) $event->institution,
44 44 
             $event->ssoOn2faOption->isEnabled(),
45 45 
             $event->ssoRegistrationBypassOption->isEnabled(),
46 46 
         );
 
@@ -50,7 +50,7 @@  discard block
 
 block discarded – undo
50 50
51 51 
     public function applySsoOn2faOptionChangedEvent(SsoOn2faOptionChangedEvent $event): void
52 52 
     {
53 
-        $institutionConfiguration = $this->repository->findByInstitution((string)$event->institution);
53 
+        $institutionConfiguration = $this->repository->findByInstitution((string) $event->institution);
54 54 
         if ($institutionConfiguration instanceof InstitutionConfiguration) {
55 55 
             $institutionConfiguration->ssoOn2faEnabled = $event->ssoOn2faOption->isEnabled();
56 56 
             $this->repository->save($institutionConfiguration);
 
@@ -59,7 +59,7 @@  discard block
 
 block discarded – undo
59 59 
         // It can happen that the event changed for an institution that already exists, but is not yet projected to
60 60 
         // this projection. In that case we can create it.
61 61 
         $institutionConfiguration = new InstitutionConfiguration(
62 
-            (string)$event->institution,
62 
+            (string) $event->institution,
63 63 
             $event->ssoOn2faOption->isEnabled(),
64 64 
             SsoRegistrationBypassOption::getDefault()->isEnabled(),
65 65 
         );
 
@@ -68,7 +68,7 @@  discard block
 
 block discarded – undo
68 68
69 69 
     public function applySsoRegistrationBypassOptionChangedEvent(SsoRegistrationBypassOptionChangedEvent $event): void
70 70 
     {
71 
-        $institutionConfiguration = $this->repository->findByInstitution((string)$event->institution);
71 
+        $institutionConfiguration = $this->repository->findByInstitution((string) $event->institution);
72 72 
         if ($institutionConfiguration instanceof InstitutionConfiguration) {
73 73 
             $institutionConfiguration->ssoRegistrationBypass = $event->ssoRegistrationBypassOption->isEnabled();
74 74 
             $this->repository->save($institutionConfiguration);
 
@@ -77,7 +77,7 @@  discard block
 
 block discarded – undo
77 77 
         // It can happen that the event changed for an institution that already exists, but is not yet projected to
78 78 
         // this projection. In that case we can create it.
79 79 
         $institutionConfiguration = new InstitutionConfiguration(
80 
-            (string)$event->institution,
80 
+            (string) $event->institution,
81 81 
             SsoOn2faOption::getDefault()->isEnabled(),
82 82 
             $event->ssoRegistrationBypassOption->isEnabled(),
83 83 
         );
 
@@ -86,7 +86,7 @@  discard block
 
 block discarded – undo
86 86
87 87 
     public function applyInstitutionConfigurationRemovedEvent(InstitutionConfigurationRemovedEvent $event): void
88 88 
     {
89 
-        $this->repository->removeFor((string)$event->institution);
89 
+        $this->repository->removeFor((string) $event->institution);
90 90 
     }
91 91
92 92 
     protected function applyIdentityForgottenEvent(IdentityForgottenEvent $event): void
Please login to merge, or discard this patch.